Skip to contentSkip to conversation

Staging: speakup: free after input_unregister_device()

PATCH In review Dan Carpenter 3 participants 3 messages Nov 12, 2010 – Nov 17, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: speakup: free after input_unregister_device()

input_unregister_device() frees the device so the call to input_free_device() is a double free.

drivers/staging/speakup/fakekey.c +0 -1
index adb93f2..65b2311 100644
@@ -62,7 +62,6 @@ void speakup_remove_virtual_keyboard(void)
 {
 	if (virt_keyboard != NULL) {
 		input_unregister_device(virt_keyboard);
-		input_free_device(virt_keyboard);
 		virt_keyboard = NULL;
 	}
 }
#1 lore raw

Hi Greg,

what is the status of this patch? I have looked at it and should definitely go in. Should it go to your staging-next tree or Linus's tree though since it is a bug fix?

Thanks,

William

#2 lore raw
In reply to Dan Carpenter
Quoted 5 lines · William Hubbs

Hi Greg,

what is the status of this patch? I have looked at it and should definitely go in. Should it go to your staging-next tree or Linus's tree though since it is a bug fix?

It's already included in my "staging-linus" git tree that will get sent to Linus on Friday to be included in the .37 final release.

thanks,

greg k-h