Skip to contentSkip to conversation

intel medfield: thermal_driver

PATCH In review Alan Cox 3 participants 6 messages Nov 11, 2010 – Nov 12, 2010 Hardware monitoring

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/2 intel medfield: thermal_driver

From: Durgadoss <[email protected]>

This is the basic thermal sensor driver for Intel MID platform using the Medfield chipset. It plugs in via the thermal drivers and provides sensor readings for the device sensors.

---

 drivers/hwmon/Kconfig             |    7 
 drivers/hwmon/Makefile            |    1 
 drivers/hwmon/intel_mid_thermal.c |  549 +++++++++++++++++++++++++++++++++++++
 3 files changed, 557 insertions(+), 0 deletions(-)
 create mode 100644 drivers/hwmon/intel_mid_thermal.c
drivers/hwmon/Kconfig +7 -0
index a56f6ad..d20aafd 100644
@@ -1171,6 +1171,13 @@ config SENSORS_MC13783_ADC
         help
           Support for the A/D converter on MC13783 PMIC.
 
+config SENSORS_THERMAL_MFLD
+        tristate "Thermal driver for Intel Medfield platform"
+        depends on INTEL_SCU_IPC && THERMAL
+        help
+          Say Y here to enable thermal driver for the  Intel Medfield
+          platform.
+
 if ACPI
 
 comment "ACPI drivers"
drivers/hwmon/Makefile +1 -0
index 2479b3d..e1f42f3 100644
@@ -109,6 +109,7 @@ obj-$(CONFIG_SENSORS_W83L785TS)	+= w83l785ts.o
 obj-$(CONFIG_SENSORS_W83L786NG)	+= w83l786ng.o
 obj-$(CONFIG_SENSORS_WM831X)	+= wm831x-hwmon.o
 obj-$(CONFIG_SENSORS_WM8350)	+= wm8350-hwmon.o
+obj-$(CONFIG_SENSORS_THERMAL_MFLD)   += intel_mid_thermal.o
 
 ifeq ($(CONFIG_HWMON_DEBUG_CHIP),y)
 EXTRA_CFLAGS += -DDEBUG
drivers/hwmon/intel_mid_thermal.c new file +547 -0

547 lines not on this page · raw message

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw
Quoted 10 lines · Alan Cox

From: Durgadoss <[email protected]>

This is the basic thermal sensor driver for Intel MID platform using the Medfield chipset. It plugs in via the thermal drivers and provides sensor readings for the device sensors.

---

As a thermal driver, shouldn't this driver be in drivers/thermal ?

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

author
#2 lore raw
In reply to Alan Cox
Quoted 7 lines · On Thu, 11 Nov 2010 12:56:54 -0800 Guenter Roeck <[email protected]>…
Quoted 6 lines · Alan Cox

From: Durgadoss <[email protected]>

This is the basic thermal sensor driver for Intel MID platform using the Medfield chipset. It plugs in via the thermal drivers and provides sensor readings for the device sensors.

Quoted 5 lines
Quoted 4 lines

---

As a thermal driver, shouldn't this driver be in drivers/thermal ?

drivers/thermal doesn't contain any drivers at all but I have no problem with being there or hwmon - whichever is best.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw
In reply to Alan Cox
Quoted 10 lines · Alan Cox
Quoted 7 lines · On Thu, 11 Nov 2010 12:56:54 -0800 Guenter Roeck <[email protected]>…
Quoted 6 lines · Alan Cox

From: Durgadoss <[email protected]>

This is the basic thermal sensor driver for Intel MID platform using the Medfield chipset. It plugs in via the thermal drivers and provides sensor readings for the device sensors.

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

---

As a thermal driver, shouldn't this driver be in drivers/thermal ?

drivers/thermal doesn't contain any drivers at all but I have no problem with being there or hwmon - whichever is best.

So far, all thermal drivers, including the Intel Medfield driver, are in platform directories. Not sure if that is a good location either. drivers/thermal seems to be the natural place. That there are no drivers in drivers/thermal should not be a reason to move it elsewhere. One driver has to be the first, after all.

hwmon just doesn't seem right, since hwmon support for thermal devices is optional.

Jean, any opinion ?

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#4 lore raw
In reply to Alan Cox
Quoted 26 lines · Guenter Roeck
Quoted 10 lines · Alan Cox
Quoted 7 lines · On Thu, 11 Nov 2010 12:56:54 -0800 Guenter Roeck <[email protected]>…
Quoted 6 lines · Alan Cox

From: Durgadoss <[email protected]>

This is the basic thermal sensor driver for Intel MID platform using the Medfield chipset. It plugs in via the thermal drivers and provides sensor readings for the device sensors.

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

---

As a thermal driver, shouldn't this driver be in drivers/thermal ?

drivers/thermal doesn't contain any drivers at all but I have no problem with being there or hwmon - whichever is best.

So far, all thermal drivers, including the Intel Medfield driver, are in platform directories. Not sure if that is a good location either. drivers/thermal seems to be the natural place. That there are no drivers in drivers/thermal should not be a reason to move it elsewhere. One driver has to be the first, after all.

Quoted 3 lines

hwmon just doesn't seem right, since hwmon support for thermal devices is optional.

Jean, any opinion ?

I don't really have time to formulate an educated opinion, sorry. So I'll trust you :)

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#5 lore raw
In reply to Alan Cox
Quoted 27 lines · Jean Delvare
Quoted 26 lines · Guenter Roeck
Quoted 10 lines · Alan Cox
Quoted 7 lines · On Thu, 11 Nov 2010 12:56:54 -0800 Guenter Roeck <[email protected]>…
Quoted 6 lines · Alan Cox

From: Durgadoss <[email protected]>

This is the basic thermal sensor driver for Intel MID platform using the Medfield chipset. It plugs in via the thermal drivers and provides sensor readings for the device sensors.

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

---

As a thermal driver, shouldn't this driver be in drivers/thermal ?

drivers/thermal doesn't contain any drivers at all but I have no problem with being there or hwmon - whichever is best.

So far, all thermal drivers, including the Intel Medfield driver, are in platform directories. Not sure if that is a good location either. drivers/thermal seems to be the natural place. That there are no drivers in drivers/thermal should not be a reason to move it elsewhere. One driver has to be the first, after all.

Quoted 7 lines
Quoted 3 lines

hwmon just doesn't seem right, since hwmon support for thermal devices is optional.

Jean, any opinion ?

I don't really have time to formulate an educated opinion, sorry. So I'll trust you :)

Ok ...

It leaves the scope of hwmon, so I posted the question to lkml. We'll see if anyone cares. If not, my proposal is to put it into drivers/thermal either through my hwmon-next branch, or through a new thermal branch in my tree (or through someone else's tree). Not sure if a new branch would make me the de-facto maintainer of the thermal subsystem, but it seems better than putting it into drivers/hwmon.

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors