Skip to contentSkip to conversation

ARM: S3C64XX: fix clock setup

PATCH New Darius Augulis 3 participants 7 messages Nov 12, 2010 – Nov 23, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: S3C64XX: fix clock setup

Fix pll divider values to standard ones described
in "S3C6410X RISC Microprocessor User's Manual,
Revision 1.20", p. 3-21.

---
 arch/arm/include/asm/arch-s3c64xx/s3c6400.h |   17 ++++++-----------
 1 files changed, 6 insertions(+), 11 deletions(-)
arch/arm/include/asm/arch-s3c64xx/s3c6400.h +6 -11
index 10b3324..a197b4e 100644
@@ -762,24 +762,19 @@
 #define TIMER3_ON		(TCON_3_ONOFF * 1)
 #define TIMER3_OFF		(FClrBit(TCON, TCON_3_ONOFF))
 
-#if defined(CONFIG_CLK_400_100_50)
+#if defined(CONFIG_CLK_400_133_66)
 #define STARTUP_AMDIV		400
 #define STARTUP_MDIV		400
-#define STARTUP_PDIV		6
-#define STARTUP_SDIV		1
-#elif defined(CONFIG_CLK_400_133_66)
-#define STARTUP_AMDIV		400
-#define STARTUP_MDIV		533
-#define STARTUP_PDIV		6
-#define STARTUP_SDIV		1
+#define STARTUP_PDIV		3
+#define STARTUP_SDIV		2
 #elif defined(CONFIG_CLK_533_133_66)
 #define STARTUP_AMDIV		533
-#define STARTUP_MDIV		533
-#define STARTUP_PDIV		6
+#define STARTUP_MDIV		266
+#define STARTUP_PDIV		3
 #define STARTUP_SDIV		1
 #elif defined(CONFIG_CLK_667_133_66)
 #define STARTUP_AMDIV		667
-#define STARTUP_MDIV		533
+#define STARTUP_MDIV		333
 #define STARTUP_PDIV		6
 #define STARTUP_SDIV		1
 #endif
#1 lore raw

PATCH 1/1 ARM: S3C64XX: fix clock setup

Dear Darius Augulis,

Quoted 9 lines · Darius Augulis

Fix pll divider values to standard ones described
in "S3C6410X RISC Microprocessor User's Manual,
Revision 1.20", p. 3-21.

---
?arch/arm/include/asm/arch-s3c64xx/s3c6400.h | ? 17 ++++++----------- ?1 files changed, 6 insertions(+), 11 deletions(-)

Hm, no..
Please consider s3c6400.
Those values are fit with s3c6400.

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH 1/1 ARM: S3C64XX: fix clock setup

Hi,

Quoted 13 lines · Minkyu Kang

Dear Darius Augulis,

Quoted 9 lines · Darius Augulis

Fix pll divider values to standard ones described
in "S3C6410X RISC Microprocessor User's Manual,
Revision 1.20", p. 3-21.

---
?arch/arm/include/asm/arch-s3c64xx/s3c6400.h | ? 17 ++++++----------- ?1 files changed, 6 insertions(+), 11 deletions(-)

Quoted 3 lines

Hm, no..
Please consider s3c6400.
Those values are fit with s3c6400.

does s3c6400 have different clock controller compared to s3c6410? I have only old manual of s3c6400 and it has the same equation for pll clock setting.
Please take a look into arch/arm/cpu/arm1176/s3c64xx/speed.c. There are common functions for both CPU's and
they work ok. So i guess my patch should not break s3c6400 operation. Btw, we don't have any working s3c6400 board in main line and it seems nobody is interested to have one.

Darius.

Quoted 7 lines

Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net

#3 lore raw

PATCH 1/1 ARM: S3C64XX: fix clock setup

Dear Darius Augulis,

Quoted 20 lines · Darius Augulis

Hi,

Quoted 13 lines · Minkyu Kang

Dear Darius Augulis,

Quoted 9 lines · Darius Augulis

Fix pll divider values to standard ones described
in "S3C6410X RISC Microprocessor User's Manual,
Revision 1.20", p. 3-21.

---
?arch/arm/include/asm/arch-s3c64xx/s3c6400.h | ? 17 ++++++----------- ?1 files changed, 6 insertions(+), 11 deletions(-)

Quoted 3 lines

Hm, no..
Please consider s3c6400.
Those values are fit with s3c6400.

Quoted 6 lines

does s3c6400 have different clock controller compared to s3c6410? I have only old manual of s3c6400 and it has the same equation for pll clock setting.
Please take a look into arch/arm/cpu/arm1176/s3c64xx/speed.c. There are common functions for both CPU's and
they work ok. So i guess my patch should not break s3c6400 operation.

According to the TRM...
Equations are same. but, recommended values are different. Your patch is no guarantee with s3c6400.
Did you tested with s3c6400?

Quoted 2 lines

Btw, we don't have any working s3c6400 board in main line and it seems nobody is interested to have one.

We have the SMDK6400.

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#4 lore raw

PATCH 1/1 ARM: S3C64XX: fix clock setup

Hi,

Quoted 23 lines · Minkyu Kang

Dear Darius Augulis,

Quoted 20 lines · Darius Augulis

Hi,

Quoted 16 lines · Minkyu Kang

Dear Darius Augulis,

Quoted 9 lines · Darius Augulis

Fix pll divider values to standard ones described
in "S3C6410X RISC Microprocessor User's Manual,
Revision 1.20", p. 3-21.

---
  arch/arm/include/asm/arch-s3c64xx/s3c6400.h |   17 ++++++-----------
  1 files changed, 6 insertions(+), 11 deletions(-)

Hm, no..
Please consider s3c6400.
Those values are fit with s3c6400.

Quoted 8 lines
Quoted 6 lines

does s3c6400 have different clock controller compared to s3c6410? I have only old manual of s3c6400 and it has the same equation for pll clock setting.
Please take a look into arch/arm/cpu/arm1176/s3c64xx/speed.c. There are common functions for both CPU's and
they work ok. So i guess my patch should not break s3c6400 operation.

According to the TRM...

what does this abbreviation mean?

Quoted 1 line

Equations are same. but, recommended values are different.

you are wrong. There is table in s3c6400 manual, but it doesn't contain recommended values, only examples how to calculate. Please find default values in APLL_CON, MPLL_CON and EPLL_CON0 registers. After reset, default frequency of APLL/MPLL for both s3c6400 and s3c6410 are 400MHz/133MHz respectively. But values in table in s3c6400 manual do not fit default register values for these frequencies. And recommended values in s3c6410 manual do. Therefore I suggest to use values from s3c6410 manual.

Quoted 2 lines

Your patch is no guarantee with s3c6400.
Did you tested with s3c6400?

no. please see next comment below.

Quoted 5 lines
Quoted 3 lines

Btw, we don't have any working s3c6400 board in main line and it seems nobody is interested to have one.

We have the SMDK6400.

you are wrong there again. it does not compile at all. for a long time enough.

Darius.

Quoted 3 lines

Thanks
Minkyu Kang

#5 lore raw

PATCH 1/1 ARM: S3C64XX: fix clock setup

Le 22/11/2010 18:44, Darius Augulis a ?crit :

Quoted 3 lines
Quoted 1 line

According to the TRM...

what does this abbreviation mean?

Technical Reference Manual.

Amicalement,

Signature · 1 line
Albert.
#6 lore raw

PATCH 1/1 ARM: S3C64XX: fix clock setup

In reply to Darius Augulis

Dear Darius Augulis,

Quoted 45 lines · Darius Augulis

Hi,

Quoted 29 lines · Minkyu Kang

Dear Darius Augulis,

Quoted 24 lines · On 19 November 2010 17:54, Darius Augulis<[email protected]> ?wrote:

Hi,

Quoted 19 lines · On Fri, Nov 19, 2010 at 10:32 AM, Minkyu Kang<[email protected]> ?wrote:

Dear Darius Augulis,

Quoted 10 lines · On 13 November 2010 03:05, Darius Augulis<[email protected]> ?wrote:

Fix pll divider values to standard ones described
in "S3C6410X RISC Microprocessor User's Manual,
Revision 1.20", p. 3-21.

---
?arch/arm/include/asm/arch-s3c64xx/s3c6400.h | ? 17 ++++++----------- ?1 files changed, 6 insertions(+), 11 deletions(-)

Hm, no..
Please consider s3c6400.
Those values are fit with s3c6400.

Quoted 8 lines
Quoted 6 lines

does s3c6400 have different clock controller compared to s3c6410? I have only old manual of s3c6400 and it has the same equation for pll clock setting.
Please take a look into arch/arm/cpu/arm1176/s3c64xx/speed.c. There are common functions for both CPU's and
they work ok. So i guess my patch should not break s3c6400 operation.

According to the TRM...

what does this abbreviation mean?

Quoted 1 line

Equations are same. but, recommended values are different.

Quoted 7 lines

you are wrong. There is table in s3c6400 manual, but it doesn't contain recommended values, only examples how to calculate. Please find default values in APLL_CON, MPLL_CON and EPLL_CON0 registers. After reset, default frequency of APLL/MPLL for both s3c6400 and s3c6410 are 400MHz/133MHz respectively. But values in table in s3c6400 manual do not fit default register values for these frequencies. And recommended values in s3c6410 manual do. Therefore I suggest to use values from s3c6410 manual.

It's not clear.
I didn't said that your patch is wrong.
I just asked you please consider s3c6400.
If you or someone else do test your patch on s3c6400 then I'll accept your patch.
Or, if you separate setup values from s3c6400 then I'll accept your patch. In this case, when somebody test your patch, then we can share values between s3c6400 and s3c6410.

Quoted 7 lines
Quoted 3 lines

Your patch is no guarantee with s3c6400.
Did you tested with s3c6400?

no. please see next comment below.

Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Btw, we don't have any working s3c6400 board in main line and it seems nobody is interested to have one.

We have the SMDK6400.

you are wrong there again. it does not compile at all. for a long time enough.

So we should drop this board?
No. I don't think so.
We (me or you or someone else) must fix it.

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net