Skip to contentSkip to conversation

staging: comedi: fix memory leak

PATCH New Nicolas Kaiser 1 participant 1 message Nov 13, 2010

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Nicolas Kaiser

author
#0 lore raw

PATCH 2/2 staging: comedi: fix memory leak

Instead of freeing outBuffer, inBuffer gets freed twice.

Signed-off-by Nicolas Kaiser <[email protected]>

---
Only compile tested. I hope I got it right?

 drivers/staging/comedi/drivers/usbdux.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/usbdux.c +2 -2
index aca4d14..696ee04 100644
@@ -2295,8 +2295,8 @@ static void tidy_up(struct usbduxsub *usbduxsub_tmp)
 	usbduxsub_tmp->inBuffer = NULL;
 	kfree(usbduxsub_tmp->insnBuffer);
 	usbduxsub_tmp->insnBuffer = NULL;
-	kfree(usbduxsub_tmp->inBuffer);
-	usbduxsub_tmp->inBuffer = NULL;
+	kfree(usbduxsub_tmp->outBuffer);
+	usbduxsub_tmp->outBuffer = NULL;
 	kfree(usbduxsub_tmp->dac_commands);
 	usbduxsub_tmp->dac_commands = NULL;
 	kfree(usbduxsub_tmp->dux_commands);
Signature · 1 line
1.7.2.2