net:Fix potential empty DHCP Parameter Request List
PATCH v2 1/1 net:Fix potential empty DHCP Parameter Request List
Can't get IP address with dhcp due to the dhcp server not allow the empty param list request under some network env
This patch is based on Gray Remlin's initial patch.
Signed-off-by Jason Liu <[email protected]>
Signed-off-by Gray Remlin <[email protected]>
---
Changes for v2:
- address the comments from Mike and re-order the code
--- net/bootp.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
net/bootp.c +4 -0
@@ -456,6 +456,10 @@ static int DhcpExtended (u8 * e, int message_type, IPaddr_t ServerID, IPaddr_t R *e++ =42 ; *cnt +=1 ;#endif +/* no options, so back up to avoid sending an empty request list */ +if (*cnt ==0 ) + e -=2 ; + *e++ =255 ;/* End of the list */ /* Pad to minimal length */
Signature · 1 line
1.7.0.4
Wolfgang Denk
AppliedPATCH v2 1/1 net:Fix potential empty DHCP Parameter Request List
Dear Jason Liu,
Quoted 8 lines · In message <[email protected]> you wrote:
Can't get IP address with dhcp due to the dhcp server not allow the empty param list request under some network env
This patch is based on Gray Remlin's initial patch.
Signed-off-by Jason Liu <[email protected]>Signed-off-by Gray Remlin <[email protected]>
Quoted 6 lines
---
Changes for v2:
- address the comments from Mike and re-order the code--- net/bootp.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The biggest difference between time and space is that you can't reuse time. - Merrick Furst