Skip to contentSkip to conversation

x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

PATCH In review Alan Cox 2 participants 4 messages Nov 15, 2010 – Nov 17, 2010 x86

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

From: Alan Cox <[email protected]>

Fix the build failure reported by Randy Dunlap

---

 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/Kconfig +1 -0
index 9e71608..afe50ec 100644
@@ -387,6 +387,7 @@ config X86_MRST
 	select APB_TIMER
 	select I2C
 	select SPI
+	select INTEL_SCU_IPC
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:
#1 lore raw
Quoted 16 lines · On Mon, 15 Nov 2010 17:31:19 +0000 Alan Cox wrote:

From: Alan Cox <[email protected]>

Fix the build failure reported by Randy Dunlap

---

 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/Kconfig +0 -0
index 9e71608..afe50ec 100644

arch/x86/Kconfig config X86_MRST · line 393

Quoted 7 lines
arch/x86/Kconfig +1 -0
@@ -387,6 +387,7 @@ config X86_MRST
 	select APB_TIMER
 	select I2C
 	select SPI
+	select INTEL_SCU_IPC
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:

Hi,
Additionally using this line from my patch:

+ select X86_PLATFORM_DEVICES

will avoid this warning (with your patch applied):

warning: (X86_MRST && PCI && PCI_GOANY && X86_32 && X86_EXTENDED_PLATFORM && X86_IO_APIC) selects INTEL_SCU_IPC which has unmet direct dependencies (X86 && X86_PLATFORM_DEVICES && X86_MRST)

which is due to the hierarchical menu structure.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#2 lore raw

[tip:x86/platform] x86, mrst: Fix dependencies of "select INTEL_SCU_IPC"

Commit-ID:  ad02519a0d27da4a0a50cbc696e810c94e27c28e
Gitweb:     http://git.kernel.org/tip/ad02519a0d27da4a0a50cbc696e810c94e27c28e
Author:     Randy Dunlap <[email protected]>
AuthorDate: Mon, 15 Nov 2010 10:14:06 -0800
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 17 Nov 2010 13:41:44 +0100

x86, mrst: Fix dependencies of "select INTEL_SCU_IPC"

commit b9fc71f47 (x86, mrst: The shutdown for MRST requires the SCU IPC mechanism) introduced the following warning:

warning: (X86_MRST && PCI && PCI_GOANY && X86_32 && X86_EXTENDED_PLATFORM && X86_IO_APIC) selects INTEL_SCU_IPC which has unmet direct dependencies (X86 && X86_PLATFORM_DEVICES && X86_MRST)

which is due to the hierarchical menu structure.

Select X86_PLATFORM_DEVICES as well.

Originally-from: Randy Dunlap <[email protected]>

LKML-Reference: <[email protected]>
Cc: Alan Cox <[email protected]>

---
 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/Kconfig +1 -0
index 6e877b9..655fcf5 100644
@@ -400,6 +400,7 @@ config X86_MRST
 	select I2C
 	select SPI
 	select INTEL_SCU_IPC
+	select X86_PLATFORM_DEVICES
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:
#3 lore raw
In reply to Alan Cox
Commit-ID:  b9fc71f47dc060c588e5099638242fad44eeecbc
Gitweb:     http://git.kernel.org/tip/b9fc71f47dc060c588e5099638242fad44eeecbc
Author:     Alan Cox <[email protected]>
AuthorDate: Mon, 15 Nov 2010 17:31:19 +0000
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 17 Nov 2010 13:27:44 +0100

x86, mrst: The shutdown for MRST requires the SCU IPC mechanism

Fix the build failure reported by Randy.

LKML-Reference: <[email protected]>

---
 arch/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/Kconfig +1 -0
index e5510cf..6e877b9 100644
@@ -399,6 +399,7 @@ config X86_MRST
 	select APB_TIMER
 	select I2C
 	select SPI
+	select INTEL_SCU_IPC
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips: