Skip to contentSkip to conversation

amd iommu: Fix HV crach with 32bit pv_ops kernel

PATCH In review Wei Wang2 2 participants 4 messages Nov 15, 2010

lore
Share & tools
lore

Wei Wang2

author
#0 lore raw

PATCH 1/1 amd iommu: Fix HV crach with 32bit pv_ops kernel

Hi Keir,
Attached patch should have fixed this issue:
http://lists.xensource.com/archives/html/xen-devel/2010-11/msg00374.html

Thanks,
Wei

Legal Information:
Advanced Micro Devices GmbH
Sitz: Dornach, Gemeinde Aschheim,
Landkreis München Registergericht München,
HRB Nr. 43632
Geschäftsführer:
Alberto Bozzo, Andrew Bowd

xen/include/asm-x86/hvm/svm/amd-iommu-proto.h +2 -2
diff -r 388c44a63613 xen/include/asm-x86/hvm/svm/amd-iommu-proto.h
@@ -31,8 +31,8 @@
 
 #define DMA_32BIT_MASK  0x00000000ffffffffULL
 
-extern int amd_iommu_debug;
-extern int amd_iommu_perdev_intremap;
+extern bool_t amd_iommu_debug;
+extern bool_t amd_iommu_perdev_intremap;
 
 #define AMD_IOMMU_DEBUG(fmt, args...) \
     do  \

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 4 lines
Quoted 1 line
Quoted 1 line · On 15.11.10 at 11:18, Wei Wang2 <[email protected]> wrote:

xen/include/asm-x86/hvm/svm/amd-iommu-proto.h line 38

Quoted 10 lines
xen/include/asm-x86/hvm/svm/amd-iommu-proto.h +2 -2
@@ -31,8 +31,8 @@
 
 #define DMA_32BIT_MASK  0x00000000ffffffffULL
 
-extern int amd_iommu_debug;
-extern int amd_iommu_perdev_intremap;
+extern bool_t amd_iommu_debug;
+extern bool_t amd_iommu_perdev_intremap;
 
 #define AMD_IOMMU_DEBUG(fmt, args...) \
    do  \

This surely can't be complete: If you had a type mismatch between declaration and definition, the defining code is clearly missing an #include of the #define-ing header.

Jan

author
#2 lore raw

PATCH 1/1 amd iommu: Fix HV crash with 32bit pv_ops kernel (V2)

Hi Jan
Could this new version be a little more clear?
Thanks,
Wei

Quoted 13 lines · On Monday 15 November 2010 13:37:27 Jan Beulich wrote:
Quoted 13 lines
Quoted 1 line
Quoted 1 line · On 15.11.10 at 11:18, Wei Wang2 <[email protected]> wrote:

--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06
2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Fri Nov 12
17:10:31 2010 +0100 @@ -31,8 +31,8 @@

#define DMA_32BIT_MASK 0x00000000ffffffffULL

(quoted diff) +2 -2
-extern int amd_iommu_debug;
-extern int amd_iommu_perdev_intremap;
+extern bool_t amd_iommu_debug;
+extern bool_t amd_iommu_perdev_intremap;
Quoted 8 lines
Quoted 2 lines
#define AMD_IOMMU_DEBUG(fmt, args...) \
    do  \

This surely can't be complete: If you had a type mismatch between declaration and definition, the defining code is clearly missing an #include of the #define-ing header.

Jan

xen/include/asm-x86/hvm/svm/amd-iommu-proto.h +0 -3
diff -r 388c44a63613 xen/include/asm-x86/hvm/svm/amd-iommu-proto.h
@@ -30,9 +30,6 @@
         &amd_iommu_head, list)
 
 #define DMA_32BIT_MASK  0x00000000ffffffffULL
-
-extern int amd_iommu_debug;
-extern int amd_iommu_perdev_intremap;
 
 #define AMD_IOMMU_DEBUG(fmt, args...) \
     do  \
xen/include/xen/iommu.h +2 -0
diff -r 388c44a63613 xen/include/xen/iommu.h
@@ -30,6 +30,8 @@ extern bool_t force_iommu, iommu_verbose
 extern bool_t force_iommu, iommu_verbose;
 extern bool_t iommu_workaround_bios_bug, iommu_passthrough;
 extern bool_t iommu_snoop, iommu_qinval, iommu_intremap;
+extern bool_t amd_iommu_debug;
+extern bool_t amd_iommu_perdev_intremap;
 
 extern struct rangeset *mmio_ro_ranges;
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#3 lore raw

Re: [PATCH] amd iommu: Fix HV crash with 32bit pv_ops kernel(V2)

Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 15.11.10 at 14:58, Wei Wang2 <[email protected]> wrote:

Hi Jan
Could this new version be a little more clear?
Thanks,
Wei

Yes (assuming the header you moved the decl-s to is included by the producer).

Jan

Quoted 22 lines · On Monday 15 November 2010 13:37:27 Jan Beulich wrote:
Quoted 21 lines
Quoted 13 lines
Quoted 1 line
Quoted 1 line · On 15.11.10 at 11:18, Wei Wang2 <[email protected]> wrote:

--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06
2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Fri Nov 12
17:10:31 2010 +0100 @@ -31,8 +31,8 @@

#define DMA_32BIT_MASK 0x00000000ffffffffULL

xen/include/asm-x86/hvm/svm/amd-iommu-proto.h +2 -2
-extern int amd_iommu_debug;
-extern int amd_iommu_perdev_intremap;
+extern bool_t amd_iommu_debug;
+extern bool_t amd_iommu_perdev_intremap;
Quoted 2 lines
#define AMD_IOMMU_DEBUG(fmt, args...) \
    do  \

This surely can't be complete: If you had a type mismatch between declaration and definition, the defining code is clearly missing an #include of the #define-ing header.

Jan