Skip to contentSkip to conversation

don't touch non-existent EHCI regs on MPC837x.

PATCH New Andre Schwarz 3 participants 7 messages Nov 15, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 don't touch non-existent EHCI regs on MPC837x.

---
 arch/powerpc/cpu/mpc83xx/cpu_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/cpu/mpc83xx/cpu_init.c +1 -1
index 7a1cae7..cfead18 100644
@@ -327,7 +327,7 @@ void cpu_init_f (volatile immap_t * im)
 	im->gpio[1].dir = CONFIG_SYS_GPIO2_DIR;
 #endif
 #ifdef CONFIG_USB_EHCI_FSL
-#ifndef CONFIG_MPC834x
+#if !defined(CONFIG_MPC834x) && !defined(CONFIG_MPC837x)
 	uint32_t temp;
 	struct usb_ehci *ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB_ADDR;
 
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 don't touch non-existent EHCI regs on MPC837x.

Quoted 5 lines · Andre Schwarz

---
arch/powerpc/cpu/mpc83xx/cpu_init.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

This doesn't seem quite right, the MPC837x has USB controllers.

- k

Quoted 21 lines
arch/powerpc/cpu/mpc83xx/cpu_init.c +1 -1
index 7a1cae7..cfead18 100644
@@ -327,7 +327,7 @@ void cpu_init_f (volatile immap_t * im)
 	im->gpio[1].dir = CONFIG_SYS_GPIO2_DIR;
 #endif
 #ifdef CONFIG_USB_EHCI_FSL
-#ifndef CONFIG_MPC834x
+#if !defined(CONFIG_MPC834x) && !defined(CONFIG_MPC837x)
 	uint32_t temp;
 	struct usb_ehci *ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB_ADDR;
 
Signature · 6 lines
1.7.0.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
#2 lore raw

PATCH 1/1 don't touch non-existent EHCI regs on MPC837x.

Kumar,

Quoted 9 lines
Quoted 5 lines

---
arch/powerpc/cpu/mpc83xx/cpu_init.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

This doesn't seem quite right, the MPC837x has USB controllers.

- k

yes, it has - and it is working fine.
But USB register range 0x00-0xff is reserved and hangs the CPU.

With this patch USB is working fine on at least MPC8377.

Quoted 13 lines
Quoted 13 lines
arch/powerpc/cpu/mpc83xx/cpu_init.c +1 -1
index 7a1cae7..cfead18 100644
@@ -327,7 +327,7 @@ void cpu_init_f (volatile immap_t * im)
 	im->gpio[1].dir = CONFIG_SYS_GPIO2_DIR;
 #endif
 #ifdef CONFIG_USB_EHCI_FSL
-#ifndef CONFIG_MPC834x
+#if !defined(CONFIG_MPC834x)&&  !defined(CONFIG_MPC837x)
 	uint32_t temp;
 	struct usb_ehci *ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB_ADDR;
 
Quoted 9 lines
Quoted 8 lines
Signature · 6 lines
1.7.0.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Andr?

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#3 lore raw

PATCH 1/1 don't touch non-existent EHCI regs on MPC837x.

Dear Andre Schwarz,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 2 lines

This doesn't seem quite right, the MPC837x has USB controllers.

yes, it has - and it is working fine.
But USB register range 0x00-0xff is reserved and hangs the CPU.

With this patch USB is working fine on at least MPC8377.

Then the commit message should make this clear. At the moment it is pretty much misleading.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Boss, n.: According to the Oxford English Dictionary, in  the  Middle
Ages  the  words  "boss"  and "botch" were largely synonymous, except
that boss, in addition to meaning  "a  supervisor  of  workers"  also
meant "an ornamental stud."
#4 lore raw

PATCH 1/1 don't touch non-existent EHCI regs on MPC837x.

Wolfgang,

Quoted 7 lines

Dear Andre Schwarz,

Quoted 3 lines · In message<[email protected]> you wrote:
Quoted 3 lines

This doesn't seem quite right, the MPC837x has USB controllers.

Quoted 8 lines
Quoted 5 lines

yes, it has - and it is working fine.
But USB register range 0x00-0xff is reserved and hangs the CPU.

With this patch USB is working fine on at least MPC8377.

Then the commit message should make this clear. At the moment it is pretty much misleading.

I didn't add this #ifdef but extended it to not only match 834x but also 837x.

All I see is that the ifdef'ed code accesses registers which are explicitely reserved on MPC834x and at least MPC837x.

What would be an appropriate commit message from your point of view ?

Regards,
Andr?

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#5 lore raw

PATCH 1/1 don't touch non-existent EHCI regs on MPC837x.

Dear Andre Schwarz,

Quoted 12 lines · In message <[email protected]> you wrote:
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines

This doesn't seem quite right, the MPC837x has USB controllers.

yes, it has - and it is working fine.
But USB register range 0x00-0xff is reserved and hangs the CPU.

With this patch USB is working fine on at least MPC8377.

Then the commit message should make this clear. At the moment it is pretty much misleading.

Quoted 5 lines

I didn't add this #ifdef but extended it to not only match 834x but also 837x.

All I see is that the ifdef'ed code accesses registers which are explicitely reserved on MPC834x and at least MPC837x.

Yes, I don't think this was objected at all.

Quoted 1 line

What would be an appropriate commit message from your point of view ?

Well, above you wrote "USB register range 0x00-0xff is reserved and hangs the CPU" - this probably explains the situation pretty well. However, the subject "non-existent EHCI regs" suggests to me that there are no USB registers at all.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Uncertain fortune is thoroughly mastered by the equity of the  calcu-
lation.                                               - Blaise Pascal
#6 lore raw

PATCH 1/1 don't touch non-existent EHCI regs on MPC837x.

Am 15.11.2010 17:16, schrieb Wolfgang Denk:

Quoted 18 lines

Dear Andre Schwarz,

Quoted 7 lines · In message<[email protected]> you wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

This doesn't seem quite right, the MPC837x has USB controllers.

yes, it has - and it is working fine.
But USB register range 0x00-0xff is reserved and hangs the CPU.

With this patch USB is working fine on at least MPC8377.

Quoted 8 lines
Quoted 3 lines

Then the commit message should make this clear. At the moment it is pretty much misleading.

I didn't add this #ifdef but extended it to not only match 834x but also 837x.

All I see is that the ifdef'ed code accesses registers which are explicitely reserved on MPC834x and at least MPC837x.

Quoted 7 lines

Yes, I don't think this was objected at all.

Quoted 1 line

What would be an appropriate commit message from your point of view ?

Well, above you wrote "USB register range 0x00-0xff is reserved and hangs the CPU" - this probably explains the situation pretty well. However, the subject "non-existent EHCI regs" suggests to me that there are no USB registers at all.

understood - will wait for further comments and resubmit tomorrow.

Regards,
Andr?

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner