Skip to contentSkip to conversation

HID: roccat: finishing usage of sysfs_create_bin_group()

PATCH In review Stefan Achatz 3 participants 5 messages Nov 15, 2010 – Nov 16, 2010 HID

lore
Share & tools
lore
#0 lore raw

cover HID: roccat: finishing usage of sysfs_create_bin_group()

These patches are against the newest roccat file versions (after applying everything I released the last days).
They fix some inattentive (though not critical) failures from previous patches and change hid-roccat-koneplus and hid-roccat-pyra to use the new sysfs_create_bin_group()
koneplus should be finished now (until I find errors)

Stefan

#1 lore raw
Quoted 6 lines · Stefan Achatz

These patches are against the newest roccat file versions (after applying everything I released the last days).
They fix some inattentive (though not critical) failures from previous patches and change hid-roccat-koneplus and hid-roccat-pyra to use the new sysfs_create_bin_group()
koneplus should be finished now (until I find errors)

Wait, they still don't resolve the main problem of this api is still racy and I can't accept it.

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg KH
Quoted 6 lines

These patches are against the newest roccat file versions (after applying everything I released the last days).
They fix some inattentive (though not critical) failures from previous patches and change hid-roccat-koneplus and hid-roccat-pyra to use the new sysfs_create_bin_group()
koneplus should be finished now (until I find errors)

Wait, they still don't resolve the main problem of this api is still racy and I can't accept it.

Yeah, I have already pointed Stefan to

	 http://lkml.org/lkml/2010/11/13/174

which he might have missed.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#3 lore raw
Quoted 9 lines · Greg KH
Quoted 8 lines
Quoted 7 lines

These patches are against the newest roccat file versions (after applying everything I released the last days).
They fix some inattentive (though not critical) failures from previous patches and change hid-roccat-koneplus and hid-roccat-pyra to use the new sysfs_create_bin_group()
koneplus should be finished now (until I find errors)

Quoted 8 lines
Quoted 2 lines

Wait, they still don't resolve the main problem of this api is still racy and I can't accept it.

Yeah, I have already pointed Stefan to

	 http://lkml.org/lkml/2010/11/13/174

which he might have missed.

Hello again,

I don't see why these patches can't be applied. The bin attribute group functions standing for themself seem to be useful. The kone driver is already in the stable kernel and has less code with these patches. Though this does not change its functionality its a code cleanup. Thats also true for pyra and koneplus. So for me these are clear improvements until I make progress in the race problem. I will do it, but being a newbe I don't know where to start (feel free to point me to something), so it might take quite some time and sure needs some questions asked.

Have a nice day
Stefan

#4 lore raw
Quoted 18 lines · Stefan Achatz
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

These patches are against the newest roccat file versions (after applying everything I released the last days).
They fix some inattentive (though not critical) failures from previous patches and change hid-roccat-koneplus and hid-roccat-pyra to use the new sysfs_create_bin_group()
koneplus should be finished now (until I find errors)

Quoted 8 lines
Quoted 2 lines

Wait, they still don't resolve the main problem of this api is still racy and I can't accept it.

Yeah, I have already pointed Stefan to

	 http://lkml.org/lkml/2010/11/13/174

which he might have missed.

Hello again,

Quoted 8 lines

I don't see why these patches can't be applied. The bin attribute group functions standing for themself seem to be useful. The kone driver is already in the stable kernel and has less code with these patches. Though this does not change its functionality its a code cleanup. Thats also true for pyra and koneplus. So for me these are clear improvements until I make progress in the race problem. I will do it, but being a newbe I don't know where to start (feel free to point me to something), so it might take quite some time and sure needs some questions asked.

Hi Stefan,

the way the driver does things is racy and needs fixing. Introducing interface into sysfs/driver core, which we now know is racy, is not something we'd like to do.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.