Skip to contentSkip to conversation

regulator: Move lp3971 regulator driver to subsys_initcall()

PATCH In review Axel Lin 3 participants 5 messages Nov 17, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: Move lp3971 regulator driver to subsys_initcall()

Regulators need to be available early in init in order to allow them to be available for consumers when requested.

Other regulator drivers are already moved to subsys_initcall(), looks like only lp3971 is missing.

---
 drivers/regulator/lp3971.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/lp3971.c +1 -1
index 0f22ef1..40520d9 100644
@@ -554,7 +554,7 @@ static int __init lp3971_module_init(void)
 
 	return ret;
 }
-module_init(lp3971_module_init);
+subsys_initcall(lp3971_module_init);
 
 static void __exit lp3971_module_exit(void)
 {
Signature · 1 line
1.7.2
#1 lore raw
Quoted 5 lines · Axel Lin

Regulators need to be available early in init in order to allow them to be available for consumers when requested.

Other regulator drivers are already moved to subsys_initcall(), looks like only lp3971 is missing.

My 2 cents: it is safer to create such patches with real HW when there is a need (we deal with a similar situation in i2c). Janitorial might do more harm than good. Another option might be to call the patch a RFC?

Regards,

Wolfram

Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
author
#2 lore raw

2010/11/17 Wolfram Sang <[email protected]>:

Quoted 10 lines · Axel Lin
Quoted 5 lines

Regulators need to be available early in init in order to allow them to be available for consumers when requested.

Other regulator drivers are already moved to subsys_initcall(), looks like only lp3971 is missing.

My 2 cents: it is safer to create such patches with real HW when there is a need (we deal with a similar situation in i2c). Janitorial might do more harm than good. Another option might be to call the patch a RFC?

Thanks for the comments.
I appreciate if someone who has this device can test it. I only have a similar device ( lp3972 ) and it works with using subsys_initcall().

Regards,
Axel

Quoted 18 lines

Regards,

  Wolfram

--
Pengutronix e.K.                           | Wolfram Sang                | Industrial Linux Solutions                 | http://www.pengutronix.de/  |

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkzjjlUACgkQD27XaX1/VRsF2QCfQn/bCEZSb0qkn1aj9SpqxsST zlMAoIyd6I+c4XitD1KRHe53/n3wlXOQ
=MQc1
-----END PGP SIGNATURE-----

#3 lore raw
In reply to Wolfram Sang
Quoted 11 lines · Wolfram Sang
Quoted 5 lines · Axel Lin

Regulators need to be available early in init in order to allow them to be available for consumers when requested.

Other regulator drivers are already moved to subsys_initcall(), looks like only lp3971 is missing.

My 2 cents: it is safer to create such patches with real HW when there is a need (we deal with a similar situation in i2c). Janitorial might do more harm than good. Another option might be to call the patch a RFC?

Essentially any regulator driver has this requirement, it's just something that was missed in the review when the patch was merged. Grant has an idea for dealing with this differently by postpoing registraton of dependant devices but for now all regulator drivers should be registered early.