mx51evk: savenv or env save command does not work
PATCH v2 1/1 mx51evk: savenv or env save command does not work
fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0
---
Changes for v2:
- Change MMC env size to 8KiB for the consideration for quick boot
--- include/configs/mx51evk.h | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
include/configs/mx51evk.h +4 -3
@@ -216,8 +216,9 @@*/ #define CONFIG_SYS_NO_FLASH -#define CONFIG_ENV_SECT_SIZE (128 * 1024) -#define CONFIG_ENV_SIZE CONFIG_ENV_SECT_SIZE -#define CONFIG_ENV_IS_NOWHERE +#define CONFIG_ENV_OFFSET (6 * 64 * 1024) +#define CONFIG_ENV_SIZE (8 * 1024) +#define CONFIG_ENV_IS_IN_MMC +#define CONFIG_SYS_MMC_ENV_DEV 0#endif
Signature · 1 line
1.7.0.4
PATCH v2 1/1 mx51evk: savenv or env save command does not work
Quoted 4 lines · Jason Liu
fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0
Quoted 8 lines
Signed-off-by Jason Liu <[email protected]>---
Changes for v2:
- Change MMC env size to 8KiB for the consideration for quick boot--- include/configs/mx51evk.h | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH v2 1/1 mx51evk: savenv or env save command does not work
Dear Stefano Babic,
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 6 lines · Jason Liu
fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0
Signed-off-by Jason Liu <[email protected]>
Quoted 8 lines
Quoted 6 lines
---
Changes for v2:
- Change MMC env size to 8KiB for the consideration for quick boot--- include/configs/mx51evk.h | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)Applied to u-boot-imx, thanks.
Arghh... Please allow others at least a few minutes for review. Better a few days.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de (null cookie; hope that's ok)
PATCH v2 1/1 mx51evk: savenv or env save command does not work
Quoted 17 lines · Wolfgang Denk
Dear Stefano Babic,
Quoted 14 lines · In message <[email protected]> you wrote:
Quoted 12 lines · Jason Liu
fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0
Signed-off-by Jason Liu <[email protected]>---
Changes for v2:
- Change MMC env size to 8KiB for the consideration for quick boot--- include/configs/mx51evk.h | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
Quoted 4 lines
Quoted 1 line
Applied to u-boot-imx, thanks.
Arghh... Please allow others at least a few minutes for review. Better a few days.
Sorry, it seemed to me there is a general agreement about the point and 8Kib, even if it less as suggested, is suitable in most cases. At least, this is what I thought, but I was too fast.
I will be not so hurried in future.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH v2 1/1 mx51evk: savenv or env save command does not work
In reply to Jason LiuDear Jason Liu,
Quoted 18 lines · In message <[email protected]> you wrote:
fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0
Signed-off-by Jason Liu <[email protected]>---
Changes for v2:
- Change MMC env size to 8KiB for the consideration for quick boot--- include/configs/mx51evk.h | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)include/configs/mx51evk.h +0
-0
include/configs/mx51evk.h line 222
Quoted 10 lines
include/configs/mx51evk.h +4
-3@@ -216,8 +216,9 @@*/ #define CONFIG_SYS_NO_FLASH -#define CONFIG_ENV_SECT_SIZE (128 * 1024) -#define CONFIG_ENV_SIZE CONFIG_ENV_SECT_SIZE -#define CONFIG_ENV_IS_NOWHERE +#define CONFIG_ENV_OFFSET (6 * 64 * 1024) +#define CONFIG_ENV_SIZE (8 * 1024) +#define CONFIG_ENV_IS_IN_MMC +#define CONFIG_SYS_MMC_ENV_DEV 0
The suggested env size was 16 KiB.
And I think you should add a comment where the 6 * 64 * 1024 is coming from and why exactly this values is considered to be a good one.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Open the pod bay doors, HAL." - Dave Bowman, 2001