ext4: missing unlock in ext4_clear_request_list()
Subsystems (2)
PATCH 1/1 ext4: missing unlock in ext4_clear_request_list()
If the the li_request_list was empty then it returned with the lock held. Instead of adding a "goto unlock" I just removed that special case and let it go past the empty list_for_each_safe().
Signed-off-by Dan Carpenter <[email protected]>
---
This is a static checker patch.
fs/ext4/super.c +0 -3
@@ -2799,9 +2799,6 @@ static void ext4_clear_request_list(void)struct ext4_li_request *elr;mutex_lock (&ext4_li_info->li_list_mtx); -if (list_empty (&ext4_li_info->li_request_list)) -return ; -list_for_each_safe (pos, n, &ext4_li_info->li_request_list) { elr = list_entry(pos, struct ext4_li_request, lr_request);
Ted Ts'o
maintainerQuoted 5 lines · Dan Carpenter
If the the
li_request_listwas empty then it returned with the lock held. Instead of adding a "goto unlock" I just removed that special case and let it go past the emptylist_for_each_safe().Signed-off-by Dan Carpenter <[email protected]>
Nice catch. Thanks, I've grabbed this and put it into the ext4 patch queue and will be pushing it to Linus ASAP.
- Ted