atm: fore200e: Fix build warning.
Subsystems (3)
David Miller
maintainerPATCH 1/1 atm: fore200e: Fix build warning.
GCC (rightfully) complains that:
drivers/atm/fore200e.c:614:5: warning: operation on 'cmdq->head' may be undefined
This is due to the FORE200E_NEXT_ENTRY macro, which essentially evaluates to:
i = ++i % m
Make it what's explicitly intended here which is:
i = (i + 1) % m
and the warning goes away.
Signed-off-by David S. Miller <[email protected]>
--- drivers/atm/fore200e.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/atm/fore200e.c +1 -1
@@ -92,7 +92,7 @@#define FORE200E_INDEX (virt_addr, type, index) (&((type *)(virt_addr))[ index ]) -#define FORE200E_NEXT_ENTRY (index, modulo) (index = ++(index) % (modulo)) +#define FORE200E_NEXT_ENTRY (index, modulo) (index = ((index) + 1) % (modulo))#if 1 #define ASSERT (expr) if (!(expr)) { \
Signature · 1 line
1.7.3.2