ssb: drop BCM4328 hack for SPROM revision
PATCH 1/1 ssb: drop BCM4328 hack for SPROM revision
This hacks leads to incorrect SPROM parsing for me and reading for example MAC
as: 00:00:00:54:00:00. Michael G. who introduced this confirmed it is not needed anymore.
---
Michael: I guess I could add your Tested-by. Is that right?
John: it's 2.6.38 ofc. It should apply cleanly no matter if you applied my previous patch for guessing unknown SPROM revision. There is not dependence between that 2 patches.
--- drivers/ssb/pci.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
drivers/ssb/pci.c +0 -4
@@ -580,10 +580,6 @@ static int sprom_extract(struct ssb_bus *bus, struct ssb_sprom *out,* Always extract r1. */ out->revision =1 ; ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n", out->revision); - }else if (bus->chip_id ==0x4321 ) { -/* the BCM4328 has a chipid == 0x4321 and a rev 4 SPROM */ - out->revision =4 ; - ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n", out->revision); }switch (out->revision) {
Signature · 1 line
1.6.0.4
PATCH 1/1 ssb: drop BCM4328 hack for SPROM revision
Quoted 7 lines
This hacks leads to incorrect SPROM parsing for me and reading for example MAC as: 00:00:00:54:00:00. Michael G. who introduced this confirmed it is not needed anymore.
Signed-off-by Rafał Miłecki <[email protected]>---
Michael: I guess I could add your Tested-by. Is that right?
That ist right. I suppose the correct entry would be
Quoted 22 lines
John: it's 2.6.38 ofc. It should apply cleanly no matter if you applied my previous patch for guessing unknown SPROM revision. There is not dependence between that 2 patches.
--- drivers/ssb/pci.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)drivers/ssb/pci.c +0
-0@@ -580,10 +580,6 @@ static int sprom_extract(struct ssb_bus *bus, struct
ssb_sprom*out, * Always extract r1. */drivers/ssb/pci.c +0
-0out->revision =1 ; ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n",
out->revision); - } else if (bus->chip_id==0x4321) {drivers/ssb/pci.c +0
-3-/* the BCM4328 has a chipid == 0x4321 and a rev 4 SPROM */ - out->revision =4 ; - ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n",
out->revision); }switch (
out->revision) {
Signature · 2 lines
Michael Gerdau email: [email protected] GPG-keys available on request or at public keyserver
PATCH 1/1 ssb: drop BCM4328 hack for SPROM revision
W dniu 18 listopada 2010 01:12 u?ytkownik Michael Gerdau <[email protected]> napisa?:
Quoted 10 lines
Quoted 7 lines
This hacks leads to incorrect SPROM parsing for me and reading for example MAC as: 00:00:00:54:00:00. Michael G. who introduced this confirmed it is not needed anymore.
Signed-off-by Rafa? Mi?ecki <[email protected]>---
Michael: I guess I could add your Tested-by. Is that right?That ist right. I suppose the correct entry would be
Tested-by Michael Gerdau <[email protected]>
John: can you add this, please?
Signature · 1 line
Rafa?