Skip to contentSkip to conversation

gdb: drop local stripping in favor of top level

PATCH New Mike Frysinger 3 participants 3 messages Nov 18, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gdb: drop local stripping in favor of top level

Since the top level takes care of stripping for us, and some file formats cannot be stripped safely (like FLAT which will error out), simply punt the manual stripping from the gdb package.

---
 toolchain/gdb/gdb.mk |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
toolchain/gdb/gdb.mk +0 -2
index c4fef89..54c3905 100644
@@ -97,7 +97,6 @@ $(GDB_TARGET_DIR)/gdb/gdb: $(GDB_TARGET_DIR)/.configured
 	gdb_cv_var_elf=yes \
 	$(MAKE) CC="$(TARGET_CC)" MT_CFLAGS="$(TARGET_CFLAGS)" \
 		-C $(GDB_TARGET_DIR)
-	$(STRIPCMD) $(GDB_TARGET_DIR)/gdb/gdb
 
 $(TARGET_DIR)/usr/bin/gdb: $(GDB_TARGET_DIR)/gdb/gdb
 	install -c -D $(GDB_TARGET_DIR)/gdb/gdb $(TARGET_DIR)/usr/bin/gdb
@@ -152,7 +151,6 @@ $(GDB_SERVER_DIR)/.configured: $(GDB_DIR)/.unpacked
 $(GDB_SERVER_DIR)/gdbserver: $(GDB_SERVER_DIR)/.configured
 	$(MAKE) CC="$(TARGET_CC)" MT_CFLAGS="$(TARGET_CFLAGS)" \
 		-C $(GDB_SERVER_DIR)
-	$(STRIPCMD) $(GDB_SERVER_DIR)/gdbserver
 
 $(TARGET_DIR)/usr/bin/gdbserver: $(GDB_SERVER_DIR)/gdbserver
 ifeq ($(BR2_CROSS_TOOLCHAIN_TARGET_UTILS),y)
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 gdb: drop local stripping in favor of top level

Quoted 5 lines · On Thu, 18 Nov 2010 05:26:51 -0500 Mike Frysinger <[email protected]> wrote:

Since the top level takes care of stripping for us, and some file formats cannot be stripped safely (like FLAT which will error out), simply punt the manual stripping from the gdb package.

BTW, since you're using the FLAT binary format, I suspect that you're using Buildroot on non-MMU systems. Do you have working non-MMU configurations that we could use for some build tests and potentially runtime tests ?

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 gdb: drop local stripping in favor of top level

In reply to Mike Frysinger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Frysinger <[email protected]> writes:

Mike> Since the top level takes care of stripping for us, and some file formats Mike> cannot be stripped safely (like FLAT which will error out), simply punt Mike> the manual stripping from the gdb package.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard