Skip to contentSkip to conversation

qlge: Fix incorrect usage of module parameters and netdev msg level

PATCH In review Sonny Rao 2 participants 3 messages Nov 18, 2010

Subsystems (2)
lore
Share & tools
lore

Sonny Rao

author
#0 lore raw

PATCH 1/1 qlge: Fix incorrect usage of module parameters and netdev msg level

Driver appears to be mistaking the permission field with default value in the case of debug and qlge_irq_type.

Driver is also passing debug as a bitmask into netif_msg_init() which wants a number of bits. Ron Mercer suggests we should change this to pass in -1 so the defaults get used instead, which makes the default much less verbose.

---

v2: Changed debug to be -1 and updated changelog

 drivers/net/qlge/qlge_main.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/qlge/qlge_main.c +3 -3
index d9a7626..66878bb 100644
@@ -62,15 +62,15 @@ static const u32 default_msg =
 /* NETIF_MSG_PKTDATA | */
     NETIF_MSG_HW | NETIF_MSG_WOL | 0;
 
-static int debug = 0x00007fff;	/* defaults above */
-module_param(debug, int, 0);
+static int debug = -1;	/* defaults above */
+module_param(debug, int, 0664);
 MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
 
 #define MSIX_IRQ 0
 #define MSI_IRQ 1
 #define LEG_IRQ 2
 static int qlge_irq_type = MSIX_IRQ;
-module_param(qlge_irq_type, int, MSIX_IRQ);
+module_param(qlge_irq_type, int, 0664);
 MODULE_PARM_DESC(qlge_irq_type, "0 = MSI-X, 1 = MSI, 2 = Legacy.");
 
 static int qlge_mpi_coredump;
#1 lore raw
Quoted 10 lines · Sonny Rao

Driver appears to be mistaking the permission field with default value in the case of debug and qlge_irq_type.

Driver is also passing debug as a bitmask into netif_msg_init() which wants a number of bits. Ron Mercer suggests we should change this to pass in -1 so the defaults get used instead, which makes the default much less verbose.

Milton/Sonny,
Did you happen to test this to see if the log output was the same?

author
#2 lore raw
Quoted 9 lines · Ron Mercer
Quoted 8 lines · Sonny Rao

Driver appears to be mistaking the permission field with default value in the case of debug and qlge_irq_type.

Driver is also passing debug as a bitmask into netif_msg_init() which wants a number of bits. Ron Mercer suggests we should change this to pass in -1 so the defaults get used instead, which makes the default much less verbose.

Quoted 5 lines
Quoted 2 lines

Milton/Sonny,
Did you happen to test this to see if the log output was the same?

Well, I haven't tried the -1 but I suspect it is much more sane than the 15 I had before because that was excessively verbose and I always ended up turning it down. I'll try it out and see.

Signature · 1 line
Sonny Rao, LTC OzLabs, BML team