show set_rtc_mmss: message only once
Subsystems (5)
RFC 1/1 show set_rtc_mmss: message only once
Occasionally system get in state where CMOS clock has gotten slightly ahead of current time and the periodic update of RTC fails. The message is a nuisance and repeats spamming the log.
See: http://www.ntp.org/ntpfaq/NTP-s-trbl-spec.htm#Q-LINUX-SET-RTC-MMSS
Rather than just removing the message, make it show only once and reduce severity since it indicates a normal and non urgent condition.
Signed-off-by Stephen Hemminger <[email protected]>
--- arch/alpha/kernel/time.c | 2 +- arch/cris/kernel/time.c | 2 +- arch/mips/dec/time.c | 2 +- arch/mips/include/asm/mc146818-time.h | 2 +- arch/mn10300/kernel/rtc.c | 2 +- arch/sh/boards/mach-sh03/rtc.c | 2 +- arch/x86/kernel/rtc.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)
arch/alpha/kernel/time.c +1 -1
@@ -506,7 +506,7 @@ set_rtc_mmss(unsigned long nowtime)CMOS_WRITE (real_seconds,RTC_SECONDS );CMOS_WRITE (real_minutes,RTC_MINUTES ); }else { -printk (KERN_WARNING +printk_once (KERN_NOTICE "set_rtc_mmss: can't update from %d to %d\n" , cmos_minutes, real_minutes); retval =-1 ;
arch/cris/kernel/time.c +1 -1
@@ -86,7 +86,7 @@ int set_rtc_mmss(unsigned long nowtime)CMOS_WRITE (real_seconds,RTC_SECONDS );CMOS_WRITE (real_minutes,RTC_MINUTES ); }else { -printk (KERN_WARNING +printk_once (KERN_NOTICE "set_rtc_mmss: can't update from %d to %d\n" , cmos_minutes, real_minutes); retval =-1 ;
arch/mips/dec/time.c +1 -1
@@ -104,7 +104,7 @@ int rtc_mips_set_mmss(unsigned long nowtCMOS_WRITE (real_seconds,RTC_SECONDS );CMOS_WRITE (real_minutes,RTC_MINUTES ); }else { -printk (KERN_WARNING +printk_once (KERN_NOTICE "set_rtc_mmss: can't update from %d to %d\n" , cmos_minutes, real_minutes); retval =-1 ;
arch/mips/include/asm/mc146818-time.h +1 -1
@@ -66,7 +66,7 @@ static inline int mc146818_set_rtc_mmss(CMOS_WRITE (real_seconds,RTC_SECONDS );CMOS_WRITE (real_minutes,RTC_MINUTES ); }else { -printk (KERN_WARNING +printk_once (KERN_NOTICE "set_rtc_mmss: can't update from %d to %d\n" , cmos_minutes, real_minutes); retval =-1 ;
arch/mn10300/kernel/rtc.c +1 -1
@@ -89,7 +89,7 @@ static int set_rtc_mmss(unsigned long noCMOS_WRITE (real_seconds,RTC_SECONDS );CMOS_WRITE (real_minutes,RTC_MINUTES ); }else { -printk (KERN_WARNING +printk_once (KERN_NOTICE "set_rtc_mmss: can't update from %d to %d\n" , cmos_minutes, real_minutes); retval =-1 ;
arch/sh/boards/mach-sh03/rtc.c +1 -1
@@ -108,7 +108,7 @@ static int set_rtc_mmss(unsigned long no__raw_writeb (real_minutes %10 ,RTC_MIN1 );__raw_writeb (real_minutes /10 ,RTC_MIN10 ); }else { -printk (KERN_WARNING +printk_once (KERN_NOTICE "set_rtc_mmss: can't update from %d to %d\n" , cmos_minutes, real_minutes); retval =-1 ;
arch/x86/kernel/rtc.c +1 -1
@@ -76,7 +76,7 @@ int mach_set_rtc_mmss(unsigned long nowtCMOS_WRITE (real_seconds,RTC_SECONDS );CMOS_WRITE (real_minutes,RTC_MINUTES ); }else { -printk (KERN_WARNING +printk_once (KERN_NOTICE "set_rtc_mmss: can't update from %d to %d\n" , cmos_minutes, real_minutes); retval =-1 ;