Skip to contentSkip to conversation

2.6.37-rc3 problems

PATCH In review werner 3 participants 9 messages Nov 22, 2010 – Nov 30, 2010 Staging

lore
Share & tools
lore

werner

author
#0 lore raw

2.6.37-rc3 problems

easycap_main.c lines 4251,4 : implicit declaration lock-kernel , unlock_kernel

(compilation error)

wl
---
Professional hosting for everyone - http://www.host.ru

#1 lore raw
Quoted 6 lines · werner

2.6.37-rc3 problems

easycap_main.c lines 4251,4 : implicit declaration lock-kernel ,
unlock_kernel

(compilation error)

Either disable this driver from your .config, or enable the BKL in your .config. I have a pending patch to get to Linus to fix this Kconfig issue for this driver.

Are you really using this driver?

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · On Sun, 21 Nov 2010 20:35:20 -0800 Greg KH wrote:
Quoted 6 lines · werner

2.6.37-rc3 problems

easycap_main.c lines 4251,4 : implicit declaration lock-kernel ,
unlock_kernel

(compilation error)

Either disable this driver from your .config, or enable the BKL in your .config. I have a pending patch to get to Linus to fix this Kconfig issue for this driver.

The build error happens even when CONFIG_BKL=y. In fact, that's the only way to enable EASYCAP, since EASYCAP depends on BKL.

Quoted 1 line

Are you really using this driver?

Werner builds a distro.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#3 lore raw
Quoted 8 lines · On Sun, 21 Nov 2010 20:56:26 -0800 Randy Dunlap wrote:
Quoted 6 lines · On Sun, 21 Nov 2010 20:35:20 -0800 Greg KH wrote:
Quoted 5 lines · werner

2.6.37-rc3 problems

easycap_main.c lines 4251,4 : implicit declaration lock-kernel ,
unlock_kernel

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

(compilation error)

Either disable this driver from your .config, or enable the BKL in your .config. I have a pending patch to get to Linus to fix this Kconfig issue for this driver.

The build error happens even when CONFIG_BKL=y. In fact, that's the only way to enable EASYCAP, since EASYCAP depends on BKL.

OTOH, adding <linux/smp_lock.h> to easycap.h fixes the build.

Quoted 3 lines
Quoted 1 line

Are you really using this driver?

Werner builds a distro.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#4 lore raw
Quoted 12 lines · Randy Dunlap
Quoted 10 lines · On Sun, 21 Nov 2010 20:56:26 -0800 Randy Dunlap wrote:
Quoted 8 lines · On Sun, 21 Nov 2010 20:35:20 -0800 Greg KH wrote:
Quoted 6 lines · werner

2.6.37-rc3 problems

easycap_main.c lines 4251,4 : implicit declaration lock-kernel ,
unlock_kernel

(compilation error)

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Either disable this driver from your .config, or enable the BKL in your .config. I have a pending patch to get to Linus to fix this Kconfig issue for this driver.

The build error happens even when CONFIG_BKL=y. In fact, that's the only way to enable EASYCAP, since EASYCAP depends on BKL.

OTOH, adding <linux/smp_lock.h> to easycap.h fixes the build.

Ah, nice. Someone want to send me a patch? :)

thanks,

greg k-h

#5 lore raw

PATCH 1/1 staging: easycap needs smp_lock.h, fixes build error

From: Randy Dunlap <[email protected]>

Add header file to fix build error:

drivers/staging/easycap/easycap_main.c:4251: error: implicit declaration of function 'lock_kernel' drivers/staging/easycap/easycap_main.c:4254: error: implicit declaration of function 'unlock_kernel'

---
 drivers/staging/easycap/easycap.h |    1 +
 1 file changed, 1 insertion(+)
drivers/staging/easycap/easycap.h +1 -0
@@ -75,6 +75,7 @@
 #include <linux/errno.h>
 #include <linux/init.h>
 #include <linux/slab.h>
+#include <linux/smp_lock.h>
 #include <linux/module.h>
 #include <linux/kref.h>
 #include <linux/usb.h>
author
#6 lore raw

Re: [PATCH] staging: easycap needs smp_lock.h, fixes build error

HELLO

I dont believe this ... my 2.6.37-rc4 compilation gone bad again, because of the same error, and I have to recompile / re-package it, what needs some hours again .. :( :(

The correction below worked on 2.6.37-rc3 (i.e. insert
#include <linux/smp_lock.h> into easycap_main.h)

WHY THIS WASN'T PATCHED SINCE LONG TIME ? Is the situation of the kernel developers similar bad like of the open office developers, so that they should be exchanged ???

w.landgraf

===========================================================

Quoted 17 lines · On Mon, 22 Nov 2010 12:12:37 -0800 Randy Dunlap <[email protected]> wrote:

From: Randy Dunlap <[email protected]>

Add header file to fix build error:

drivers/staging/easycap/easycap_main.c:4251: error: implicit declaration of function 'lock_kernel' drivers/staging/easycap/easycap_main.c:4254: error: implicit declaration of function 'unlock_kernel'

---
drivers/staging/easycap/easycap.h | 1 +

1 file changed, 1 insertion(+)

drivers/staging/easycap/easycap.h line 81

Quoted 7 lines
drivers/staging/easycap/easycap.h +1 -0
@@ -75,6 +75,7 @@
 #include <linux/errno.h>
 #include <linux/init.h>
 #include <linux/slab.h>
+#include <linux/smp_lock.h>
 #include <linux/module.h>
 #include <linux/kref.h>
 #include <linux/usb.h>

"werner" <[email protected]>
---
Professional hosting for everyone - http://www.host.ru

#7 lore raw

Re: [PATCH] staging: easycap needs smp_lock.h, fixes build error

Quoted 6 lines · werner

HELLO

I dont believe this ... my 2.6.37-rc4 compilation gone bad again, because of the same error, and I have to recompile / re-package it, what needs some hours again .. :( :(

Quoted 7 lines

The correction below worked on 2.6.37-rc3 (i.e. insert #include
<linux/smp_lock.h> into easycap_main.h)

WHY THIS WASN'T PATCHED SINCE LONG TIME ? Is the situation of the
kernel developers similar bad like of the open office developers, so that they should be exchanged ???

This is fixed in Linux-next and will be going to Linus in a few days.

thanks,

greg k-h

author
#8 lore raw

Re: [PATCH] staging: easycap needs smp_lock.h, fixes build error

OK For your information, the patch by r.dunlap works on 2.6.37-rc4 too, the second compilation (including the patch) was successful. wl

===========================

Quoted 16 lines · On Tue, 30 Nov 2010 06:57:40 -0800 Greg KH <[email protected]> wrote:
Quoted 6 lines · werner

HELLO

I dont believe this ... my 2.6.37-rc4 compilation gone bad again, because of the same error, and I have to recompile / re-package it, what needs some hours again .. :( :(

Quoted 8 lines

The correction below worked on 2.6.37-rc3 (i.e. insert
#include
<linux/smp_lock.h> into easycap_main.h)

WHY THIS WASN'T PATCHED SINCE LONG TIME ? Is the situation of the
kernel developers similar bad like of the open office developers, so that they should be exchanged ???

Quoted 7 lines

This is fixed in Linux-next and will be going to Linus in a few days.

thanks,

greg k-h

"werner" <[email protected]>
---
Professional hosting for everyone - http://www.host.ru