Skip to contentSkip to conversation

Input: ct82c710 - remove a redundant serio_register_port()

RFC PATCH In review Axel Lin 2 participants 2 messages Nov 22, 2010

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

RFC PATCH 1/1 Input: ct82c710 - remove a redundant serio_register_port()

We already call serio_register_port() in ct82c710_probe(), thus remove a redundant serio_register_port() in ct82c710_init().

Looks like this bug is introduced by 916d83cfe5da1cda454d8b0ae233f06b58bd7f91
"Input: ct82c710 - convert to the new platform device interface"

---
I don't have this hardware handy, I appreciate if someone can test this patch.

Regards,
Axel

 drivers/input/serio/ct82c710.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/input/serio/ct82c710.c +0 -2
index 4a30846..0f8304a 100644
@@ -237,8 +237,6 @@ static int __init ct82c710_init(void)
 	if (error)
 		goto err_free_device;
 
-	serio_register_port(ct82c710_port);
-
 	printk(KERN_INFO "serio: C&T 82c710 mouse port at %#llx irq %d\n",
 		(unsigned long long)CT82C710_DATA, CT82C710_IRQ);
 
Signature · 1 line
1.7.2
maintainer
#1 lore raw
Quoted 11 lines · Axel Lin

We already call serio_register_port() in ct82c710_probe(), thus remove a redundant serio_register_port() in ct82c710_init().

Looks like this bug is introduced by 916d83cfe5da1cda454d8b0ae233f06b58bd7f91
"Input: ct82c710 - convert to the new platform device interface"

---
I don't have this hardware handy, I appreciate if someone can test this patch.

I doubt anyone has; maybe I should start pruning older drivers...

BTW, the fix is obviously correct so I'll apply it and your other two patches as well. Thanks Axel.

Signature · 1 line
Dmitry