Skip to contentSkip to conversation

decnet: Move to staging

PATCH In review Ben Hutchings 3 participants 3 messages Nov 23, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 decnet: Move to staging

Recent review has revealed several bugs in obscure protocol implementations that can be exploited by local users for denial of service or privilege escalation.

The decnet protocol (PF_DECnet) is unmaintained. Since 2.6.12-rc2 the only changes appear to be adjustments for net API changes and fixes for bugs found by inspection.

This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users.

---
 drivers/staging/Kconfig |    2 ++
 net/Kconfig             |    2 --
 net/decnet/Kconfig      |    3 +++
 3 files changed, 5 insertions(+), 2 deletions(-)
drivers/staging/Kconfig +2 -0
index 5eafdf4..dd94cb2 100644
@@ -175,5 +175,7 @@ source "drivers/staging/intel_sst/Kconfig"
 
 source "drivers/staging/speakup/Kconfig"
 
+source "net/decnet/Kconfig"
+
 endif # !STAGING_EXCLUDE_BUILD
 endif # STAGING
net/Kconfig +0 -2
index 55fd82e..9e4fc29 100644
@@ -186,7 +186,6 @@ config BRIDGE_NETFILTER
 source "net/netfilter/Kconfig"
 source "net/ipv4/netfilter/Kconfig"
 source "net/ipv6/netfilter/Kconfig"
-source "net/decnet/netfilter/Kconfig"
 source "net/bridge/netfilter/Kconfig"
 
 endif
@@ -201,7 +200,6 @@ source "net/802/Kconfig"
 source "net/bridge/Kconfig"
 source "net/dsa/Kconfig"
 source "net/8021q/Kconfig"
-source "net/decnet/Kconfig"
 source "net/llc/Kconfig"
 source "net/ipx/Kconfig"
 source "drivers/net/appletalk/Kconfig"
net/decnet/Kconfig +3 -0
index 7914fd6..9d17166 100644
@@ -41,3 +41,6 @@ config DECNET_ROUTER
 
 	  See <file:Documentation/networking/decnet.txt> for more information.
 
+if NETFILTER
+source "net/decnet/netfilter/Kconfig"
+endif
Signature · 1 line
1.7.2.3
#1 lore raw
Quoted 8 lines · On Tue, 23 Nov 2010 03:51:53 +0000 Ben Hutchings <[email protected]> wrote:

Recent review has revealed several bugs in obscure protocol implementations that can be exploited by local users for denial of service or privilege escalation.

The decnet protocol (PF_DECnet) is unmaintained. Since 2.6.12-rc2 the only changes appear to be adjustments for net API changes and fixes for bugs found by inspection.

Quoted 5 lines

This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users.

NAK there are still users and stuff does get fixed. If you don't like it then disable it from config.

maintainer
#2 lore raw

From: Stephen Hemminger <[email protected]>
Date: Mon, 22 Nov 2010 20:31:31 -0800

Quoted 11 lines
Quoted 8 lines · On Tue, 23 Nov 2010 03:51:53 +0000 Ben Hutchings <[email protected]> wrote:

Recent review has revealed several bugs in obscure protocol implementations that can be exploited by local users for denial of service or privilege escalation.

The decnet protocol (PF_DECnet) is unmaintained. Since 2.6.12-rc2 the only changes appear to be adjustments for net API changes and fixes for bugs found by inspection.

Quoted 8 lines
Quoted 5 lines

This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users.

NAK there are still users and stuff does get fixed. If you don't like it then disable it from config.

Seriously, I can't even remember a bonifides security flaw in decnet being found recently and in fact the decnet stack is very well written code.