Skip to contentSkip to conversation

toolchain-external: allow vendor-controlled defaults

PATCH Superseded Mike Frysinger 2 participants 5 messages Nov 18, 2010 – Nov 24, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain-external: allow vendor-controlled defaults

---
 toolchain/toolchain-external/Config.in.2 |   11 +++++++++++
 toolchain/toolchain-external/ext-tool.mk |    2 ++
 2 files changed, 13 insertions(+), 0 deletions(-)
toolchain/toolchain-external/Config.in.2 +11 -0
index 489558c..50e61e6 100644
@@ -1,15 +1,26 @@
 #
 
 if BR2_TOOLCHAIN_EXTERNAL
+
+config BR2_TOOLCHAIN_OVERRIDE_VENDOR
+	bool "Override vendor/device toolchain defaults" if BR2_bfin
+	default y
+	help
+	  Some targets have standard toolchain namings which the
+	  vendor/device maintainer have defined.  If you wish to
+	  override their choices, say Y here.
+
 config BR2_TOOLCHAIN_EXTERNAL_PATH
 	string "External toolchain path"
 	default "/path/to/staging_dir/usr"
+	depends on BR2_TOOLCHAIN_OVERRIDE_VENDOR
 	help
 	  Path to where the external toolchain is installed.
 
 config BR2_TOOLCHAIN_EXTERNAL_PREFIX
 	string "External toolchain prefix"
 	default "$(ARCH)-linux"
+	depends on BR2_TOOLCHAIN_OVERRIDE_VENDOR
 	help
 	  This the the external toolchain prefix. For example:
 	    armeb-unknown-linux-gnu, mipsel-unknown-linux-gnu, etc.
toolchain/toolchain-external/ext-tool.mk +2 -0
index 7e4645d..2501256 100644
@@ -37,6 +37,8 @@
 #  cross-compiler binaries remains external, all libraries and headers
 #  are imported into the Buildroot tree.
 
+-include target/device/*/ext-tool.mk
+
 uclibc: dependencies $(STAMP_DIR)/ext-toolchain-installed
 
 LIB_EXTERNAL_LIBS=ld*.so libc.so libcrypt.so libdl.so libgcc_s.so libm.so libnsl.so libresolv.so librt.so libutil.so
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 toolchain-external: allow vendor-controlled defaults

Hello,

Quoted 5 lines · On Thu, 18 Nov 2010 05:28:21 -0500 Mike Frysinger <[email protected]> wrote:
---
 toolchain/toolchain-external/Config.in.2 |   11 +++++++++++
 toolchain/toolchain-external/ext-tool.mk |    2 ++
 2 files changed, 13 insertions(+), 0 deletions(-)

Could you explain a little bit the rationale behind this ?

toolchain/toolchain-external/ext-tool.mk line 41

Quoted 9 lines

index 7e4645d..2501256 100644

toolchain/toolchain-external/ext-tool.mk +2 -0
@@ -37,6 +37,8 @@
 #  cross-compiler binaries remains external, all libraries and headers
 #  are imported into the Buildroot tree.
 
+-include target/device/*/ext-tool.mk
+

I definitely really don't like this. Could you elaborate a bit on what you would like to do ?

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 toolchain-external: allow vendor-controlled defaults

Hello,

Quoted 5 lines · On Thu, 18 Nov 2010 11:55:29 +0100 Thomas Petazzoni…
Quoted 2 lines

+-include target/device/*/ext-tool.mk
+

I definitely really don't like this. Could you elaborate a bit on what you would like to do ?

Mike, could you give an example of an ext-tool.mk you are using, for me to better understand what feature you want ?

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 toolchain-external: allow vendor-controlled defaults

Quoted 9 lines · On Tuesday, November 23, 2010 16:35:13 Thomas Petazzoni wrote:
Quoted 5 lines · On Thu, 18 Nov 2010 11:55:29 +0100 Thomas Petazzoni wrote:
Quoted 2 lines

+-include target/device/*/ext-tool.mk
+

I definitely really don't like this. Could you elaborate a bit on what you would like to do ?

Mike, could you give an example of an ext-tool.mk you are using, for me to better understand what feature you want ?

http://blackfin.uclinux.org/git/?p=users/vapier/buildroot.git;a=blob;f=target/device/AnalogDevices/arch-
bfin/ext- tool.mk;h=e5c1713bc9ddb0a2e5daaf35af3d97188c73272b;hb=1bfab3167398d64b16ac1b8b97f8d90c28f3ec29 -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101123/5f6b15c9/attachment.pgp>

#4 lore raw

PATCH v2 1/1 toolchain-external: allow vendor-controlled defaults

In reply to Mike Frysinger

Some vendors (like ADI and the Blackfin processor) maintain & ship binary toolchains that are up-to-date and have been fully tested. They also use a standard toolchain prefix. Since these are (by and large) the packages that users leverage when compiling Blackfin code, it doesn't make sense to force them to manually input the toolchain name themselves. So let ADI configurations set up reasonable defaults to make people's lives easier.

---
 toolchain/toolchain-external/Config.in.2 |   11 +++++++++++
 toolchain/toolchain-external/ext-tool.mk |    2 ++
 2 files changed, 13 insertions(+), 0 deletions(-)
toolchain/toolchain-external/Config.in.2 +11 -0
index 489558c..50e61e6 100644
@@ -1,15 +1,26 @@
 #
 
 if BR2_TOOLCHAIN_EXTERNAL
+
+config BR2_TOOLCHAIN_OVERRIDE_VENDOR
+	bool "Override vendor/device toolchain defaults" if BR2_bfin
+	default y
+	help
+	  Some targets have standard toolchain namings which the
+	  vendor/device maintainer have defined.  If you wish to
+	  override their choices, say Y here.
+
 config BR2_TOOLCHAIN_EXTERNAL_PATH
 	string "External toolchain path"
 	default "/path/to/staging_dir/usr"
+	depends on BR2_TOOLCHAIN_OVERRIDE_VENDOR
 	help
 	  Path to where the external toolchain is installed.
 
 config BR2_TOOLCHAIN_EXTERNAL_PREFIX
 	string "External toolchain prefix"
 	default "$(ARCH)-linux"
+	depends on BR2_TOOLCHAIN_OVERRIDE_VENDOR
 	help
 	  This the the external toolchain prefix. For example:
 	    armeb-unknown-linux-gnu, mipsel-unknown-linux-gnu, etc.
toolchain/toolchain-external/ext-tool.mk +2 -0
index 7e4645d..2501256 100644
@@ -37,6 +37,8 @@
 #  cross-compiler binaries remains external, all libraries and headers
 #  are imported into the Buildroot tree.
 
+-include target/device/*/ext-tool.mk
+
 uclibc: dependencies $(STAMP_DIR)/ext-toolchain-installed
 
 LIB_EXTERNAL_LIBS=ld*.so libc.so libcrypt.so libdl.so libgcc_s.so libm.so libnsl.so libresolv.so librt.so libutil.so
Signature · 1 line
1.7.3.2