-rc: USB: yurex: add .llseek fop to file_operations
PATCH RESEND 1/1 -rc: USB: yurex: add .llseek fop to file_operations
Hi Greg-KH,
Sorry for resending this; To: was not enough.
https://bugzilla.kernel.org/show_bug.cgi?id=23512
Default llseek operation behavior was changed by the patch named "vfs: make no_llseek the default" after the yurex driver was merged, so the llseek to yurex is now ignored.
This patch add llseek fop with default_llseek to yurex driver to catch up to the change.
1 files changed, 1 insertions(+), 0 deletions(-)
drivers/usb/misc/yurex.c +1 -0
@@ -536,6 +536,7 @@ static const struct file_operations yurex_fops = { .open = yurex_open, .release = yurex_release, .fasync = yurex_fasync, + .llseek = default_llseek, };
Signature · 1 line
1.7.0
Quoted 5 lines · Tomoki Sekiyama
Hi Greg-KH,
Sorry for resending this; To: was not enough.
Quoted 8 lines
Default llseek operation behavior was changed by the patch named "vfs: make
no_llseekthe default" after the yurex driver was merged, so the llseek to yurex is now ignored.This patch add llseek fop with
default_llseekto yurex driver to catch up to the change.Signed-off-by Tomoki Sekiyama <[email protected]>
It's in my queue, sorry, been without power and water at home for a few days, will catch up on this stuff next week...
thanks,
greg k-h
Quoted 10 lines · On Thursday 25 November 2010 18:16:13 Greg KH wrote:
Quoted 9 lines · Tomoki Sekiyama
Hi Greg-KH,
Sorry for resending this; To: was not enough.https://bugzilla.kernel.org/show_bug.cgi?id=23512
Default llseek operation behavior was changed by the patch named "vfs: make
no_llseekthe default" after the yurex driver was merged, so the llseek to yurex is now ignored.
Quoted 7 lines
Quoted 4 lines
This patch add llseek fop with
default_llseekto yurex driver to catch up to the change.Signed-off-by Tomoki Sekiyama <[email protected]>It's in my queue, sorry, been without power and water at home for a few days, will catch up on this stuff next week...
I was out most of the week, so I didn't get to look at it either. Is there an actual bug here caused by having no .llseek function?
As far as I can tell, you don't really want to seek this file anyway, so the default behaviour of disallowing llseek would actually make more sense.
Arnd
2010/11/27 Arnd Bergmann <[email protected]>:
Quoted 19 lines · On Thursday 25 November 2010 18:16:13 Greg KH wrote:
Quoted 10 lines · Tomoki Sekiyama
Quoted 9 lines
Hi Greg-KH,
Sorry for resending this; To: was not enough.https://bugzilla.kernel.org/show_bug.cgi?id=23512
Default llseek operation behavior was changed by the patch named "vfs: make
no_llseekthe default" after the yurex driver was merged, so the llseek to yurex is now ignored.Quoted 7 lines
Quoted 4 lines
This patch add llseek fop with
default_llseekto yurex driver to catch up to the change.Signed-off-by Tomoki Sekiyama <[email protected]>It's in my queue, sorry, been without power and water at home for a few days, will catch up on this stuff next week...
Quoted 6 lines
I was out most of the week, so I didn't get to look at it either. Is there an actual bug here caused by having no .llseek function?
As far as I can tell, you don't really want to seek this file anyway, so the default behaviour of disallowing llseek would actually make more sense.
I need seek because the device notifies the update of the sensor's value by fasync, then the user can rewind(seek to 0) and re-read the file.
Thanks,
--
Tomoki Sekiyama
Arnd Bergmann
Acked-byQuoted 8 lines · Tomoki Sekiyama
2010/11/27 Arnd Bergmann <[email protected]>:
Quoted 3 lines
As far as I can tell, you don't really want to seek this file anyway, so the default behaviour of disallowing llseek would actually make more sense.
I need seek because the device notifies the update of the sensor's value by fasync, then the user can rewind(seek to 0) and re-read the file.
Yes, that makes sense.