Skip to contentSkip to conversation

ppc4xx: Remove bogus comment from start.S

PATCH New Stefan Roese 2 participants 3 messages Nov 23, 2010 – Nov 26, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Remove bogus comment from start.S

---
 arch/powerpc/cpu/ppc4xx/start.S |   17 +++--------------
 1 files changed, 3 insertions(+), 14 deletions(-)
arch/powerpc/cpu/ppc4xx/start.S +3 -14
index 65195f5..c36c13b 100644
@@ -48,21 +48,10 @@
  *-------------------------------------------------------------------------------
  */
 
-/*  U-Boot - Startup Code for AMCC 4xx PowerPC based Embedded Boards
- *
- *
- *  The processor starts at 0xfffffffc and the code is executed
- *  from flash/rom.
- *  in memory, but as long we don't jump around before relocating.
- *  board_init lies at a quite high address and when the cpu has
- *  jumped there, everything is ok.
- *  This works because the cpu gives the FLASH (CS0) the whole
- *  address space at startup, and board_init lies as a echo of
- *  the flash somewhere up there in the memorymap.
- *
- *  board_init will change CS0 to be positioned at the correct
- *  address and (s)dram will be positioned at address 0
+/*
+ * Startup code for IBM/AMCC PowerPC 4xx (PPC4xx) based boards
  */
+
 #include <asm-offsets.h>
 #include <config.h>
 #include <asm/ppc4xx.h>
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 ppc4xx: Remove bogus comment from start.S

Dear Stefan Roese,

Quoted 20 lines · In message <[email protected]> you wrote:
---
 arch/powerpc/cpu/ppc4xx/start.S |   17 +++--------------
 1 files changed, 3 insertions(+), 14 deletions(-)
arch/powerpc/cpu/ppc4xx/start.S +0 -7
index 65195f5..c36c13b 100644
@@ -48,21 +48,10 @@
  *-------------------------------------------------------------------------------
  */
 
-/*  U-Boot - Startup Code for AMCC 4xx PowerPC based Embedded Boards
- *
- *
- *  The processor starts at 0xfffffffc and the code is executed
- *  from flash/rom.
- *  in memory, but as long we don't jump around before relocating.
- *  board_init lies at a quite high address and when the cpu has

arch/powerpc/cpu/ppc4xx/start.S line 53

Quoted 10 lines
arch/powerpc/cpu/ppc4xx/start.S +2 -7
- *  jumped there, everything is ok.
- *  This works because the cpu gives the FLASH (CS0) the whole
- *  address space at startup, and board_init lies as a echo of
- *  the flash somewhere up there in the memorymap.
- *
- *  board_init will change CS0 to be positioned at the correct
- *  address and (s)dram will be positioned at address 0
+/*
+ * Startup code for IBM/AMCC PowerPC 4xx (PPC4xx) based boards
  */

It appears that the old comment contained some information about how booting and especially address resolution works on 4xx. Is there some way to keep this (non-obvious, at least to me) information, instead of just deleting it?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He who hesitates is not only lost, but miles from the next exit.
#2 lore raw

PATCH 1/1 ppc4xx: Remove bogus comment from start.S

Hi Wolfgang,

Quoted 4 lines · On Tuesday 23 November 2010 20:58:24 Wolfgang Denk wrote:

It appears that the old comment contained some information about how booting and especially address resolution works on 4xx. Is there some way to keep this (non-obvious, at least to me) information, instead of just deleting it?

The old comment was really screwed up. I'll send a patch with a (hopefully) better description shortly.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de