bugfix: image header pointer change.
PATCH 1/1 bugfix: image header pointer change.
images.legacy_hdr_os should point to the new copied structure, not the original structure which may be over written.
--- common/cmd_bootm.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
common/cmd_bootm.c +0 -0
@@ -896,10 +896,9 @@ static void *boot_get_kernel (cmd_tbl_t *cmdtp,
int flag, int argc, char * const
memmove (&images->legacy_hdr_os_copy, hdr, sizeof(image_header_t));
/* save pointer to image header */
- images->legacy_hdr_os = hdr;
-
+ images->legacy_hdr_os = &images->legacy_hdr_os_copy;
images->legacy_hdr_valid = 1;
- show_boot_progress (6);
+ show_boot_progress (6);
break;
#if defined(CONFIG_FIT)
case IMAGE_FORMAT_FIT:
Signature · 1 line
1.7.3.1.msysgit.0
PATCH 1/1 bugfix: image header pointer change.
Review
Quoted 2 lines · On Friday, November 26, 2010 18:59:42 Baidu Boy wrote:
(quoted diff) +1
-1- show_boot_progress (6); + show_boot_progress (6);
this doesnt seem to actually be changing anything. you should avoid unrelated syntax changes with functional changes.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101126/64a2c460/attachment.pgp
PATCH 1/1 bugfix: image header pointer change.
Hi,Mike:
the purpose of below code is to copy the image header to the static variable images.legacy_hdr_os_copy, and then the images.legacy_hdr_os points to the
image header in the static variable images.
------
memmove (&images->legacy_hdr_os_copy, hdr, sizeof(image_header_t)); /* save pointer to image header */ images->legacy_hdr_os = hdr;
------
but the original code still lets the mages->legacy_hdr_os to point to the header of uImage which may be overwritten in the decompress progress.
That is not what we want.
Thanks
2010/11/27 Mike Frysinger <[email protected]>:
Quoted 8 lines · On Friday, November 26, 2010 18:59:42 Baidu Boy wrote:
Quoted 2 lines
- ? ? ? ? ? ?
show_boot_progress(6);
+ ? ? ? ? ? ?show_boot_progress(6);this doesnt seem to actually be changing anything. ?you should avoid unrelated syntax changes with functional changes.
-mike
Signature · 3 lines
------ Best Regards Leo Liu
PATCH 1/1 bugfix: image header pointer change.
Quoted 1 line · On Friday, November 26, 2010 20:08:07 Baidu Boy wrote:
Hi,Mike:
please do not top post
Quoted 1 line
the purpose of below code is to copy the image header to the static
please read the exact text i quoted
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101126/411d7edb/attachment.pgp
PATCH 1/1 bugfix: image header pointer change.
I get your point. So I need to re-send a patch?
2010/11/27 Mike Frysinger <[email protected]>:
Quoted 10 lines · On Friday, November 26, 2010 20:08:07 Baidu Boy wrote:
Quoted 1 line
Hi,Mike:
please do not top post
Quoted 1 line
the purpose of below code is to copy the image header to the static
please read the exact text i quoted
-mike
Signature · 3 lines
------ Best Regards Leo Liu
PATCH 1/1 bugfix: image header pointer change.
Quoted 1 line · On Friday, November 26, 2010 22:03:26 Baidu Boy wrote:
I get your point. So I need to re-send a patch?
again, please stop top posting. it'd probably be good to send a new patch that didnt touch the boot progress line.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101126/34d5f2f2/attachment.pgp