econet: Move to staging; remove from defconfig

Recent review has revealed several bugs in econet and other obscure protocol implementations that can be exploited by local users for denial of service or privilege escalation.

The econet protocol (PF_ECONET) is unmaintained. There appear to be no published applications for it, and it has never progressed beyond 'experimental' status.

This protocol generally should not be enabled by distributions, since the cost of a security flaw affecting all installed systems presumably outweighs the benefit to the few (if any) legitimate users.

Signed-off-by Ben Hutchings <[email protected]>

---
As requested, I'm actually renaming the directory this time. I also noticed that ECONET was enabled in a couple of ARM defconfigs and explicitly disabled in various other defconfigs, so I've removed those lines as well.

This is based on linux-next; I hope it applies to staging.

Ben.

 arch/arm/configs/ixp4xx_defconfig           |    3 ---
 arch/arm/configs/pnx4008_defconfig          |    3 ---
 arch/mips/configs/gpr_defconfig             |    3 ---
 arch/mips/configs/mtx1_defconfig            |    3 ---
 arch/um/defconfig                           |    1 -
 arch/xtensa/configs/common_defconfig        |    1 -
 arch/xtensa/configs/iss_defconfig           |    1 -
 arch/xtensa/configs/s6105_defconfig         |    1 -

 drivers/staging/Kconfig                     |    2 ++
 drivers/staging/Makefile                    |    1 +
 {net => drivers/staging}/econet/Kconfig     |    0
 {net => drivers/staging}/econet/Makefile    |    0
 {net => drivers/staging}/econet/af_econet.c |    0
 net/Kconfig                                 |    1 -
 net/Makefile                                |    1 -
 15 files changed, 3 insertions(+), 18 deletions(-)
 rename {net => drivers/staging}/econet/Kconfig (100%)
 rename {net => drivers/staging}/econet/Makefile (100%)
 rename {net => drivers/staging}/econet/af_econet.c (100%)

arch/arm/configs/ixp4xx_defconfig +0 -0

index 5c50239..bd85c32 100644

arch/arm/configs/ixp4xx_defconfig +0 -0

 CONFIG_WAN_ROUTER=m
 CONFIG_NET_SCHED=y
 CONFIG_NET_SCH_CBQ=m

arch/arm/configs/pnx4008_defconfig +0 -0

index bd481f0..8301e4a 100644

And I need an ack from the networking maintainer to be able to accept this also.

From: Greg KH <[email protected]>
Date: Sat, 27 Nov 2010 16:21:35 -0800

Quoted 2 lines

And I need an ack from the networking maintainer to be able to accept this also.

I'm not applying this, nor do I want anyone else to.

If people think this protocol is not maintained adequately right now, wait until you push it into staging.

Furthermore, once Phil Blundell was made aware of security holes in econet he fixed them within a few days. Which is much better than I can say for some of the other protocols and filesystems in the tree.

Moving this into staging, is therefore not appropriate.

Quoted 16 lines · David Miller

From: Greg KH <[email protected]>
Date: Sat, 27 Nov 2010 16:21:35 -0800

Quoted 2 lines

And I need an ack from the networking maintainer to be able to accept this also.

I'm not applying this, nor do I want anyone else to.

If people think this protocol is not maintained adequately right now, wait until you push it into staging.

Furthermore, once Phil Blundell was made aware of security holes in econet he fixed them within a few days. Which is much better than I can say for some of the other protocols and filesystems in the tree.

Quoted 1 line

Moving this into staging, is therefore not appropriate.

Agreed.

Ben, why are you trying to remove these protocols that people use and maintain? This is the third one that has been shot down recently...

From: Greg KH <[email protected]>
Date: Sat, 27 Nov 2010 16:21:35 -0800

Quoted 2 lines

And I need an ack from the networking maintainer to be able to accept this also.

I'm not applying this, nor do I want anyone else to.

If people think this protocol is not maintained adequately right now, wait until you push it into staging.

Furthermore, once Phil Blundell was made aware of security holes in econet he fixed them within a few days. Which is much better than I can say for some of the other protocols and filesystems in the tree.

Moving this into staging, is therefore not appropriate.

Quoted 11 lines

From: Greg KH <[email protected]>
Date: Sat, 27 Nov 2010 16:21:35 -0800

Quoted 2 lines

And I need an ack from the networking maintainer to be able to accept this also.

I'm not applying this, nor do I want anyone else to.

If people think this protocol is not maintained adequately right now, wait until you push it into staging.

Quoted 4 lines

Furthermore, once Phil Blundell was made aware of security holes in econet he fixed them within a few days. Which is much better than I can say for some of the other protocols and filesystems in the tree.

Those bugs were present for years and would have been obvious to anyone who cared to read the code. While I very much appreciate Phil's quick response, I don't think this reactive maintenance is enough.

From: Ben Hutchings <[email protected]>
Date: Sun, 28 Nov 2010 01:53:35 +0000

Quoted 17 lines · David Miller

Quoted 15 lines

From: Greg KH <[email protected]>
Date: Sat, 27 Nov 2010 16:21:35 -0800

Quoted 2 lines

And I need an ack from the networking maintainer to be able to accept this also.

I'm not applying this, nor do I want anyone else to.

If people think this protocol is not maintained adequately right now, wait until you push it into staging.

Furthermore, once Phil Blundell was made aware of security holes in econet he fixed them within a few days. Which is much better than I can say for some of the other protocols and filesystems in the tree.

Quoted 3 lines

Those bugs were present for years and would have been obvious to anyone who cared to read the code. While I very much appreciate Phil's quick response, I don't think this reactive maintenance is enough.

These same arguments could for be made for RDS. Look at all the hellacious awful obvious crap we've discovered in that code recently. A simple read would have caught those too, and I don't see it's maintainer doing such things.

So, you're very much still not convincing Ben, but feel free to keep trying.