Skip to contentSkip to conversation

omap: zoom: wl1271 slot is MMC_CAP_POWER_OFF_CARD

PATCH New Ohad Ben-Cohen 3 participants 3 messages Nov 26, 2010 – Dec 6, 2010

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap: zoom: wl1271 slot is MMC_CAP_POWER_OFF_CARD

This patch complements ed919b0 "mmc: sdio: fix runtime PM anomalies by introducing MMC_CAP_POWER_OFF_CARD" by declaring MMC_CAP_POWER_OFF_CARD on the ZOOM's wl1271 mmc slot.

This is required in order not to break runtime PM support for the wl1271 sdio driver.

---
Quick summary:

After adding SDIO runtime PM support, we realized there are some board/host/card setups that are incapable of powering off the card after boot. For details, see:
http://thread.gmane.org/gmane.linux.kernel.mmc/4342/focus=4579

As a result, we added MMC_CAP_POWER_OFF_CARD which should be explicitly set by setups that _do_ support powering off the card.

This ensures we don't break existing functionality: SDIO core will enable runtime PM for cards only if that cap is set.
As a result, the card will be powered down after boot, and will only be powered up again when a driver is loaded (and then it's up to the driver whether power will be kept or not).

To complement that fix (which was just merged upstream), we need this patch too in 2.6.37, otherwise wl1271_sdio will break.

Pandora/Beagle wl12xx users: you need a similar patch as well, as this one only takes care of ZOOM (I don't have those other setups and preferred not to send a patch without testing).

 arch/arm/mach-omap2/board-zoom-peripherals.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-zoom-peripherals.c +1 -1
index 86c9b21..9db9203 100644
@@ -216,7 +216,7 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
 	{
 		.name		= "wl1271",
 		.mmc		= 3,
-		.caps		= MMC_CAP_4_BIT_DATA,
+		.caps		= MMC_CAP_4_BIT_DATA | MMC_CAP_POWER_OFF_CARD,
 		.gpio_wp	= -EINVAL,
 		.gpio_cd	= -EINVAL,
 		.nonremovable	= true,
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 omap: zoom: wl1271 slot is MMC_CAP_POWER_OFF_CARD

Hi,

Quoted 8 lines · Ohad Ben-Cohen

This patch complements ed919b0 "mmc: sdio: fix runtime PM anomalies by introducing MMC_CAP_POWER_OFF_CARD" by declaring MMC_CAP_POWER_OFF_CARD on the ZOOM's wl1271 mmc slot.

This is required in order not to break runtime PM support for the wl1271 sdio driver.

Looks good. Tony, feel free to take this for .37 through your tree.

Thanks,

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
maintainer
#2 lore raw

PATCH 1/1 omap: zoom: wl1271 slot is MMC_CAP_POWER_OFF_CARD

Quoted 7 lines · Chris Ball

Hi,

Quoted 4 lines · Ohad Ben-Cohen

This patch complements ed919b0 "mmc: sdio: fix runtime PM anomalies by introducing MMC_CAP_POWER_OFF_CARD" by declaring MMC_CAP_POWER_OFF_CARD on the ZOOM's wl1271 mmc slot.

Quoted 8 lines
Quoted 4 lines

This is required in order not to break runtime PM support for the wl1271 sdio driver.

Looks good. Tony, feel free to take this for .37 through your tree.

OK will merge thanks.

Tony