MVBLM7: make TSEC2 work again.
PATCH 1/1 MVBLM7: make TSEC2 work again.
SICRH has been misconfigured, i.e. TSEC2 clock + D[0:3] are GPIOs. Fix this to be RGMII signals again.
---
Kim,
sorry for late submission - this has been lingering around for a while. Hopefully you can still appply it since it's a real bugfix. Regards,
Andre
include/configs/MVBLM7.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/MVBLM7.h +1 -1
@@ -348,7 +348,7 @@#define CONFIG_SYS_SCCR_TSEC1CM 1#define CONFIG_SYS_SCCR_TSEC2CM 1 -#define CONFIG_SYS_SICRH 0x1fff8003 +#define CONFIG_SYS_SICRH 0x1fef0003#define CONFIG_SYS_SICRL (SICRL_LDP_A | SICRL_USB1 | SICRL_USB0)#define CONFIG_SYS_HID0_INIT 0x000000000
Signature · 1 line
1.7.0.4
Wolfgang Denk
AppliedPATCH 1/1 MVBLM7: make TSEC2 work again.
Dear Andre Schwarz,
Quoted 6 lines · In message <[email protected]>…
SICRH has been misconfigured, i.e. TSEC2 clock + D[0:3] are GPIOs. Fix this to be RGMII signals again.
Signed-off-by Andre Schwarz <[email protected]>---
Quoted 8 lines
Kim,
sorry for late submission - this has been lingering around for a while. Hopefully you can still appply it since it's a real bugfix. Regards,
Andreinclude/configs/MVBLM7.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
applied, thanks.
Kim, I pulled this directly as it affects clearly this single board only.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de War is never imperative. -- McCoy, "Balance of Terror", stardate 1709.2
PATCH 1/1 MVBLM7: make TSEC2 work again.
In reply to Andre Schwarzinclude/configs/MVBLM7.h line 351
Quoted 10 lines · On Fri, 22 Oct 2010 11:21:46 +0200 Andre Schwarz…
include/configs/MVBLM7.h +1
-1@@ -348,7 +348,7 @@#define CONFIG_SYS_SCCR_TSEC1CM 1#define CONFIG_SYS_SCCR_TSEC2CM 1 -#define CONFIG_SYS_SICRH 0x1fff8003 +#define CONFIG_SYS_SICRH 0x1fef0003
please use SICRH_* defines to compose this value, as is done for SICRL.
Thanks,
Kim
PATCH 1/1 MVBLM7: make TSEC2 work again.
Kim,
Quoted 8 lines
Quoted 8 lines
include/configs/MVBLM7.h +0
-0@@ -348,7 +348,7 @@#define CONFIG_SYS_SCCR_TSEC1CM 1#define CONFIG_SYS_SCCR_TSEC2CM 1
Quoted 5 lines
include/configs/MVBLM7.h line 353
Quoted 3 lines
include/configs/MVBLM7.h +1
-1-#define CONFIG_SYS_SICRH 0x1fff8003 +#define CONFIG_SYS_SICRH 0x1fef0003please use SICRH_* defines to compose this value, as is done for SICRL.
ok - will do.
Since I have more stuff pending I'll wait for the merge window to open before re-submitting.
Regards,
Andr?
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
PATCH 1/1 MVBLM7: make TSEC2 work again.
Dear Andre Schwarz,
Quoted 3 lines · In message <[email protected]> you wrote:
Since I have more stuff pending I'll wait for the merge window to open before re-submitting.
We have a "next" branch.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If something is different, it's either better or worse, and usually both. - Larry Wall
PATCH 1/1 MVBLM7: make TSEC2 work again.
Wolfgang,
Quoted 9 lines
Dear Andre Schwarz,
Quoted 3 lines · In message<[email protected]> you wrote:
Since I have more stuff pending I'll wait for the merge window to open before re-submitting.
We have a "next" branch.
understood - will rebase on current master and resubmit immediately after testing has passed.
I've also had no time to double-check Jocke's 83xx patches for my boards so far ... it's about time.
Cheers,
Andr?
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner