Skip to contentSkip to conversation

DHCPC daemon init network interface

PATCH New Chris Richards 3 participants 4 messages Nov 28, 2010 – Dec 15, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 DHCPC daemon init network interface

---
 policy/modules/system/sysnetwork.te |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
policy/modules/system/sysnetwork.te +2 -2
index dfbe736..640334d 100644
@@ -50,7 +50,7 @@ allow dhcpc_t self:fifo_file rw_fifo_file_perms;
 allow dhcpc_t self:tcp_socket create_stream_socket_perms;
 allow dhcpc_t self:udp_socket create_socket_perms;
 allow dhcpc_t self:packet_socket create_socket_perms;
-allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read };
+allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read nlmsg_write };
 
 allow dhcpc_t dhcp_etc_t:dir list_dir_perms;
 read_lnk_files_pattern(dhcpc_t, dhcp_etc_t, dhcp_etc_t)
@@ -81,7 +81,7 @@ domtrans_pattern(dhcpc_t, ifconfig_exec_t, ifconfig_t)
 
 kernel_read_system_state(dhcpc_t)
 kernel_read_network_state(dhcpc_t)
-kernel_search_network_sysctl(dhcpc_t)
+kernel_rw_net_sysctls(dhcpc_t)
 kernel_read_kernel_sysctls(dhcpc_t)
 kernel_request_load_module(dhcpc_t)
 kernel_use_fds(dhcpc_t)
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 2/2 DHCPC daemon init network interface

Quoted 10 lines · Chris Richards
---
 policy/modules/system/sysnetwork.te |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
policy/modules/system/sysnetwork.te +0 -0
index dfbe736..640334d 100644

policy/modules/system/sysnetwork.te allow dhcpc_t self:fifo_file rw_fifo_file_perms; · line 53

Quoted 5 lines
policy/modules/system/sysnetwork.te +1 -1
@@ -50,7 +50,7 @@ allow dhcpc_t self:fifo_file rw_fifo_file_perms;
 allow dhcpc_t self:tcp_socket create_stream_socket_perms;
 allow dhcpc_t self:udp_socket create_socket_perms;
 allow dhcpc_t self:packet_socket create_socket_perms;
-allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read };
+allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read nlmsg_write };

i am not sure but i suspect we may be able to use create_netlink_socket_perms here

Quoted 19 lines
policy/modules/system/sysnetwork.te +1 -1
 allow dhcpc_t dhcp_etc_t:dir list_dir_perms;
 read_lnk_files_pattern(dhcpc_t, dhcp_etc_t, dhcp_etc_t)
@@ -81,7 +81,7 @@ domtrans_pattern(dhcpc_t, ifconfig_exec_t, ifconfig_t)
 
 kernel_read_system_state(dhcpc_t)
 kernel_read_network_state(dhcpc_t)
-kernel_search_network_sysctl(dhcpc_t)
+kernel_rw_net_sysctls(dhcpc_t)
 kernel_read_kernel_sysctls(dhcpc_t)
 kernel_request_load_module(dhcpc_t)
 kernel_use_fds(dhcpc_t)
Signature · 6 lines
1.7.3.2

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy
#2 lore raw

PATCH 2/2 DHCPC daemon init network interface

Ah, you are correct. I just saw that I could simply add the nlmsg_write to what was already there and simply added it. I never even thought about looking to see if there was a macro already defined for that. D'oh!

We'll see if PeBenito wants me to resubmit with the change.

Later,
Chris

Quoted 41 lines · Dominick Grift
Quoted 10 lines · Chris Richards
---
  policy/modules/system/sysnetwork.te |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
policy/modules/system/sysnetwork.te +0 -0
index dfbe736..640334d 100644

policy/modules/system/sysnetwork.te allow dhcpc_t self:fifo_file rw_fifo_file_perms; · line 53

Quoted 5 lines
policy/modules/system/sysnetwork.te +1 -1
@@ -50,7 +50,7 @@ allow dhcpc_t self:fifo_file rw_fifo_file_perms;
  allow dhcpc_t self:tcp_socket create_stream_socket_perms;
  allow dhcpc_t self:udp_socket create_socket_perms;
  allow dhcpc_t self:packet_socket create_socket_perms;
-allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read };
+allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read nlmsg_write };

i am not sure but i suspect we may be able to use create_netlink_socket_perms here

Quoted 19 lines
policy/modules/system/sysnetwork.te +1 -1
  allow dhcpc_t dhcp_etc_t:dir list_dir_perms;
  read_lnk_files_pattern(dhcpc_t, dhcp_etc_t, dhcp_etc_t)
@@ -81,7 +81,7 @@ domtrans_pattern(dhcpc_t, ifconfig_exec_t, ifconfig_t)
 
  kernel_read_system_state(dhcpc_t)
  kernel_read_network_state(dhcpc_t)
-kernel_search_network_sysctl(dhcpc_t)
+kernel_rw_net_sysctls(dhcpc_t)
  kernel_read_kernel_sysctls(dhcpc_t)
  kernel_request_load_module(dhcpc_t)
  kernel_use_fds(dhcpc_t)
Signature · 6 lines
1.7.3.2

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

#3 lore raw

PATCH 2/2 DHCPC daemon init network interface

Quoted 5 lines · Chris Richards

Ah, you are correct. I just saw that I could simply add the nlmsg_write to what was already there and simply added it. I never even thought about looking to see if there was a macro already defined for that. D'oh!

We'll see if PeBenito wants me to resubmit with the change.

Might as well resubmit as I have comments on other patches.

Quoted 47 lines · Dominick Grift
Quoted 32 lines · Chris Richards
Quoted 10 lines
---
  policy/modules/system/sysnetwork.te |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
policy/modules/system/sysnetwork.te +0 -0
index dfbe736..640334d 100644

policy/modules/system/sysnetwork.te allow dhcpc_t self:fifo_file rw_fifo_file_perms; · line 53

Quoted 5 lines
policy/modules/system/sysnetwork.te +1 -1
@@ -50,7 +50,7 @@ allow dhcpc_t self:fifo_file rw_fifo_file_perms;
  allow dhcpc_t self:tcp_socket create_stream_socket_perms;
  allow dhcpc_t self:udp_socket create_socket_perms;
  allow dhcpc_t self:packet_socket create_socket_perms;
-allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read };
+allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read nlmsg_write };

i am not sure but i suspect we may be able to use create_netlink_socket_perms here

Quoted 15 lines
policy/modules/system/sysnetwork.te +1 -1
  allow dhcpc_t dhcp_etc_t:dir list_dir_perms;
  read_lnk_files_pattern(dhcpc_t, dhcp_etc_t, dhcp_etc_t)
@@ -81,7 +81,7 @@ domtrans_pattern(dhcpc_t, ifconfig_exec_t, ifconfig_t)
 
  kernel_read_system_state(dhcpc_t)
  kernel_read_network_state(dhcpc_t)
-kernel_search_network_sysctl(dhcpc_t)
+kernel_rw_net_sysctls(dhcpc_t)
  kernel_read_kernel_sysctls(dhcpc_t)
  kernel_request_load_module(dhcpc_t)
  kernel_use_fds(dhcpc_t)
Signature · 1 line
1.7.3.2
Quoted 9 lines
Quoted 4 lines

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com