Skip to contentSkip to conversation

mpc83xx: Make it boot again

PATCH Superseded Joakim Tjernlund 3 participants 8 messages Nov 19, 2010 – Nov 28, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

---

v2: Final adjustmenst based on inpt from Scott Wood.

 arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/powerpc/cpu/mpc83xx/start.S +8 -0
index e8b1ebc..5a9b790 100644
@@ -1191,6 +1191,10 @@ map_flash_by_law1:
 	bne 1b
 
 	stw r4, LBLAWAR1(r3) /* LBLAWAR1 <= 8MB Flash Size */
+	/* Wait for HW to catch up */
+	lwz r4, LBLAWAR1(r3)
+	twi 0,r4,0
+	isync
 	blr
 
 	/* Though all the LBIU Local Access Windows and LBC Banks will be
@@ -1229,5 +1233,9 @@ remap_flash_by_law0:
 	xor r4, r4, r4
 	stw r4, LBLAWBAR1(r3)
 	stw r4, LBLAWAR1(r3) /* Off LBIU LAW1 */
+	/* Wait for HW to catch up */
+	lwz r4, LBLAWAR1(r3)
+	twi 0,r4,0
+	isync
 	blr
 #endif /* CONFIG_SYS_FLASHBOOT */
Signature · 1 line
1.7.2.2
#1 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

Joakim Tjernlund <[email protected]> wrote on 2010/11/19 14:15:33:

Quoted 8 lines

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

Quoted 4 lines

---

v2: Final adjustmenst based on inpt from Scott Wood.

Guys, I can still crash my board when a add new code in start.S It is remap_flash_by_law0 that is giving me a hard time. I noticed that I could bring it down by adding a few nops after a CS0 is written but before LAW0. I also noticed that it always crash at a new cacheline.

By swapping LAW0 with CS0 it became much better(crash yet). I wonder if it is correct to configure CS0 then LAW0? It seems like one must first adjust LAW0 then CS0 to be sure it works as intended.
What do you think?

Jocke

Quoted 31 lines
 arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/powerpc/cpu/mpc83xx/start.S +8 -1
index e8b1ebc..5a9b790 100644
@@ -1191,6 +1191,10 @@ map_flash_by_law1:
    bne 1b
 
    stw r4, LBLAWAR1(r3) /* LBLAWAR1 <= 8MB Flash Size */
+   /* Wait for HW to catch up */
+   lwz r4, LBLAWAR1(r3)
+   twi 0,r4,0
+   isync
    blr
 
    /* Though all the LBIU Local Access Windows and LBC Banks will be
@@ -1229,5 +1233,9 @@ remap_flash_by_law0:
    xor r4, r4, r4
    stw r4, LBLAWBAR1(r3)
    stw r4, LBLAWAR1(r3) /* Off LBIU LAW1 */
+   /* Wait for HW to catch up */
+   lwz r4, LBLAWAR1(r3)
+   twi 0,r4,0
+   isync
    blr
 #endif /* CONFIG_SYS_FLASHBOOT */
--

1.7.2.2

#2 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

Quoted 21 lines

Joakim Tjernlund <[email protected]> wrote on 2010/11/19 14:15:33:

Quoted 8 lines

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

Quoted 4 lines

---

v2: Final adjustmenst based on inpt from Scott Wood.

Guys, I can still crash my board when a add new code in start.S It is remap_flash_by_law0 that is giving me a hard time. I noticed that I could bring it down by adding a few nops after a CS0 is written but before LAW0. I also noticed that it always crash at a new cacheline.

Quoted 5 lines

By swapping LAW0 with CS0 it became much better(crash yet). I wonder if it is correct to configure CS0 then LAW0? It seems like one must first adjust LAW0 then CS0 to be sure it works as intended.
What do you think?

OOPS, trashing r3 before calling remap_flash_by_law0 is BAD. remap_flash_by_law0 should reload r3 with IMMR instead of relying on r3 pointing to IMMR.

#3 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

In reply to Joakim Tjernlund

Could we have an ACK before relese please?

Quoted 46 lines

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

---

v2: Final adjustmenst based on inpt from Scott Wood.

 arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/powerpc/cpu/mpc83xx/start.S +8 -1
index e8b1ebc..5a9b790 100644
@@ -1191,6 +1191,10 @@ map_flash_by_law1:
    bne 1b
 
    stw r4, LBLAWAR1(r3) /* LBLAWAR1 <= 8MB Flash Size */
+   /* Wait for HW to catch up */
+   lwz r4, LBLAWAR1(r3)
+   twi 0,r4,0
+   isync
    blr
 
    /* Though all the LBIU Local Access Windows and LBC Banks will be
@@ -1229,5 +1233,9 @@ remap_flash_by_law0:
    xor r4, r4, r4
    stw r4, LBLAWBAR1(r3)
    stw r4, LBLAWAR1(r3) /* Off LBIU LAW1 */
+   /* Wait for HW to catch up */
+   lwz r4, LBLAWAR1(r3)
+   twi 0,r4,0
+   isync
    blr
 #endif /* CONFIG_SYS_FLASHBOOT */
--

1.7.2.2

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#4 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

Quoted 15 lines · On Tue, 23 Nov 2010 19:16:01 +0100 Joakim Tjernlund…

Could we have an ACK before relese please?

Quoted 13 lines

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

---

v2: Final adjustmenst based on inpt from Scott Wood.

 arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

ACK

-Scott

Applied
#5 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

Quoted 15 lines · On Tue, 23 Nov 2010 12:38:57 -0600 Scott Wood <[email protected]> wrote:
Quoted 12 lines · On Tue, 23 Nov 2010 19:16:01 +0100 Joakim Tjernlund…

Could we have an ACK before relese please?

Quoted 10 lines

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

---

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

v2: Final adjustmenst based on inpt from Scott Wood.

 arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

ACK

-Scott

applied.

Thanks everyone.

Kim

#6 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

Kim Phillips <[email protected]> wrote on 2010/11/28 17:31:25:

Quoted 23 lines
Quoted 19 lines · On Tue, 23 Nov 2010 12:38:57 -0600 Scott Wood <[email protected]> wrote:
Quoted 15 lines · On Tue, 23 Nov 2010 19:16:01 +0100 Joakim Tjernlund…

Could we have an ACK before relese please?

Quoted 13 lines

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

---

v2: Final adjustmenst based on inpt from Scott Wood.

 arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
Quoted 7 lines
Quoted 3 lines

ACK

-Scott

applied.

Thanks everyone.

Finally, thanks.

#7 lore raw

PATCH v2 1/1 mpc83xx: Make it boot again

In reply to Kim Phillips

Kim Phillips <[email protected]> wrote on 2010/11/28 17:31:25:

Quoted 23 lines
Quoted 19 lines · On Tue, 23 Nov 2010 12:38:57 -0600 Scott Wood <[email protected]> wrote:
Quoted 15 lines · On Tue, 23 Nov 2010 19:16:01 +0100 Joakim Tjernlund…

Could we have an ACK before relese please?

Quoted 13 lines

After the removal of COLD/WARM start flags my mpc8321 board didn't boot anymore.
Trial and error suggests that map/remap_flash_by_xxx needs to wait after updating LBLAWAR1 to make sure the the change has reached the HW before continuing with the code that depends on it. Final fix suggested by Scott Wood.

---

v2: Final adjustmenst based on inpt from Scott Wood.

 arch/powerpc/cpu/mpc83xx/start.S |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
Quoted 5 lines
Quoted 3 lines

ACK

-Scott

applied.

BTW, there was one named
powerpc: fix mpc8315erdb and mpc8313erdb NAND linker script
which I think you should consider. I don't really care as I don't use these boards, I just noticed it by chance.

Jocke