Skip to contentSkip to conversation

target-finalize: libtread_db: support nonstd toolchain setups

PATCH New Peter Korsgaard 2 participants 4 messages Nov 28, 2010 – Nov 29, 2010 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target-finalize: libtread_db: support nonstd toolchain setups

commit: http://git.buildroot.net/buildroot/commit/?id=66254843a57420cf46899b71526fe2481ca7a554
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Certain toolchain configs (E.G. on blackfin), don't use symlinks, so the file name to match is the actual SONAME (.so.*). Support these toolchains as well.

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index fc165e1..8dbb026 100644
@@ -418,7 +418,7 @@ ifneq ($(BR2_HAVE_DOCUMENTATION),y)
 	rm -rf $(TARGET_DIR)/usr/share/gtk-doc
 	-rmdir $(TARGET_DIR)/usr/share 2>/dev/null
 endif
-	find $(TARGET_DIR) -type f -perm +111 '!' -name 'libthread_db*.so' | \
+	find $(TARGET_DIR) -type f -perm +111 '!' -name 'libthread_db*.so*' | \
 		xargs $(STRIPCMD) 2>/dev/null || true
 	find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \
 		xargs -r $(STRIPCMD) $(STRIP_STRIP_UNNEEDED)
Signature · 1 line
1.7.2.2
#1 lore raw

PATCH 1/1 target-finalize: libtread_db: support nonstd toolchain setups

Quoted 3 lines · On Sunday, November 28, 2010 16:13:05 Peter Korsgaard wrote:

Certain toolchain configs (E.G. on blackfin), don't use symlinks, so the file name to match is the actual SONAME (.so.*). Support these toolchains as well.

this is incorrect. it really has nothing to do with the toolchain, nor is it non standard. but i guess too late to fix this now.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101128/21cc297e/attachment.pgp>

#2 lore raw

PATCH 1/1 target-finalize: libtread_db: support nonstd toolchain setups

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Frysinger <[email protected]> writes:

Hi,

Mike> this is incorrect. it really has nothing to do with the Mike> toolchain, nor is it non standard. but i guess too late to fix Mike> this now. -mike

Well, toolchain in the wider sense - uClibc setup. And it is nonstandard in the sense that it isn't what buildroot makes / what uClibc 'make install_runtime' creates.

And yes, we don't rebase the buildroot repo, so it's too late to change.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 target-finalize: libtread_db: support nonstd toolchain setups

Quoted 8 lines · On Monday, November 29, 2010 02:51:21 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Frysinger <[email protected]> writes:

Mike> this is incorrect. it really has nothing to do with the Mike> toolchain, nor is it non standard. but i guess too late to fix Mike> this now. -mike

Well, toolchain in the wider sense - uClibc setup. And it is nonstandard in the sense that it isn't what buildroot makes / what uClibc 'make install_runtime' creates.

and that still is incorrect. the blackfin toolchain uses symlinks like
normal. i have a patch for br that scrubs the libraries as they're installed into the target.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101129/d999bbdf/attachment.pgp>