(no subject)
Dear Kyungmin Park & Minkyu Kang,
"onenand_ipl/board/apollon/config.mk" and "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE; do you think it is possible to move these definitions into the respective board config files and remove the then empty "config.mk" files?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If the hours are long enough and the pay is short enough, someone will say it's women's work.
Dear Wolfgang,
Quoted 8 lines · Wolfgang Denk
Dear Kyungmin Park & Minkyu Kang,
"
onenand_ipl/board/apollon/config.mk" and "onenand_ipl/board/vpac270/config.mk" defineCONFIG_SYS_TEXT_BASE; do you think it is possible to move these definitions into the respective board config files and remove the then empty "config.mk" files?
It is hard to move into board config file, because of usually use different TEXT_BASE on IPL.
I think, it can be moved into Makefile directly.
Then we can remove config.mk.
How you think?
Thanks
Minkyu Kang
Signature · 2 lines
from. prom. www.promsoft.net
[U-Boot] onenand_ipl config.mk cleanup (was: no subject)
Dear Minkyu Kang,
Quoted 10 lines · In message <[email protected]> you…
Quoted 7 lines
"
onenand_ipl/board/apollon/config.mk" and "onenand_ipl/board/vpac270/config.mk" defineCONFIG_SYS_TEXT_BASE; do you think it is possible to move these definitions into the respective board config files and remove the then empty "config.mk" files?It is hard to move into board config file, because of usually use different
TEXT_BASEon IPL.
Well, we can probably use #ifdef's, like we do for boards that boot from NAND flash, which have essentially the same situation.
Quoted 1 line
I think, it can be moved into
Makefiledirectly.
No, that's not a good idea. Makefiles should not contain configuration data. I want to move as much of this as possible into the board config files, so we have it all in a single place.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A failure will not appear until a unit has passed final inspection.