Disable automatic MISSING_PV recovery when handles_missing_pvs is set (BZ 653643)
PATCH 1/1 Disable automatic MISSING_PV recovery when handles_missing_pvs is set (BZ 653643)
Hi,
it seems I did everything but actually posted the proposed patch for BZ 653643. The explanation of what goes wrong where and how the patch fixes that is in BZ comments.
Yours,
Petr.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20101125/50268c44/attachment.ksh>
PATCH 1/1 Disable automatic MISSING_PV recovery when handles_missing_pvs is set (BZ 653643)
Quoted 3 lines · Peter Rockai
it seems I did everything but actually posted the proposed patch for BZ 653643. The explanation of what goes wrong where and how the patch fixes that is in BZ comments.
So what does the new output in the test case in that bz look like?
Do we still get the last WARNING message? (Where does it come from?
Maybe it's too hard to fix that without removing it from other code paths where we do still want it?)
Ack.
Alasdair
PATCH 1/1 Disable automatic MISSING_PV recovery when handles_missing_pvs is set (BZ 653643)
Hi,
Quoted 10 lines · Alasdair G Kergon
Quoted 3 lines · Peter Rockai
it seems I did everything but actually posted the proposed patch for BZ 653643. The explanation of what goes wrong where and how the patch fixes that is in BZ comments.
So what does the new output in the test case in that bz look like?
Do we still get the last WARNING message? (Where does it come from?
Maybe it's too hard to fix that without removing it from other code paths where we do still want it?)
Which WARNING message you mean? There is only one in each command:
inconsistent metadata, we can't get rid of that one. About the PV not found, I think it's better with the message than without. On the other hand, we *could* make vgextend --restoremissing behave just like normal vgextend if the PV is actually not part of the VG. But I think it's better for scriptability (and predictability) to not do that.
Yours,
Petr
PATCH 1/1 Disable automatic MISSING_PV recovery when handles_missing_pvs is set (BZ 653643)
Quoted 1 line · Peter Rockai
Which WARNING message you mean? There is only one in each command:
There are two quoted:
WARNING: Inconsistent metadata found for VG helter_skelter - updating to use
version 493
WARNING: PV /dev/sdf1 not found in VG helter_skelter
Alasdair