Skip to contentSkip to conversation

Fix ppc asm typo

PATCH In review Paul E. McKenney 2 participants 5 messages Nov 29, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix ppc asm typo

Fix ppc asm typo.

urcu/uatomic_arch_ppc.h +1 -1
index 426b0f2..bb74934 100644
@@ -133,7 +133,7 @@ unsigned long _uatomic_cmpxchg(void *addr, unsigned long old,
 			"bne- 1b\n"	 	/* retry if lost reservation */
 			"isync\n"
 		"2:\n"
-				: "=&r"(old_val),
+				: "=&r"(old_val)
 				: "r"(addr), "r"((unsigned long)_new),
 				  "r"((unsigned long)old)
 				: "memory", "cc");
#1 lore raw

Hi Paul,

This patch has already been merged by me in the userspace RCU library:

commit e72f49371b233637eaf143265a73c7322d0710fd

Author: Paul E. McKenney <[email protected]>
Date:   Wed Sep 23 03:09:59 2009 -0400

ppc atomic: Fix asm format.

It's therefore already integrated in the current releases.

Thanks,

Mathieu

Quoted 17 lines · * Paul E. McKenney ([email protected]) wrote:

Fix ppc asm typo.

urcu/uatomic_arch_ppc.h +1 -1
index 426b0f2..bb74934 100644
@@ -133,7 +133,7 @@ unsigned long _uatomic_cmpxchg(void *addr, unsigned long old,
 			"bne- 1b\n"	 	/* retry if lost reservation */
 			"isync\n"
 		"2:\n"
-				: "=&r"(old_val),
+				: "=&r"(old_val)
 				: "r"(addr), "r"((unsigned long)_new),
 				  "r"((unsigned long)old)
 				: "memory", "cc");
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
#2 lore raw
Quoted 8 lines · Mathieu Desnoyers

Hi Paul,

This patch has already been merged by me in the userspace RCU library:

commit e72f49371b233637eaf143265a73c7322d0710fd

Author: Paul E. McKenney <[email protected]>
Date:   Wed Sep 23 03:09:59 2009 -0400
Quoted 6 lines

ppc atomic: Fix asm format.

It's therefore already integrated in the current releases.

Hmmm... I wonder why v0.5.2 got me a compiler error, then...

Thanx, Paul

Quoted 29 lines

Thanks,

Mathieu

Quoted 17 lines · * Paul E. McKenney ([email protected]) wrote:

Fix ppc asm typo.

urcu/uatomic_arch_ppc.h +1 -1
index 426b0f2..bb74934 100644
@@ -133,7 +133,7 @@ unsigned long _uatomic_cmpxchg(void *addr, unsigned long old,
 			"bne- 1b\n"	 	/* retry if lost reservation */
 			"isync\n"
 		"2:\n"
-				: "=&r"(old_val),
+				: "=&r"(old_val)
 				: "r"(addr), "r"((unsigned long)_new),
 				  "r"((unsigned long)old)
 				: "memory", "cc");
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
#3 lore raw
Quoted 9 lines · * Paul E. McKenney ([email protected]) wrote:
Quoted 8 lines · Mathieu Desnoyers

Hi Paul,

This patch has already been merged by me in the userspace RCU library:

commit e72f49371b233637eaf143265a73c7322d0710fd

Author: Paul E. McKenney <[email protected]>
Date:   Wed Sep 23 03:09:59 2009 -0400
Quoted 8 lines
Quoted 6 lines

ppc atomic: Fix asm format.

It's therefore already integrated in the current releases.

Hmmm... I wonder why v0.5.2 got me a compiler error, then...

Maybe you did a make install that got the headers installed system-wide, and the search order is wrong ? (just a thought)

Did you build 0.5.2 from the tarballs or from the git repo ?

Thanks,

Mathieu

Quoted 32 lines

Thanx, Paul

Quoted 29 lines

Thanks,

Mathieu

Quoted 17 lines · * Paul E. McKenney ([email protected]) wrote:

Fix ppc asm typo.

urcu/uatomic_arch_ppc.h +1 -1
index 426b0f2..bb74934 100644
@@ -133,7 +133,7 @@ unsigned long _uatomic_cmpxchg(void *addr, unsigned long old,
 			"bne- 1b\n"	 	/* retry if lost reservation */
 			"isync\n"
 		"2:\n"
-				: "=&r"(old_val),
+				: "=&r"(old_val)
 				: "r"(addr), "r"((unsigned long)_new),
 				  "r"((unsigned long)old)
 				: "memory", "cc");
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
#4 lore raw
Quoted 15 lines · Mathieu Desnoyers
Quoted 14 lines · * Paul E. McKenney ([email protected]) wrote:
Quoted 13 lines · Mathieu Desnoyers

Hi Paul,

This patch has already been merged by me in the userspace RCU library:

commit e72f49371b233637eaf143265a73c7322d0710fd

Author: Paul E. McKenney <[email protected]>
Date:   Wed Sep 23 03:09:59 2009 -0400

ppc atomic: Fix asm format.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

It's therefore already integrated in the current releases.

Hmmm... I wonder why v0.5.2 got me a compiler error, then...

Maybe you did a make install that got the headers installed system-wide, and the search order is wrong ? (just a thought)

Did you build 0.5.2 from the tarballs or from the git repo ?

Good point... From a tarball that I extracted from the git repo.

I will give it another try.

Thanx, Paul

Quoted 42 lines

Thanks,

Mathieu

Quoted 32 lines

Thanx, Paul

Quoted 29 lines

Thanks,

Mathieu

Quoted 17 lines · * Paul E. McKenney ([email protected]) wrote:

Fix ppc asm typo.

urcu/uatomic_arch_ppc.h +1 -1
index 426b0f2..bb74934 100644
@@ -133,7 +133,7 @@ unsigned long _uatomic_cmpxchg(void *addr, unsigned long old,
 			"bne- 1b\n"	 	/* retry if lost reservation */
 			"isync\n"
 		"2:\n"
-				: "=&r"(old_val),
+				: "=&r"(old_val)
 				: "r"(addr), "r"((unsigned long)_new),
 				  "r"((unsigned long)old)
 				: "memory", "cc");
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com