tty: add 'active' sysfs attribute to tty0 and console device
Subsystems (10)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Just have dug out this one:
Quoted 10 lines · Werner Fink
Quoted 6 lines · Alan Cox
Quoted 3 lines
Currently the bootlogd(8) or blogd(8) parse the kernels command line and if available do an ioctl TIOCGDEV (not supported by the upstream kernel), then create a pty/tty pair, do an ioctl TIOCCONS to forward
So perhaps the vendors using TIOCGDEV could get off their collective backsides and submit it upstream ?
That I've tried 10 years before. If you think it's worth to retry you may have a look on the attachment only for a short review
Werner
Signature · 1 line
System V style init programs - http://savannah.nongnu.org/projects/sysvinit/
Quoted 1 line
From
3ed084a05b7d28d65f6cc42c96696c7cb49c84a1Mon Sep 17 00:00:00 2001
In-Reply-To: <[email protected]>
References: <[email protected]>
From: Werner Fink <[email protected]>
Date: Fri, 19 Nov 2010 17:54:44 +0100
Subject: [PATCH] Add tty ioctl to figure device node of the system console.
arch/alpha/include/asm/ioctls.h +1 -0
@@ -92,6 +92,7 @@#define TIOCGSID 0x5429/* Return the session ID of FD */ #define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG 0x5453
arch/mips/include/asm/ioctls.h +1 -0
@@ -83,6 +83,7 @@#define TCSETSF2 _IOW('T', 0x2D, struct termios2)#define TIOCGPTN _IOR('T', 0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T', 0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T', 0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T', 0x36, int)/* Generate signal on Pty slave */ /* I hope the range from 0x5480 on is free ... */
arch/parisc/include/asm/ioctls.h +1 -0
@@ -52,6 +52,7 @@#define TCSETSF2 _IOW('T',0x2D, struct termios2)#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOW('T',0x32, int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define FIONCLEX 0x5450/* these numbers need to be adjusted. */
arch/powerpc/include/asm/ioctls.h +1 -0
@@ -94,6 +94,7 @@#define TIOCSRS485 0x542f#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG 0x5453
arch/sh/include/asm/ioctls.h +1 -0
@@ -85,6 +85,7 @@#define TCSETSF2 _IOW('T', 45, struct termios2)#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG _IO('T', 83)/* 0x5453 */
arch/sparc/include/asm/ioctls.h +1 -0
@@ -19,6 +19,7 @@#define TCSETS2 _IOW('T', 13, struct termios2)#define TCSETSW2 _IOW('T', 14, struct termios2)#define TCSETSF2 _IOW('T', 15, struct termios2) +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ /* Note that all the ioctls that are not available in Linux have a * double underscore on the front to: a) avoid some programs to
arch/xtensa/include/asm/ioctls.h +1 -0
@@ -98,6 +98,7 @@#define TCSETSF2 _IOW('T', 45, struct termios2)#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG _IO('T', 83)
drivers/tty/tty_io.c +6 -0
@@ -2618,6 +2618,12 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)return put_user (tty->ldisc->ops->num, (int __user *)p);case TIOCSETD :return tiocsetd (tty, p); +case TIOCGDEV : + { +unsigned int ret =new_encode_dev (tty_devnum (real_tty)); +return put_user (ret, (unsigned int __user *)p); + } +/* * Break handling */
fs/compat_ioctl.c +1 -0
@@ -837,6 +837,7 @@ COMPATIBLE_IOCTL(TCSETSW) COMPATIBLE_IOCTL(TCSETSF) COMPATIBLE_IOCTL(TIOCLINUX) COMPATIBLE_IOCTL(TIOCSBRK) +COMPATIBLE_IOCTL(TIOCGDEV) COMPATIBLE_IOCTL(TIOCCBRK) COMPATIBLE_IOCTL(TIOCGSID) COMPATIBLE_IOCTL(TIOCGICOUNT)
include/asm-generic/ioctls.h +1 -0
@@ -67,6 +67,7 @@#endif #define TIOCGPTN _IOR('T', 0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T', 0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T', 0x32, unsigned int)/* Get primary device node of /dev/console */ #define TCGETX 0x5432/* SYS5 TCGETX compatibility */ #define TCSETX 0x5433#define TCSETXF 0x5434
Signature · 1 line
1.6.0.2
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 48 lines · Milton Miller
Quoted 2 lines · Werner Fink
Just have dug out this one:
One question and two minor nits.
Quoted 17 lines · Werner Fink
Quoted 10 lines · Alan Cox
Quoted 6 lines
Quoted 3 lines
Currently the bootlogd(8) or blogd(8) parse the kernels command line and if available do an ioctl TIOCGDEV (not supported by the upstream kernel), then create a pty/tty pair, do an ioctl TIOCCONS to forward
So perhaps the vendors using TIOCGDEV could get off their collective backsides and submit it upstream ?
That I've tried 10 years before. If you think it's worth to retry you may have a look on the attachment only for a short review
Werner
Quoted 7 lines
Quoted 1 line
From
3ed084a05b7d28d65f6cc42c96696c7cb49c84a1Mon Sep 17 00:00:00 2001In-Reply-To: <[email protected]>
References: <[email protected]>
From: Werner Fink <[email protected]>
Date: Fri, 19 Nov 2010 17:54:44 +0100
Subject: [PATCH] Add tty ioctl to figure device node of the system console.Please put a changelog here as per "15) The canonical patch format" in
Documentation/SubmittingPatches.Quoted 14 lines
Signed-off-by Werner Fink <[email protected]>arch/alpha/include/asm/ioctls.h +1
-0@@ -92,6 +92,7 @@#define TIOCGSID 0x5429/* Return the session ID of FD */ #define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */
Quoted 13 lines
arch/parisc/include/asm/ioctls.h line 55
Quoted 10 lines
arch/alpha/include/asm/ioctls.h +0
-0#define TIOCSERCONFIG 0x5453arch/parisc/include/asm/ioctls.h +1
-0@@ -52,6 +52,7 @@#define TCSETSF2 _IOW('T',0x2D, struct termios2)#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOW('T',0x32, int)/* Get primary device node of /dev/console */ All of the other architetures add this as
_IORbut here in parisc it is_IOW. Was this intentional or a typo?
Thansk for spotting.
Werner
Signature · 1 line
System V style init programs - http://savannah.nongnu.org/projects/sysvinit/
Quoted 1 line
From
ad0f6018a57ce3b706d2eec41a8b0892f0e03624Mon Sep 17 00:00:00 2001
From: Werner Fink <[email protected]>
Date: Fri, 19 Nov 2010 17:54:44 +0100
Subject: [PATCH] Add tty ioctl to figure device node of the system console.
--- arch/alpha/include/asm/ioctls.h | 1 + arch/mips/include/asm/ioctls.h | 1 + arch/parisc/include/asm/ioctls.h | 1 + arch/powerpc/include/asm/ioctls.h | 1 + arch/sh/include/asm/ioctls.h | 1 + arch/sparc/include/asm/ioctls.h | 1 + arch/xtensa/include/asm/ioctls.h | 1 + drivers/tty/tty_io.c | 5 +++++ fs/compat_ioctl.c | 1 + include/asm-generic/ioctls.h | 1 + 10 files changed, 14 insertions(+), 0 deletions(-)
arch/alpha/include/asm/ioctls.h +1 -0
@@ -92,6 +92,7 @@#define TIOCGSID 0x5429/* Return the session ID of FD */ #define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG 0x5453
arch/mips/include/asm/ioctls.h +1 -0
@@ -83,6 +83,7 @@#define TCSETSF2 _IOW('T', 0x2D, struct termios2)#define TIOCGPTN _IOR('T', 0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T', 0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T', 0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T', 0x36, int)/* Generate signal on Pty slave */ /* I hope the range from 0x5480 on is free ... */
arch/parisc/include/asm/ioctls.h +1 -0
@@ -52,6 +52,7 @@#define TCSETSF2 _IOW('T',0x2D, struct termios2)#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define FIONCLEX 0x5450/* these numbers need to be adjusted. */
arch/powerpc/include/asm/ioctls.h +1 -0
@@ -94,6 +94,7 @@#define TIOCSRS485 0x542f#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG 0x5453
arch/sh/include/asm/ioctls.h +1 -0
@@ -85,6 +85,7 @@#define TCSETSF2 _IOW('T', 45, struct termios2)#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG _IO('T', 83)/* 0x5453 */
arch/sparc/include/asm/ioctls.h +1 -0
@@ -19,6 +19,7 @@#define TCSETS2 _IOW('T', 13, struct termios2)#define TCSETSW2 _IOW('T', 14, struct termios2)#define TCSETSF2 _IOW('T', 15, struct termios2) +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ /* Note that all the ioctls that are not available in Linux have a * double underscore on the front to: a) avoid some programs to
arch/xtensa/include/asm/ioctls.h +1 -0
@@ -98,6 +98,7 @@#define TCSETSF2 _IOW('T', 45, struct termios2)#define TIOCGPTN _IOR('T',0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T',0x32, unsigned int)/* Get primary device node of /dev/console */ #define TIOCSIG _IOW('T',0x36, int)/* Generate signal on Pty slave */ #define TIOCSERCONFIG _IO('T', 83)
drivers/tty/tty_io.c +5 -0
@@ -2618,6 +2618,11 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)return put_user (tty->ldisc->ops->num, (int __user *)p);case TIOCSETD :return tiocsetd (tty, p); +case TIOCGDEV : + { +unsigned int ret =new_encode_dev (tty_devnum (real_tty)); +return put_user (ret, (unsigned int __user *)p); + }/* * Break handling */
fs/compat_ioctl.c +1 -0
@@ -837,6 +837,7 @@ COMPATIBLE_IOCTL(TCSETSW) COMPATIBLE_IOCTL(TCSETSF) COMPATIBLE_IOCTL(TIOCLINUX) COMPATIBLE_IOCTL(TIOCSBRK) +COMPATIBLE_IOCTL(TIOCGDEV) COMPATIBLE_IOCTL(TIOCCBRK) COMPATIBLE_IOCTL(TIOCGSID) COMPATIBLE_IOCTL(TIOCGICOUNT)
include/asm-generic/ioctls.h +1 -0
@@ -67,6 +67,7 @@#endif #define TIOCGPTN _IOR('T', 0x30, unsigned int)/* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T', 0x31, int)/* Lock/unlock Pty */ +#define TIOCGDEV _IOR('T', 0x32, unsigned int)/* Get primary device node of /dev/console */ #define TCGETX 0x5432/* SYS5 TCGETX compatibility */ #define TCSETX 0x5433#define TCSETXF 0x5434
Signature · 1 line
1.6.0.2