Skip to contentSkip to conversation

Kconfig: add new symbol MIGHT_HAVE_PCI

PATCH In review Hans Ulli Kroll 5 participants 6 messages Dec 1, 2010

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kconfig: add new symbol MIGHT_HAVE_PCI

Today more boards with arm cpu have selectable pci bus. This patch makes this more scalable and remove line continuations in Kconfig

---
 arch/arm/Kconfig                 |    7 ++++++-
 arch/arm/mach-cns3xxx/Kconfig    |    1 +
 arch/arm/mach-integrator/Kconfig |    1 +
 arch/arm/mach-ks8695/Kconfig     |    1 +
 arch/arm/mach-pxa/Kconfig        |    1 +
 arch/arm/mach-versatile/Kconfig  |    1 +
 6 files changed, 11 insertions(+), 1 deletions(-)
arch/arm/Kconfig +6 -1
index a19a526..614cf2f 100644
@@ -34,6 +34,9 @@ config ARM
 config HAVE_PWM
 	bool
 
+config MIGHT_HAVE_PCI
+	bool
+
 config SYS_SUPPORTS_APM_EMULATION
 	bool
 
@@ -298,6 +301,7 @@ config ARCH_CNS3XXX
 	select CPU_V6
 	select GENERIC_CLOCKEVENTS
 	select ARM_GIC
+	select MIGHT_HAVE_PCI
 	select PCI_DOMAINS if PCI
 	help
 	  Support for Cavium Networks CNS3XXX platform.
@@ -433,6 +437,7 @@ config ARCH_IXP4XX
 	select CPU_XSCALE
 	select GENERIC_GPIO
 	select GENERIC_CLOCKEVENTS
+	select MIGHT_HAVE_PCI
 	select DMABOUNCE if PCI
 	help
 	  Support for Intel's IXP4XX (XScale) family of processors.
@@ -1164,7 +1169,7 @@ config ISA_DMA_API
 	bool
 
 config PCI
-	bool "PCI support" if ARCH_INTEGRATOR_AP || ARCH_VERSATILE_PB || ARCH_IXP4XX || ARCH_KS8695 || MACH_ARMCORE || ARCH_CNS3XXX
+	bool "PCI support" if MIGHT_HAVE_PCI
 	help
 	  Find out whether you have a PCI motherboard. PCI is the name of a
 	  bus system, i.e. the way the CPU talks to the other stuff inside
arch/arm/mach-cns3xxx/Kconfig +1 -0
index 9ebfcc4..29b13f2 100644
@@ -3,6 +3,7 @@ menu "CNS3XXX platform type"
 
 config MACH_CNS3420VB
 	bool "Support for CNS3420 Validation Board"
+	select MIGHT_HAVE_PCI
 	help
 	  Include support for the Cavium Networks CNS3420 MPCore Platform
 	  Baseboard.
arch/arm/mach-integrator/Kconfig +1 -0
index 27db275..769b0f1 100644
@@ -4,6 +4,7 @@ menu "Integrator Options"
 
 config ARCH_INTEGRATOR_AP
 	bool "Support Integrator/AP and Integrator/PP2 platforms"
+	select MIGHT_HAVE_PCI
 	help
 	  Include support for the ARM(R) Integrator/AP and
 	  Integrator/PP2 platforms.
arch/arm/mach-ks8695/Kconfig +1 -0
index fe0c82e..f5c39a8 100644
@@ -4,6 +4,7 @@ menu "Kendin/Micrel KS8695 Implementations"
 
 config MACH_KS8695
 	bool "KS8695 development board"
+	select MIGHT_HAVE_PCI
 	help
 	  Say 'Y' here if you want your kernel to run on the original
 	  Kendin-Micrel KS8695 development board.
arch/arm/mach-pxa/Kconfig +1 -0
index dd235ec..716a2e1 100644
@@ -94,6 +94,7 @@ config MACH_ARMCORE
 	select PXA27x
 	select IWMMXT
 	select PXA25x
+	select MIGHT_HAVE_PCI
 
 config MACH_EM_X270
 	bool "CompuLab EM-x270 platform"
arch/arm/mach-versatile/Kconfig +1 -0
index c781f30..3f7b5e9 100644
@@ -4,6 +4,7 @@ menu "Versatile platform type"
 config ARCH_VERSATILE_PB
 	bool "Support Versatile/PB platform"
 	select CPU_ARM926T
+	select MIGHT_HAVE_PCI
 	default y
 	help
 	  Include support for the ARM(R) Versatile/PB platform.
Signature · 1 line
1.7.3.2
#2 lore raw
In reply to Hans Ulli Kroll
Quoted 20 lines · Hans Ulli Kroll

Today more boards with arm cpu have selectable pci bus. This patch makes this more scalable and remove line continuations in Kconfig

---
 arch/arm/Kconfig                 |    7 ++++++-
 arch/arm/mach-cns3xxx/Kconfig    |    1 +
 arch/arm/mach-integrator/Kconfig |    1 +
 arch/arm/mach-ks8695/Kconfig     |    1 +
 arch/arm/mach-pxa/Kconfig        |    1 +
 arch/arm/mach-versatile/Kconfig  |    1 +
 6 files changed, 11 insertions(+), 1 deletions(-)
arch/arm/Kconfig +0 -0
index a19a526..614cf2f 100644

arch/arm/Kconfig config ARM · line 37

Quoted 4 lines
arch/arm/Kconfig +1 -0
@@ -34,6 +34,9 @@ config ARM
 config HAVE_PWM
 	bool
 
+config MIGHT_HAVE_PCI

HAVE_PCI or HAS_PCI is a more usual name for this purpose.

Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#3 lore raw
Quoted 24 lines · Uwe Kleine-K?nig
Quoted 23 lines · Hans Ulli Kroll

Today more boards with arm cpu have selectable pci bus. This patch makes this more scalable and remove line continuations in Kconfig

---
 arch/arm/Kconfig                 |    7 ++++++-
 arch/arm/mach-cns3xxx/Kconfig    |    1 +
 arch/arm/mach-integrator/Kconfig |    1 +
 arch/arm/mach-ks8695/Kconfig     |    1 +
 arch/arm/mach-pxa/Kconfig        |    1 +
 arch/arm/mach-versatile/Kconfig  |    1 +
 6 files changed, 11 insertions(+), 1 deletions(-)
arch/arm/Kconfig +0 -0
index a19a526..614cf2f 100644
@@ -34,6 +34,9 @@ config ARM
 config HAVE_PWM
 	bool
 
Quoted 2 lines

arch/arm/Kconfig config ARM · line 37

Quoted 1 line
arch/arm/Kconfig +1 -0
+config MIGHT_HAVE_PCI

HAVE_PCI or HAS_PCI is a more usual name for this purpose.

This has been discussed in the thread "[PATCH] ARM: Gemini: Add support for PCI Bus".

#4 lore raw
Quoted 25 lines · Russell King - ARM Linux
Quoted 24 lines · Uwe Kleine-K?nig
Quoted 23 lines · Hans Ulli Kroll

Today more boards with arm cpu have selectable pci bus. This patch makes this more scalable and remove line continuations in Kconfig

---
 arch/arm/Kconfig                 |    7 ++++++-
 arch/arm/mach-cns3xxx/Kconfig    |    1 +
 arch/arm/mach-integrator/Kconfig |    1 +
 arch/arm/mach-ks8695/Kconfig     |    1 +
 arch/arm/mach-pxa/Kconfig        |    1 +
 arch/arm/mach-versatile/Kconfig  |    1 +
 6 files changed, 11 insertions(+), 1 deletions(-)
arch/arm/Kconfig +0 -0
index a19a526..614cf2f 100644
@@ -34,6 +34,9 @@ config ARM
 config HAVE_PWM
 	bool
 
Quoted 5 lines
Quoted 2 lines

arch/arm/Kconfig config ARM · line 37

Quoted 1 line
arch/arm/Kconfig +1 -0
+config MIGHT_HAVE_PCI

HAVE_PCI or HAS_PCI is a more usual name for this purpose.

This has been discussed in the thread "[PATCH] ARM: Gemini: Add support for PCI Bus".

Ah, I see, MIGHT_HAVE_PCI only makes the prompt available. Hmm, well OK.

Thanks for clearifying
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#5 lore raw
In reply to Hans Ulli Kroll

hi,

Quoted 6 lines

?config PCI
- ? ? ? bool "PCI support" if ARCH_INTEGRATOR_AP || ARCH_VERSATILE_PB || ARCH_IXP4XX || ARCH_KS8695 || MACH_ARMCORE || ARCH_CNS3XXX
+ ? ? ? bool "PCI support" if MIGHT_HAVE_PCI
? ? ? ?help
? ? ? ? ?Find out whether you have a PCI motherboard. PCI is the name of a
? ? ? ? ?bus system, i.e. the way the CPU talks to the other stuff inside

This used to enable PCI support for all KS8695-based boards. (ARCH_KS8695)

Quoted 10 lines
arch/arm/mach-ks8695/Kconfig +0 -0
@@ -4,6 +4,7 @@ menu "Kendin/Micrel KS8695 Implementations"
 

?config MACH_KS8695
? ? ? ?bool "KS8695 development board"
+ ? ? ? select MIGHT_HAVE_PCI
? ? ? ?help
? ? ? ? ?Say 'Y' here if you want your kernel to run on the original ? ? ? ? ?Kendin-Micrel KS8695 development board.

Where-as this only enables it for the KS8695 Development board (MACH_KS8695)....

Regards.
Andrew Victor