ath5k: Update version string
Nick Kossifidis
maintainerPATCH 5/6 ath5k: Update version string
* Change version number, we've added various new features lately. We need to find a way to maintain this, maybe on each kernel release or something. Also remove "EXPERIMENTAL", we aren't experimental any more I think ;-)
--- drivers/net/wireless/ath/ath5k/base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ath/ath5k/base.c +1 -1
@@ -78,7 +78,7 @@ MODULE_AUTHOR("Nick Kossifidis");MODULE_DESCRIPTION ("Support for 5xxx series of Atheros 802.11 wireless LAN cards." );MODULE_SUPPORTED_DEVICE ("Atheros 5xxx WLAN cards" );MODULE_LICENSE ("Dual BSD/GPL" ); -MODULE_VERSION ("0.6.0 (EXPERIMENTAL)" ); +MODULE_VERSION ("0.7.0" );static int ath5k_reset (struct ath5k_softc *sc,struct ieee80211_channel *chan,bool skip_pcu);
Quoted 8 lines · Nick Kossifidis
* Change version number, we've added various new features lately. We need to find a way to maintain this, maybe on each kernel release or something. Also remove "EXPERIMENTAL", we aren't experimental any more I think ;-)
Signed-off-by Nick Kossifidis <[email protected]>+MODULE_VERSION("0.7.0");
How about just remove this all together, the version should go by the kernel or git describe.
Luis
Quoted 6 lines · Luis R. Rodriguez
Quoted 5 lines · Nick Kossifidis
* Change version number, we've added various new features lately. We need to find a way to maintain this, maybe on each kernel release or something. Also remove "EXPERIMENTAL", we aren't experimental any more I think ;-)
Quoted 6 lines
Quoted 3 lines
Signed-off-by Nick Kossifidis <[email protected]>+MODULE_VERSION("0.7.0");
How about just remove this all together, the version should go by the kernel or git describe.
ACK -- any objections?
John
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
Nick Kossifidis
maintainer2010/12/3 John W. Linville <[email protected]>:
Quoted 9 lines · Luis R. Rodriguez
Quoted 8 lines · Nick Kossifidis
Quoted 6 lines
* Change version number, we've added various new features lately. We need to find a way to maintain this, maybe on each kernel release or something. Also remove "EXPERIMENTAL", we aren't experimental any more I think ;-)
Signed-off-by Nick Kossifidis <[email protected]>
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
+MODULE_VERSION("0.7.0");
How about just remove this all together, the version should go by the kernel or git describe.
ACK -- any objections?
John
I'm OK with it, seems reasonable, after all we track changes on the wiki page per date with links to commits on git so there is no need to maintain the version field...
http://wireless.kernel.org/en/users/Drivers/ath5k
Signature · 3 lines
GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick
Quoted 25 lines · Nick Kossifidis
* Change version number, we've added various new features lately. We need to find a way to maintain this, maybe on each kernel release or something. Also remove "EXPERIMENTAL", we aren't experimental any more I think ;-)
Signed-off-by Nick Kossifidis <[email protected]>---
drivers/net/wireless/ath/ath5k/base.c | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/wireless/ath/ath5k/base.c +1
-1@@ -78,7 +78,7 @@ MODULE_AUTHOR("Nick Kossifidis"); MODULE_DESCRIPTION("Support for 5xxx series of Atheros 802.11 wireless LAN cards."); MODULE_SUPPORTED_DEVICE("Atheros 5xxx WLAN cards"); MODULE_LICENSE("Dual BSD/GPL"); -MODULE_VERSION ("0.6.0 (EXPERIMENTAL)" ); +MODULE_VERSION ("0.7.0" ); static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan, bool skip_pcu);
Quoted 17 lines · Nick Kossifidis
* Change version number, we've added various new features lately. We need to find a way to maintain this, maybe on each kernel release or something. Also remove "EXPERIMENTAL", we aren't experimental any more I think ;-)
Signed-off-by Nick Kossifidis <[email protected]>---
drivers/net/wireless/ath/ath5k/base.c | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/wireless/ath/ath5k/base.c +0
-0
drivers/net/wireless/ath/ath5k/base.c MODULE_AUTHOR("Nick Kossifidis"); · line 84
Quoted 8 lines
drivers/net/wireless/ath/ath5k/base.c +1
-1@@ -78,7 +78,7 @@ MODULE_AUTHOR("Nick Kossifidis"); MODULE_DESCRIPTION("Support for 5xxx series of Atheros 802.11 wireless LAN cards."); MODULE_SUPPORTED_DEVICE("Atheros 5xxx WLAN cards"); MODULE_LICENSE("Dual BSD/GPL"); -MODULE_VERSION ("0.6.0 (EXPERIMENTAL)" ); +MODULE_VERSION ("0.7.0" ); static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan, bool skip_pcu);
Against linux-next (next-20101203) this patch needs a refresh (see attached v2). Guess you created your patchset from wireless-testing.
- Sedat -
drivers/net/wireless/ath/ath5k/base.c +1 -1
@@ -76,7 +76,7 @@MODULE_DESCRIPTION ("Support for 5xxx series of Atheros 802.11 wireless LAN cards." );MODULE_SUPPORTED_DEVICE ("Atheros 5xxx WLAN cards" );MODULE_LICENSE ("Dual BSD/GPL" ); -MODULE_VERSION ("0.6.0 (EXPERIMENTAL)" ); +MODULE_VERSION ("0.7.0" );static int ath5k_init (struct ieee80211_hw *hw); static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan,
PATCH 1/1 ath5k: remove MODULE_VERSION
In reply to Nick KossifidisSince this is updated manually and sporadically, it is fairly useless anyway.
--- drivers/net/wireless/ath/ath5k/base.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/wireless/ath/ath5k/base.c +0 -1
@@ -76,7 +76,6 @@ MODULE_AUTHOR("Nick Kossifidis");MODULE_DESCRIPTION ("Support for 5xxx series of Atheros 802.11 wireless LAN cards." );MODULE_SUPPORTED_DEVICE ("Atheros 5xxx WLAN cards" );MODULE_LICENSE ("Dual BSD/GPL" ); -MODULE_VERSION ("0.6.0 (EXPERIMENTAL)" );static int ath5k_init (struct ieee80211_hw *hw); static int ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan,
Signature · 1 line
1.7.3.2