Skip to contentSkip to conversation

STM/MCI: Fix wrong register bit

PATCH In review Juergen Beisert 2 participants 2 messages Dec 3, 2010 – Dec 5, 2010 Arm STM32

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 STM/MCI: Fix wrong register bit

---
 drivers/mci/stm378x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mci/stm378x.c +1 -1
Index: barebox-git/drivers/mci/stm378x.c
===================================================================
@@ -52,7 +52,7 @@
 # define SSP_CTRL0_SFTRST (1 << 31)
 # define SSP_CTRL0_CLKGATE (1 << 30)
 # define SSP_CTRL0_RUN (1 << 29)
-# define SSP_CTRL0_LOCK_CS (1 << 29)
+# define SSP_CTRL0_LOCK_CS (1 << 27)
 # define SSP_CTRL0_READ (1 << 25)
 # define SSP_CTRL0_IGNORE_CRC (1 << 26)
 # define SSP_CTRL0_DATA_XFER (1 << 24)
Signature · 9 lines
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw
Quoted 1 line · Juergen Beisert

Maybe add something like: "The define isn't used up to now, so the wrong offset didn't stick out before. For the same reason this fix isn't critical." to the changelog?

Uwe

Quoted 18 lines
---
 drivers/mci/stm378x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: barebox-git/drivers/mci/stm378x.c
===================================================================

drivers/mci/stm378x.c +1 -1
@@ -52,7 +52,7 @@
 # define SSP_CTRL0_SFTRST (1 << 31)
 # define SSP_CTRL0_CLKGATE (1 << 30)
 # define SSP_CTRL0_RUN (1 << 29)
-# define SSP_CTRL0_LOCK_CS (1 << 29)
+# define SSP_CTRL0_LOCK_CS (1 << 27)
 # define SSP_CTRL0_READ (1 << 25)
 # define SSP_CTRL0_IGNORE_CRC (1 << 26)
 # define SSP_CTRL0_DATA_XFER (1 << 24)
Signature · 7 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox