New package: sdparm

PATCH Superseded Yegor Yefremov 2 participants 3 messages Dec 6, 2010 – Dec 7, 2010

lore

Share & tools

lore

Yegor Yefremov

author

2010-12-06 10:58 UTC #0 lore raw

PATCH 1/1 New package: sdparm

Add utility to accesses SCSI device parameters.

Signed-off-by Yegor Yefremov <[email protected]>

package/sdparm/Config.in new file +4 -0

Index: b/package/sdparm/Config.in
===================================================================
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_SDPARM
+	bool "sdparm"
+	help
+	  Utility to accesses SCSI device parameters.

package/sdparm/sdparm.mk new file +7 -0

Index: b/package/sdparm/sdparm.mk
===================================================================
@@ -0,0 +1,7 @@
+SDPARM_VERSION = 1.06
+SDPARM_SOURCE = sdparm-$(SDPARM_VERSION).tgz
+SDPARM_SITE = http://sg.danny.cz/sg/p/
+SDPARM_INSTALL_STAGING = NO
+SDPARM_INSTALL_TARGET = YES
+
+$(eval $(call AUTOTARGETS,package,sdparm))

package/Config.in +1 -0

Index: b/package/Config.in
===================================================================
@@ -184,6 +184,7 @@
 source "package/ntfsprogs/Config.in"
 source "package/pciutils/Config.in"
 source "package/rng-tools/Config.in"
+source "package/sdparm/Config.in"
 source "package/setserial/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 # busybox has fdisk

Thomas Petazzoni

2010-12-06 20:05 UTC #1 lore raw

PATCH 1/1 New package: sdparm

Hello Yegor,

package/sdparm/Config.in line 4

Quoted 9 lines · On Mon, 06 Dec 2010 11:58:33 +0100 Yegor Yefremov…

Index: b/package/sdparm/Config.in
===================================================================
package/sdparm/Config.in new file +5 -0
+0100 @@ -0,0 +1,4 @@
+config BR2_PACKAGE_SDPARM
+	bool "sdparm"
+	help
+	  Utility to accesses SCSI device parameters.

We generally put the URL of the project here in the help text.

package/sdparm/sdparm.mk line 5

Quoted 10 lines

Index: b/package/sdparm/sdparm.mk
===================================================================
package/sdparm/sdparm.mk new file +6 -0
+0100 @@ -0,0 +1,7 @@
+SDPARM_VERSION = 1.06
+SDPARM_SOURCE = sdparm-$(SDPARM_VERSION).tgz
+SDPARM_SITE = http://sg.danny.cz/sg/p/
+SDPARM_INSTALL_STAGING = NO
+SDPARM_INSTALL_TARGET = YES

You can get rid of those last two lines, they are the default behaviour.

Once you have fixed those two minors comment, you get my:

Acked-by Thomas Petazzoni <[email protected]>

Peter: it builds fine here with a minimal Buildroot toolchain (no largefile, no IPv6, no locale, etc.).

Regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Yegor Yefremov

author

2010-12-07 09:07 UTC #2 lore raw

PATCH 1/1 New package: sdparm

Hello Thomas,

Quoted 16 lines

Hello Yegor,
package/sdparm/Config.in line 4
Quoted 9 lines · On Mon, 06 Dec 2010 11:58:33 +0100 Yegor Yefremov…
Index: b/package/sdparm/Config.in
===================================================================
package/sdparm/Config.in new file +5 -0
+0100 @@ -0,0 +1,4 @@
+config BR2_PACKAGE_SDPARM
+	bool "sdparm"
+	help
+	  Utility to accesses SCSI device parameters.
We generally put the URL of the project here in the help text.

Quoted 12 lines

package/sdparm/sdparm.mk line 5
Quoted 10 lines
Index: b/package/sdparm/sdparm.mk
===================================================================
package/sdparm/sdparm.mk new file +6 -0
+0100 @@ -0,0 +1,7 @@
+SDPARM_VERSION = 1.06
+SDPARM_SOURCE = sdparm-$(SDPARM_VERSION).tgz
+SDPARM_SITE = http://sg.danny.cz/sg/p/
+SDPARM_INSTALL_STAGING = NO
+SDPARM_INSTALL_TARGET = YES
You can get rid of those last two lines, they are the default behaviour.

I made the changes. Thanks for reviewing.

Yegor