X.25: decrement netdev reference counts on unload
Subsystems (3)
PATCH 1/1 X.25: decrement netdev reference counts on unload
Hello,
We came across this bug when we accidentally loaded and unloaded the x25 kernel module on a host with KVM virtual machines. All subsequent attempts to stop a KVM instance resulted in the KVM process entering D state. Reproducing this behaviour can be done in the following way:
1. modprobe x25
2. tunctl && ifconfig tap0 up
3. rmmod x25
4. tunctl -d tap0 (hangs)
A patch follows - we don't use X.25 ourselves so I'm not sure it won't panic someone's system.
Regards,
Apollon
PS: I am not subscribed to the list, so please copy any replies to my address. Thanks!
----
x25 does not decrement the network device reference counts on module unload. Thus unregistering any pre-existing interface after unloading the x25 module hangs and results in
unregister_netdevice: waiting for tap0 to become free. Usage count = 1
This patch decrements the reference counts of all interfaces in x25_link_free, the way it is already done in x25_link_device_down for NETDEV_DOWN events.
--- net/x25/x25_link.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
net/x25/x25_link.c +1 -0
@@ -394,6 +394,7 @@ void __exit x25_link_free(void)list_for_each_safe (entry, tmp, &x25_neigh_list) { nb = list_entry(entry, struct x25_neigh, node);__x25_remove_neigh (nb); +dev_put (nb->dev); }write_unlock_bh (&x25_neigh_list_lock); }
--
1.7.1
Thanks for the patch.
Can reproduce it on a vm here, I'll verify it when have access to some X.25 networks tomorrow.
2010/12/8 Apollon Oikonomopoulos <[email protected]>:
Quoted 54 lines
Hello,
We came across this bug when we accidentally loaded and unloaded the x25 kernel module on a host with KVM virtual machines. All subsequent attempts to stop a KVM instance resulted in the KVM process entering D state. Reproducing this behaviour can be done in the following way:
1. modprobe x25
2. tunctl && ifconfig tap0 up
3. rmmod x25
4. tunctl -d tap0 (hangs)A patch follows - we don't use X.25 ourselves so I'm not sure it won't panic someone's system.
Regards,
ApollonPS: I am not subscribed to the list, so please copy any replies to my address. Thanks!
----
x25 does not decrement the network device reference counts on module unload. Thus unregistering any pre-existing interface after unloading the x25 module hangs and results inunregister_netdevice: waiting for tap0 to become free. Usage count = 1
This patch decrements the reference counts of all interfaces in
x25_link_free, the way it is already done inx25_link_device_downforNETDEV_DOWNevents.Signed-off-by Apollon Oikonomopoulos <[email protected]>---
net/x25/x25_link.c | 1 +1 files changed, 1 insertions(+), 0 deletions(-)net/x25/x25_link.c +1
-1@@ -394,6 +394,7 @@ void __exit x25_link_free(void) list_for_each_safe(entry, tmp, &x25_neigh_list) { nb = list_entry(entry, struct x25_neigh, node); __x25_remove_neigh(nb); + dev_put(nb->dev); } write_unlock_bh(&x25_neigh_list_lock); } --1.7.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
maintainerFrom: Apollon Oikonomopoulos <[email protected]>
Date: Tue, 7 Dec 2010 21:43:30 +0200
Quoted 10 lines
x25 does not decrement the network device reference counts on module unload. Thus unregistering any pre-existing interface after unloading the x25 module hangs and results in
unregister_netdevice: waiting for tap0 to become free. Usage count = 1This patch decrements the reference counts of all interfaces in
x25_link_free, the way it is already done inx25_link_device_downforNETDEV_DOWNevents.Signed-off-by Apollon Oikonomopoulos <[email protected]>
Applied and queued up for -stable, thanks.