TCP: Bug fix in initialization of receive window.
Subsystems (3)
PATCH 1/1 TCP: Bug fix in initialization of receive window.
The bug has to do with boundary checks on the initial receive window. If the initial receive window falls between init_cwnd and the receive window specified by the user, the initial window is incorrectly brought down to init_cwnd. The correct behavior is to allow it to remain unchanged.
--- net/ipv4/tcp_output.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-)
net/ipv4/tcp_output.c +4 -5
@@ -231,11 +231,10 @@ void tcp_select_initial_window(int __space, __u32 mss,/* when initializing use the value from init_rcv_wnd * rather than the default from above */ -if (init_rcv_wnd && - (*rcv_wnd > init_rcv_wnd * mss)) - *rcv_wnd = init_rcv_wnd * mss; -else if (*rcv_wnd > init_cwnd * mss) - *rcv_wnd = init_cwnd * mss; +if (init_rcv_wnd) + *rcv_wnd =min (*rcv_wnd, init_rcv_wnd * mss); +else + *rcv_wnd =min (*rcv_wnd, init_cwnd * mss); }/* Set the clamp no higher than max representable value */
Signature · 1 line
1.7.3.1
David Miller
maintainerFrom: Nandita Dukkipati <[email protected]>
Date: Fri, 3 Dec 2010 15:33:44 -0800
Quoted 7 lines
The bug has to do with boundary checks on the initial receive window. If the initial receive window falls between
init_cwndand the receive window specified by the user, the initial window is incorrectly brought down toinit_cwnd. The correct behavior is to allow it to remain unchanged.Signed-off-by Nandita Dukkipati <[email protected]>
Applied and queued up for -stable, thanks.