Skip to contentSkip to conversation

mlx4: Change a warning message to debug

PATCH In review Eli Cohen 2 participants 6 messages Dec 8, 2010 – Jan 4, 2011 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Eli Cohen

author
#0 lore raw

PATCH 1/1 mlx4: Change a warning message to debug

This workaround presented in 58d74bb is not something we should alert the user on. Debug level message is enough.

---
 drivers/net/mlx4/fw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/mlx4/fw.c +1 -1
index 7a7e18b..9f415df 100644
@@ -290,7 +290,7 @@ int mlx4_QUERY_DEV_CAP(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap)
 		dev_cap->bf_reg_size = 1 << (field & 0x1f);
 		MLX4_GET(field, outbox, QUERY_DEV_CAP_LOG_MAX_BF_REGS_PER_PAGE_OFFSET);
 		if ((1 << (field & 0x3f)) > (PAGE_SIZE / dev_cap->bf_reg_size)) {
-			mlx4_warn(dev, "firmware bug: log2 # of blue flame regs is invalid (%d), forcing 3\n", field & 0x1f);
+			mlx4_dbg(dev, "firmware bug: log2 # of blue flame regs is invalid (%d), forcing 3\n", field & 0x1f);
 			field = 3;
 		}
 		dev_cap->bf_regs_per_page = 1 << (field & 0x3f);
Signature · 6 lines
1.7.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 2 lines

This workaround presented in 58d74bb is not something we should alert the user on. Debug level message is enough.

Not sure I agree ... surely the point of this message is for the user to see it and know to update firmware? Otherwise why print anything at all, since I'm sure you guys have already fixed the firmware and have a regression test so this bug doesn't reappear?

- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#3 lore raw
Quoted 8 lines · Roland Dreier
Quoted 2 lines

This workaround presented in 58d74bb is not something we should alert the user on. Debug level message is enough.

Not sure I agree ... surely the point of this message is for the user to see it and know to update firmware? Otherwise why print anything at all, since I'm sure you guys have already fixed the firmware and have a regression test so this bug doesn't reappear?

Right :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 6 lines
Quoted 4 lines

Not sure I agree ... surely the point of this message is for the user to see it and know to update firmware? Otherwise why print anything at all, since I'm sure you guys have already fixed the firmware and have a regression test so this bug doesn't reappear?

Right :-)

So what do you think -- remove the message entirely or leave it?

- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]