Skip to contentSkip to conversation

New package: fbgrab

PATCH Superseded Daniel Nyström 2 participants 3 messages Dec 7, 2010 – Dec 9, 2010

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 New package: fbgrab

FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

---
 package/Config.in                           |    1 +
 package/fbgrab/Config.in                    |    8 ++++++++
 package/fbgrab/fbgrab-proper_makefile.patch |   16 ++++++++++++++++
 package/fbgrab/fbgrab.mk                    |   16 ++++++++++++++++
 4 files changed, 41 insertions(+), 0 deletions(-)
 create mode 100644 package/fbgrab/Config.in
 create mode 100644 package/fbgrab/fbgrab-proper_makefile.patch
 create mode 100644 package/fbgrab/fbgrab.mk
package/Config.in +1 -0
index 08ffda6..2618ecb 100644
@@ -94,6 +94,7 @@ source "package/directfb/Config.in"
 source "package/directfb-examples/Config.in"
 source "package/divine/Config.in"
 source "package/fbdump/Config.in"
+source "package/fbgrab/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/fbset/Config.in"
 endif
package/fbgrab/Config.in new file +8 -0
new file mode 100644
index 0000000..0ede91e
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_FBGRAB
+	bool "fbgrab"
+	select BR2_PACKAGE_LIBPNG
+        select BR2_PACKAGE_ZLIB
+	help
+	  FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.
+
+	  http://hem.bredband.net/gmogmo/fbgrab
package/fbgrab/fbgrab-proper_makefile.patch new file +16 -0
new file mode 100644
index 0000000..8f7919e
@@ -0,0 +1,16 @@
+--- fbgrab-1.0.orig/Makefile	2010-12-07 22:57:24.000000000 +0100
++++ fbgrab-1.0/Makefile	2010-12-07 22:58:36.000000000 +0100
+@@ -3,9 +3,10 @@
+ ### modular. So this is a simple gnu Makefile...
+ ###
+ 
+-fbgrab: fbgrab.c
+-	splint +posixlib fbgrab.c
+-	gcc -g -Wall fbgrab.c -lpng -lz -o fbgrab
++LDFLAGS += -lpng -lz
++
++fbgrab: fbgrab.o
++	$(CC) $(LDFLAGS) fbgrab.o -o $@
+ 
+ install:
+ 	strip fbgrab
package/fbgrab/fbgrab.mk new file +16 -0
new file mode 100644
index 0000000..459fd37
@@ -0,0 +1,16 @@
+FBGRAB_VERSION = 1.0
+FBGRAB_SOURCE = fbgrab-$(FBGRAB_VERSION).tar.gz
+FBGRAB_SITE = http://hem.bredband.net/gmogmo/fbgrab
+FBGRAB_DEPENDENCIES = libpng zlib
+
+define FBGRAB_BUILD_CMDS
+	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		$(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
+endef
+
+define FBGRAB_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(call GENTARGETS,package,fbgrab))
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 New package: fbgrab

Hello,

Thanks for proposing this package!

Quoted 1 line · On Wed, 8 Dec 2010 00:22:50 +0100 Daniel Nystr?m…

FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

The git commit log should be wrapped at a reasonable limit (~ 80 columns).

package/fbgrab/Config.in line 4

Quoted 10 lines
package/fbgrab/Config.in new file +4 -0
new file mode 100644
index 0000000..0ede91e
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_FBGRAB
+	bool "fbgrab"
+	select BR2_PACKAGE_LIBPNG
+        select BR2_PACKAGE_ZLIB

Indentation issue. It should be one tab before bool/select/help, and the help message itself should be indented with one tab + 2 spaces.

package/fbgrab/Config.in line 6

Quoted 2 lines
package/fbgrab/Config.in new file +2 -0
+	help
+	  FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

Should be wrapped at a reasonable limit as well.

package/fbgrab/fbgrab-proper_makefile.patch

Quoted 5 lines
package/fbgrab/fbgrab-proper_makefile.patch new file +0 -0
new file mode 100644
index 0000000..8f7919e

Peter wants each patch to have a description and an author here.

Quoted 23 lines
package/fbgrab/fbgrab-proper_makefile.patch new file +16 -0
@@ -0,0 +1,16 @@
+--- fbgrab-1.0.orig/Makefile	2010-12-07 22:57:24.000000000 +0100
++++ fbgrab-1.0/Makefile	2010-12-07 22:58:36.000000000 +0100
+@@ -3,9 +3,10 @@
+ ### modular. So this is a simple gnu Makefile...
+ ###
+ 
+-fbgrab: fbgrab.c
+-	splint +posixlib fbgrab.c
+-	gcc -g -Wall fbgrab.c -lpng -lz -o fbgrab
++LDFLAGS += -lpng -lz
++
++fbgrab: fbgrab.o
++	$(CC) $(LDFLAGS) fbgrab.o -o $@
+ 
+ install:
+ 	strip fbgrab
package/fbgrab/fbgrab.mk new file +0 -0
new file mode 100644
index 0000000..459fd37

package/fbgrab/fbgrab.mk line 10

Quoted 10 lines
package/fbgrab/fbgrab.mk new file +10 -0
@@ -0,0 +1,16 @@
+FBGRAB_VERSION = 1.0
+FBGRAB_SOURCE = fbgrab-$(FBGRAB_VERSION).tar.gz
+FBGRAB_SITE = http://hem.bredband.net/gmogmo/fbgrab
+FBGRAB_DEPENDENCIES = libpng zlib
+
+define FBGRAB_BUILD_CMDS
+	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		$(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
+endef

Can you try to see if using $(TARGET_CONFIGURE_OPTS) is possible to pass CFLAGS/LDFLAGS/CC/LD ?

package/fbgrab/fbgrab.mk line 14

Quoted 3 lines
package/fbgrab/fbgrab.mk new file +3 -0
+define FBGRAB_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin
+endef

This will install "fbgrab" as a file named "bin" in $(TARGET_DIR)/usr. So the line should be :

$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin/fbgrab

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 New package: fbgrab

Thanks for your constructive comments! A new patch has been submitted.

2010/12/8 Thomas Petazzoni <[email protected]>:

Quoted 98 lines

Hello,

Thanks for proposing this package!

Quoted 1 line · On Wed, ?8 Dec 2010 00:22:50 +0100 Daniel Nystr?m…

FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

The git commit log should be wrapped at a reasonable limit (~ 80 columns).

package/fbgrab/Config.in line 4

Quoted 10 lines
package/fbgrab/Config.in new file +4 -0
new file mode 100644
index 0000000..0ede91e
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_FBGRAB
+ ? ? bool "fbgrab"
+ ? ? select BR2_PACKAGE_LIBPNG
+ ? ? ? ?select BR2_PACKAGE_ZLIB

Indentation issue. It should be one tab before bool/select/help, and the help message itself should be indented with one tab + 2 spaces.

package/fbgrab/Config.in line 6

Quoted 2 lines
package/fbgrab/Config.in new file +2 -0
+ ? ? help
+ ? ? ? FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

Should be wrapped at a reasonable limit as well.

package/fbgrab/fbgrab-proper_makefile.patch

Quoted 5 lines
package/fbgrab/fbgrab-proper_makefile.patch new file +0 -0
new file mode 100644
index 0000000..8f7919e

Peter wants each patch to have a description and an author here.

Quoted 23 lines
package/fbgrab/fbgrab-proper_makefile.patch new file +16 -0
@@ -0,0 +1,16 @@
+--- fbgrab-1.0.orig/Makefile 2010-12-07 22:57:24.000000000 +0100
++++ fbgrab-1.0/Makefile ? ? ?2010-12-07 22:58:36.000000000 +0100
+@@ -3,9 +3,10 @@
+ ### modular. So this is a simple gnu Makefile...
+ ###
+
+-fbgrab: fbgrab.c
+- ? ?splint +posixlib fbgrab.c
+- ? ?gcc -g -Wall fbgrab.c -lpng -lz -o fbgrab
++LDFLAGS += -lpng -lz
++
++fbgrab: fbgrab.o
++ ? ?$(CC) $(LDFLAGS) fbgrab.o -o $@
+
+ install:
+ ? ? strip fbgrab
package/fbgrab/fbgrab.mk new file +0 -0
new file mode 100644
index 0000000..459fd37

package/fbgrab/fbgrab.mk line 10

Quoted 10 lines
package/fbgrab/fbgrab.mk new file +10 -0
@@ -0,0 +1,16 @@
+FBGRAB_VERSION = 1.0
+FBGRAB_SOURCE = fbgrab-$(FBGRAB_VERSION).tar.gz
+FBGRAB_SITE = http://hem.bredband.net/gmogmo/fbgrab
+FBGRAB_DEPENDENCIES = libpng zlib
+
+define FBGRAB_BUILD_CMDS
+ ? ? $(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
+ ? ? ? ? ? ? LDFLAGS="$(TARGET_LDFLAGS)" \
+ ? ? ? ? ? ? $(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
+endef

Can you try to see if using $(TARGET_CONFIGURE_OPTS) is possible to pass CFLAGS/LDFLAGS/CC/LD ?

package/fbgrab/fbgrab.mk line 14

Quoted 3 lines
package/fbgrab/fbgrab.mk new file +3 -0
+define FBGRAB_INSTALL_TARGET_CMDS
+ ? ? $(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin
+endef

This will install "fbgrab" as a file named "bin" in $(TARGET_DIR)/usr. So the line should be :

$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin/fbgrab

Regards,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot