Skip to contentSkip to conversation

ppc4xx: 460SX Eegier board support

PATCH New tmarri at apm.com 3 participants 3 messages Dec 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: 460SX Eegier board support

From: Tirumala Marri <[email protected]>

Adding Eiger board support for 460SX SoC.

---
 MAINTAINERS                |    4 +
 board/amcc/eiger/Makefile  |   48 +++++++++++
 board/amcc/eiger/config.mk |   30 +++++++
 board/amcc/eiger/eiger.c   |   91 +++++++++++++++++++++
 board/amcc/eiger/init.S    |   67 +++++++++++++++
 boards.cfg                 |    1 +
 include/configs/eiger.h    |  192 ++++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 433 insertions(+), 0 deletions(-)
 create mode 100644 board/amcc/eiger/Makefile
 create mode 100644 board/amcc/eiger/config.mk
 create mode 100644 board/amcc/eiger/eiger.c
 create mode 100644 board/amcc/eiger/init.S
 create mode 100644 include/configs/eiger.h
MAINTAINERS +4 -0
index f47fca5..9012092 100644
@@ -310,6 +310,10 @@ Tirumala Marri <[email protected]>
 
 	bluestone       APM821XX
 
+Tirumala Marri <[email protected]>
+
+	eiger           460SX
+
 Reinhard Meyer <[email protected]>
 
 	TOP860		MPC860T
board/amcc/eiger/Makefile new file +48 -0

48 lines not on this page · raw message

board/amcc/eiger/config.mk new file +30 -0
new file mode 100644
index 0000000..aa6cbda
@@ -0,0 +1,30 @@
+# Adding config.mk for Eiger board
+#
+# Copyright (c) 2010, Applied Micro Circuits Corporation
+# Authors: 	Tirumala R Marri <[email protected]>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+PLATFORM_CPPFLAGS += -DCONFIG_440=1
+
+ifeq ($(debug),1)
+PLATFORM_CPPFLAGS += -DDEBUG
+endif
+
+ifeq ($(dbcr),1)
+PLATFORM_CPPFLAGS += -DCONFIG_SYS_INIT_DBCR=0x8cff0000
+endif
board/amcc/eiger/eiger.c new file +91 -0

91 lines not on this page · raw message

board/amcc/eiger/init.S new file +67 -0

67 lines not on this page · raw message

boards.cfg +1 -0
index 2209676..c3f9c9c 100644
@@ -641,6 +641,7 @@ bubinga                      powerpc     ppc4xx      -                   amcc
 canyonlands                  powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:CANYONLANDS
 canyonlands_nand             powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:CANYONLANDS,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000
 ebony                        powerpc     ppc4xx      -                   amcc
+eiger                        powerpc ppc4xx          -                   amcc
 glacier                      powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:GLACIER
 glacier_nand                 powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:GLACIER,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000
 haleakala                    powerpc     ppc4xx      kilauea             amcc           -           kilauea:HALEAKALA
include/configs/eiger.h new file +192 -0

192 lines not on this page · raw message

Signature · 1 line
1.6.1.rc3
#1 lore raw

PATCH 1/1 ppc4xx: 460SX Eegier board support

Hi Marri,

Quoted 3 lines · On Thursday 09 December 2010 02:12:07 tmarri at apm.com wrote:

From: Tirumala Marri <[email protected]>

Adding Eiger board support for 460SX SoC.

Thanks. Some mostly nitpicking comments below.

First typo in the subject: s/Eeigier/Eiger.

<snip>

Quoted 29 lines

b/include/configs/eiger.h
new file mode 100644
index 0000000..bc082a6

include/configs/eiger.h new file +23 -0
@@ -0,0 +1,192 @@
+/*
+ * eiger.h - configuration for Eiger(460SX) Board.
+ *
+ * Copyright (c) 2010, Applied Micro Circuits Corporation
+ * Author: Tirumala R Marri <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+#ifndef __CONFIG_H
+#define __CONFIG_H

include/configs/eiger.h line 33

Quoted 10 lines
include/configs/eiger.h new file +10 -0
+
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_4xx			1	/* ... PPC4xx family	*/
+#define CONFIG_440			1	/* ... PPC460 family	*/
+#define CONFIG_460SX			1	/* ... PPC460 family	*/
+#define CONFIG_BOARD_EARLY_INIT_F	1	/* Call board_pre_init	*/
+
+#define	CONFIG_SYS_TEXT_BASE	0xfffb0000

Please use space instead of tab after "#define".

Quoted 6 lines
include/configs/eiger.h new file +6 -0
+
+/*
+ * Include common defines/options for all AMCC boards
+ */
+#define CONFIG_HOSTNAME		eiger
+

include/configs/eiger.h

Quoted 10 lines
include/configs/eiger.h new file +10 -0
+#include "amcc-common.h"
+
+#define CONFIG_SYS_CLK_FREQ	33333333	/* external freq to pll	*/
+
+/*
+ * Base addresses -- Note these are effective addresses where the
+ * actual resources get mapped (not physical addresses)
+ */
+#define	CONFIG_SYS_BOOT_BASE_ADDR       0xFF000000
+#define CONFIG_SYS_FLASH_BASE		0xfff00000	/* start of 

FLASH */

Again, space after "#define". And use lower- or upper-case hex values consistently in this file. I personally prefer lower-case.

include/configs/eiger.h line 50

Quoted 1 line
include/configs/eiger.h new file +1 -0
+#define CONFIG_SYS_ISRAM_BASE		0x90000000	/* internal 

SRAM */

include/configs/eiger.h line 52

Quoted 2 lines
include/configs/eiger.h new file +2 -0
+
+#define CONFIG_SYS_PCI_BASE		0xd0000000	/* internal PCI regs	

*/

include/configs/eiger.h line 54

Quoted 2 lines
include/configs/eiger.h new file +2 -0
+
+#define CONFIG_SYS_PCIE_MEMBASE		0x90000000	/* mapped PCIe 

memory */

include/configs/eiger.h line 55

Quoted 1 line
include/configs/eiger.h new file +1 -0
+#define CONFIG_SYS_PCIE0_MEMBASE	0x90000000	/* mapped PCIe memory	

*/

include/configs/eiger.h line 56

Quoted 1 line
include/configs/eiger.h new file +1 -0
+#define CONFIG_SYS_PCIE1_MEMBASE	0xa0000000	/* mapped PCIe memory	

*/

Quoted 10 lines
include/configs/eiger.h new file +10 -0
+#define CONFIG_SYS_PCIE_MEMSIZE		0x01000000
+
+#define CONFIG_SYS_PCIE0_XCFGBASE	0xb0000000
+#define CONFIG_SYS_PCIE1_XCFGBASE	0xb2000000
+#define CONFIG_SYS_PCIE2_XCFGBASE	0xb4000000
+#define CONFIG_SYS_PCIE0_CFGBASE	0xb6000000
+#define CONFIG_SYS_PCIE1_CFGBASE	0xb8000000
+#define CONFIG_SYS_PCIE2_CFGBASE	0xba000000
+
+/* PCIe mapped UTL registers */

include/configs/eiger.h

Quoted 10 lines
include/configs/eiger.h new file +10 -0
+#define CONFIG_SYS_PCIE0_REGBASE   0xd0000000
+#define CONFIG_SYS_PCIE1_REGBASE   0xd0010000
+#define CONFIG_SYS_PCIE2_REGBASE   0xd0020000
+
+/* System RAM mapped to PCI space */
+#define CONFIG_PCI_SYS_MEM_BUS	CONFIG_SYS_SDRAM_BASE
+#define CONFIG_PCI_SYS_MEM_PHYS	CONFIG_SYS_SDRAM_BASE
+#define CONFIG_PCI_SYS_MEM_SIZE	(1024 * 1024 * 1024)
+
+#define CONFIG_SYS_OPER_FLASH		0xe7000000	/* SRAM - OPER 

Flash */

What is this "OPER Flash"? Is it used at all in this code? If not you should better remove it.

Quoted 11 lines
include/configs/eiger.h new file +11 -0
+/*
+ * Serial Port
+ */
+#define CONFIG_CONS_INDEX	1	/* Use UART0			*/
+
+/*
+ * Initial RAM & stack pointer (placed in internal SRAM)
+ */
+#define CONFIG_SYS_TEMP_STACK_OCM	1
+#define CONFIG_SYS_OCM_DATA_ADDR	CONFIG_SYS_ISRAM_BASE
+#define CONFIG_SYS_INIT_RAM_ADDR	CONFIG_SYS_ISRAM_BASE	/* Initial RAM
Quoted 1 line

address */ +#define CONFIG_SYS_INIT_RAM_SIZE 0x2000 /*

Size of used area

include/configs/eiger.h

Quoted 9 lines

in RAM */ +
+#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE -
GENERATED_GBL_DATA_SIZE) +#define
CONFIG_SYS_INIT_SP_OFFSET (CONFIG_SYS_GBL_DATA_OFFSET - 0x4) +

include/configs/eiger.h new file +5 -0
+/*
+ * DDR SDRAM
+ */
+#define CONFIG_SPD_EEPROM	1	/* Use SPD EEPROM for setup	*/
+#define CONFIG_DDR_ECC		1	/* with ECC support		

*/

include/configs/eiger.h line 102

Quoted 5 lines
include/configs/eiger.h new file +5 -0
+
+#define CONFIG_SYS_SPD_MAX_DIMMS	2
+
+/* SPD i2c spd addresses */
+#define SPD_EEPROM_ADDRESS     {IIC0_DIMM0_ADDR, IIC0_DIMM1_ADDR}

Indentation with tabs please. And please add space after "{". Otherwise checkpatch will complain:

#define SPD_EEPROM_ADDRESS { IIC0_DIMM0_ADDR, IIC0_DIMM1_ADDR }

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#2 lore raw

PATCH 1/1 ppc4xx: 460SX Eegier board support

In reply to tmarri at apm.com

Dear tmarri at apm.com,

Quoted 2 lines · In message <[email protected]> you wrote:

Adding Eiger board support for 460SX SoC.

I understand the "Eegier" in the Subject: is a typo? That shouldbe "Eiger" as well?

Quoted 6 lines
board/amcc/eiger/Makefile new file +1 -0
+########################################################################
board/amcc/eiger/config.mk new file +0 -0
new file mode 100644
index 0000000..aa6cbda

...

board/amcc/eiger/config.mk line 30

Quoted 9 lines
board/amcc/eiger/config.mk new file +9 -0
+PLATFORM_CPPFLAGS += -DCONFIG_440=1
+
+ifeq ($(debug),1)
+PLATFORM_CPPFLAGS += -DDEBUG
+endif
+
+ifeq ($(dbcr),1)
+PLATFORM_CPPFLAGS += -DCONFIG_SYS_INIT_DBCR=0x8cff0000
+endif

I don't think any of this is needed. Please get rid of the consif.mk file.

Quoted 3 lines
board/amcc/eiger/init.S new file +0 -0
@@ -0,0 +1,67 @@

...

board/amcc/eiger/init.S line 36

Quoted 4 lines
board/amcc/eiger/init.S new file +4 -0
+	/*
+	 * BOOT_CS (FLASH) must be first. Before relocation SA_I can be off to use the
+	 * speed up boot process. It is patched after relocation to enable SA_I
+	 */

Lines too long. Please fix globally.

boards.cfg bubinga powerpc ppc4xx - amcc · line 644

Quoted 7 lines
boards.cfg +1 -0
@@ -641,6 +641,7 @@ bubinga                      powerpc     ppc4xx      -                   amcc
 canyonlands                  powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:CANYONLANDS
 canyonlands_nand             powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:CANYONLANDS,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000
 ebony                        powerpc     ppc4xx      -                   amcc
+eiger                        powerpc ppc4xx          -                   amcc

Could you please use the same vertical alignment as the ebony board above?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are things that are so serious that you can  only  joke  about
them"                                                    - Heisenberg