Skip to contentSkip to conversation

cs5535: deprecate older cs5535_gpio driver

PATCH In review Andres Salomon 4 participants 5 messages Dec 9, 2010 – Dec 10, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cs5535: deprecate older cs5535_gpio driver

The newer drivers/gpio/cs5535-gpio.c replaces drivers/misc/cs5535_gpio.c. The new driver has been in the tree for a little while, and has received some testing; it's time to mark the old one as deprecated. I'm thinking removal around 2.6.40 would be good, provided we're not missing critical functionality in the newer driver.

---
 Documentation/feature-removal-schedule.txt |   14 ++
 drivers/char/Kconfig                       |    9 -
 drivers/char/Makefile                      |    1 -
 drivers/char/cs5535_gpio.c                 |  259 ----------------------------
 drivers/staging/Kconfig                    |    2 +
 drivers/staging/Makefile                   |    1 +
 drivers/staging/cs5535_gpio/Kconfig        |   11 ++
 drivers/staging/cs5535_gpio/Makefile       |    1 +
 drivers/staging/cs5535_gpio/TODO           |    6 +
 drivers/staging/cs5535_gpio/cs5535_gpio.c  |  259 ++++++++++++++++++++++++++++
 10 files changed, 294 insertions(+), 269 deletions(-)
 delete mode 100644 drivers/char/cs5535_gpio.c
 create mode 100644 drivers/staging/cs5535_gpio/Kconfig
 create mode 100644 drivers/staging/cs5535_gpio/Makefile
 create mode 100644 drivers/staging/cs5535_gpio/TODO
 create mode 100644 drivers/staging/cs5535_gpio/cs5535_gpio.c
Documentation/feature-removal-schedule.txt +14 -0
index 6c2f55e..5092646 100644
@@ -191,6 +191,20 @@ Why:	/proc/<pid>/oom_adj allows userspace to influence the oom killer's
 
 ---------------------------
 
+What:	CS5535/CS5536 obsolete GPIO driver
+When:	June 2011
+Files:	drivers/staging/cs5535_gpio/*
+Check:	drivers/staging/cs5535_gpio/cs5535_gpio.c
+Why:	A newer driver replaces this; it is drivers/gpio/cs5535-gpio.c, and
+	integrates with the Linux GPIO subsystem.  The old driver has been
+	moved to staging, and will be removed altogether around 2.6.40.
+	Please test the new driver, and ensure that the functionality you
+	need and any bugfixes from the old driver are available in the new
+	one.
+Who:	Andres Salomon <[email protected]>
+
+--------------------------
+
 What:	remove EXPORT_SYMBOL(kernel_thread)
 When:	August 2006
 Files:	arch/*/kernel/*_ksyms.c
drivers/char/Kconfig +0 -9
index 43d3395..72d5235 100644
@@ -1038,15 +1038,6 @@ config NSC_GPIO
 	  pc8736x_gpio drivers.  If those drivers are built as
 	  modules, this one will be too, named nsc_gpio
 
-config CS5535_GPIO
-	tristate "AMD CS5535/CS5536 GPIO (Geode Companion Device)"
-	depends on X86_32
-	help
-	  Give userspace access to the GPIO pins on the AMD CS5535 and
-	  CS5536 Geode companion devices.
-
-	  If compiled as a module, it will be called cs5535_gpio.
-
 config RAW_DRIVER
 	tristate "RAW driver (/dev/raw/rawN)"
 	depends on BLOCK
drivers/char/Makefile +0 -1
index ba53ec9..d5132e3 100644
@@ -81,7 +81,6 @@ obj-$(CONFIG_NWFLASH)		+= nwflash.o
 obj-$(CONFIG_SCx200_GPIO)	+= scx200_gpio.o
 obj-$(CONFIG_PC8736x_GPIO)	+= pc8736x_gpio.o
 obj-$(CONFIG_NSC_GPIO)		+= nsc_gpio.o
-obj-$(CONFIG_CS5535_GPIO)	+= cs5535_gpio.o
 obj-$(CONFIG_GPIO_TB0219)	+= tb0219.o
 obj-$(CONFIG_TELCLOCK)		+= tlclk.o
 
drivers/char/cs5535_gpio.c deleted +0 -259

259 lines not on this page · raw message

drivers/staging/Kconfig +2 -0
index 5eafdf4..60eca89 100644
@@ -121,6 +121,8 @@ source "drivers/staging/memrar/Kconfig"
 
 source "drivers/staging/iio/Kconfig"
 
+source "drivers/staging/cs5535_gpio/Kconfig"
+
 source "drivers/staging/zram/Kconfig"
 
 source "drivers/staging/wlags49_h2/Kconfig"
drivers/staging/Makefile +1 -0
index a97a955..c7e6e68 100644
@@ -43,6 +43,7 @@ obj-$(CONFIG_HYPERV)		+= hv/
 obj-$(CONFIG_VME_BUS)		+= vme/
 obj-$(CONFIG_MRST_RAR_HANDLER)	+= memrar/
 obj-$(CONFIG_IIO)		+= iio/
+obj-$(CONFIG_CS5535_GPIO)	+= cs5535_gpio/
 obj-$(CONFIG_ZRAM)		+= zram/
 obj-$(CONFIG_WLAGS49_H2)	+= wlags49_h2/
 obj-$(CONFIG_WLAGS49_H25)	+= wlags49_h25/
drivers/staging/cs5535_gpio/Kconfig new file +11 -0
new file mode 100644
index 0000000..a1b3a8d
@@ -0,0 +1,11 @@
+config CS5535_GPIO
+	tristate "AMD CS5535/CS5536 GPIO (Geode Companion Device)"
+	depends on X86_32
+	help
+	  Note: this driver is DEPRECATED.  Please use the cs5535-gpio module
+	  in the GPIO section instead (CONFIG_GPIO_CS5535).
+
+	  Give userspace access to the GPIO pins on the AMD CS5535 and
+	  CS5536 Geode companion devices.
+
+	  If compiled as a module, it will be called cs5535_gpio.
drivers/staging/cs5535_gpio/Makefile new file +1 -0
new file mode 100644
index 0000000..d67c4b8
@@ -0,0 +1 @@
+obj-$(CONFIG_CS5535_GPIO)	+= cs5535_gpio.o
drivers/staging/cs5535_gpio/TODO new file +6 -0
new file mode 100644
index 0000000..98d1cd1
@@ -0,0 +1,6 @@
+This is an obsolete driver for some the CS5535 and CS5536 southbridge GPIOs.
+It has been replaced by a driver that makes use of the Linux GPIO subsystem.
+Please switch to that driver, and let [email protected] know if there's
+anything missing from the new driver.
+
+This driver is scheduled for removal in 2.6.40.
drivers/staging/cs5535_gpio/cs5535_gpio.c new file +259 -0

259 lines not on this page · raw message

Signature · 1 line
1.7.2.3
#1 lore raw
Quoted 17 lines · On Thu, 9 Dec 2010 12:57:37 -0800 Andres Salomon <[email protected]> wrote:

The newer drivers/gpio/cs5535-gpio.c replaces drivers/misc/cs5535_gpio.c. The new driver has been in the tree for a little while, and has received some testing; it's time to mark the old one as deprecated. I'm thinking removal around 2.6.40 would be good, provided we're not missing critical functionality in the newer driver.

---
 Documentation/feature-removal-schedule.txt |   14 ++
 drivers/char/Kconfig                       |    9 -
 drivers/char/Makefile                      |    1 -
 drivers/char/cs5535_gpio.c                 |  259 ----------------------------
 drivers/staging/Kconfig                    |    2 +
 drivers/staging/Makefile                   |    1 +
 drivers/staging/cs5535_gpio/Kconfig        |   11 ++
 drivers/staging/cs5535_gpio/Makefile       |    1 +
Quoted 8 lines
 drivers/staging/cs5535_gpio/TODO           |    6 +
 drivers/staging/cs5535_gpio/cs5535_gpio.c  |  259 ++++++++++++++++++++++++++++
 10 files changed, 294 insertions(+), 269 deletions(-)
 delete mode 100644 drivers/char/cs5535_gpio.c
 create mode 100644 drivers/staging/cs5535_gpio/Kconfig
 create mode 100644 drivers/staging/cs5535_gpio/Makefile
 create mode 100644 drivers/staging/cs5535_gpio/TODO
 create mode 100644 drivers/staging/cs5535_gpio/cs5535_gpio.c

It seems logical (although not particularly useful) to use drivers/staging/ as the site for unstaging things as well, but is that something which we normally do?

#2 lore raw
Quoted 30 lines · On Thu, 9 Dec 2010 13:13:37 -0800 Andrew Morton <[email protected]>…
Quoted 20 lines · On Thu, 9 Dec 2010 12:57:37 -0800 Andres Salomon <[email protected]> wrote:

The newer drivers/gpio/cs5535-gpio.c replaces drivers/misc/cs5535_gpio.c. The new driver has been in the tree for a little while, and has received some testing; it's time to mark the old one as deprecated. I'm thinking removal around 2.6.40 would be good, provided we're not missing critical functionality in the newer driver.

---
 Documentation/feature-removal-schedule.txt |   14 ++
 drivers/char/Kconfig                       |    9 -
 drivers/char/Makefile                      |    1 -
 drivers/char/cs5535_gpio.c                 |  259
----------------------------
drivers/staging/Kconfig                    |    2 +
drivers/staging/Makefile                   |    1 +
drivers/staging/cs5535_gpio/Kconfig        |   11 ++
drivers/staging/cs5535_gpio/Makefile       |    1 +
drivers/staging/cs5535_gpio/TODO           |    6 +
drivers/staging/cs5535_gpio/cs5535_gpio.c  |  259
Quoted 6 lines

++++++++++++++++++++++++++++ 10 files changed, 294 insertions(+), 269 deletions(-) delete mode 100644 drivers/char/cs5535_gpio.c create mode 100644 drivers/staging/cs5535_gpio/Kconfig create mode 100644 drivers/staging/cs5535_gpio/Makefile create mode 100644 drivers/staging/cs5535_gpio/TODO create mode 100644 drivers/staging/cs5535_gpio/cs5535_gpio.c

Quoted 4 lines

It seems logical (although not particularly useful) to use drivers/staging/ as the site for unstaging things as well, but is that something which we normally do?

FYI, I was using commits 7af97eff and 96322b80 as an example... Though I suppose I really should've chosen commits by two separate authors (oops).

#3 lore raw
In reply to Andrew Morton
Quoted 29 lines · Andrew Morton
Quoted 17 lines · On Thu, 9 Dec 2010 12:57:37 -0800 Andres Salomon <[email protected]> wrote:

The newer drivers/gpio/cs5535-gpio.c replaces drivers/misc/cs5535_gpio.c. The new driver has been in the tree for a little while, and has received some testing; it's time to mark the old one as deprecated. I'm thinking removal around 2.6.40 would be good, provided we're not missing critical functionality in the newer driver.

---
 Documentation/feature-removal-schedule.txt |   14 ++
 drivers/char/Kconfig                       |    9 -
 drivers/char/Makefile                      |    1 -
 drivers/char/cs5535_gpio.c                 |  259 ----------------------------
 drivers/staging/Kconfig                    |    2 +
 drivers/staging/Makefile                   |    1 +
 drivers/staging/cs5535_gpio/Kconfig        |   11 ++
 drivers/staging/cs5535_gpio/Makefile       |    1 +
Quoted 8 lines
 drivers/staging/cs5535_gpio/TODO           |    6 +
 drivers/staging/cs5535_gpio/cs5535_gpio.c  |  259 ++++++++++++++++++++++++++++
 10 files changed, 294 insertions(+), 269 deletions(-)
 delete mode 100644 drivers/char/cs5535_gpio.c
 create mode 100644 drivers/staging/cs5535_gpio/Kconfig
 create mode 100644 drivers/staging/cs5535_gpio/Makefile
 create mode 100644 drivers/staging/cs5535_gpio/TODO
 create mode 100644 drivers/staging/cs5535_gpio/cs5535_gpio.c
Quoted 3 lines

It seems logical (although not particularly useful) to use drivers/staging/ as the site for unstaging things as well, but is that something which we normally do?

Yes, we are using staging to "age out" drivers from the kernel, as well as filesystems, so this is fine with me.

thanks,

greg k-h

Acked-by on v1 1/1
#4 lore raw
In reply to Andres Salomon
Quoted 9 lines

The newer drivers/gpio/cs5535-gpio.c replaces drivers/misc/cs5535_gpio.c. The new driver has been in the tree for a little while, and has received some testing; it's time to mark the old one as deprecated. I'm thinking removal around 2.6.40 would be good, provided we're not missing critical functionality in the newer driver.

Thanks for taking care of this.

Ben
This email and any attachments are only for use by the intended recipient(s) and may contain legally privileged, confidential, proprietary or otherwise private information. Any unauthorized use, reproduction, dissemination, distribution or other disclosure of the contents of this e-mail or its attachments is strictly prohibited. If you have received this email in error, please notify the sender immediately and delete the original.