Skip to contentSkip to conversation

Link directly to the archive files rather than using search paths.

PATCH In review Diego Elio Pettenò 2 participants 4 messages Dec 10, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Link directly to the archive files rather than using search paths.

While the previous code was supposed to work nonetheless, it could be messed up if further -L were used in LDFLAGS to list the path where glibc's libutil was to be found.

References: https://bugs.gentoo.org/347489

CC Daniel Kurtz <[email protected]>
CC Mike Frysinger <[email protected]>
---
 Makefile |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Makefile +1 -2
index c03d74c..d1ace1f 100644
@@ -33,11 +33,10 @@ CCOPTS = -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall
 CFLAGS = $(CCOPTS) -I../include $(DEFINES)
 YACCFLAGS = -d -t -v
 
-LDLIBS += -L../lib -lnetlink -lutil
-
 SUBDIRS=lib ip tc misc netem genl
 
 LIBNETLINK=../lib/libnetlink.a ../lib/libutil.a
+LDLIBS += $(LIBNETLINK)
 
 all: Config
 	@set -e; \
Signature · 1 line
1.7.3.3
#1 lore raw
Quoted 20 lines · On Fri, 10 Dec 2010 01:56:12 +0100 Diego Elio Pettenò <[email protected]>…

While the previous code was supposed to work nonetheless, it could be messed up if further -L were used in LDFLAGS to list the path where glibc's libutil was to be found.

References: https://bugs.gentoo.org/347489

CC Daniel Kurtz <[email protected]>
CC Mike Frysinger <[email protected]>
---
 Makefile |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Makefile +0 -0
index c03d74c..d1ace1f 100644
@@ -33,11 +33,10 @@ CCOPTS = -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall
 CFLAGS = $(CCOPTS) -I../include $(DEFINES)
 YACCFLAGS = -d -t -v

Makefile CCOPTS = -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall · line 42

Quoted 10 lines
Makefile +1 -2
 
-LDLIBS += -L../lib -lnetlink -lutil
-
 SUBDIRS=lib ip tc misc netem genl
 
 LIBNETLINK=../lib/libnetlink.a ../lib/libutil.a
+LDLIBS += $(LIBNETLINK)
 
 all: Config
 	@set -e; \

Please be more clear in your subject, yes I can tell this is for iproute utilities but others may not.

When refering to "previous code" either reply to the original message thread or provide a link to the changes.

#2 lore raw

Il giorno gio, 09/12/2010 alle 17.56 -0800, Stephen Hemminger ha scritto:

Quoted 2 lines

Please be more clear in your subject, yes I can tell this is for iproute utilities but others may not.

Sorry, I should have used --subject-prefix, will make sure to set it into the configuration file for the future.

Quoted 2 lines

When refering to "previous code" either reply to the original message thread or provide a link to the changes.

Uhm, the "previous code" in here is "the Makefile as it was before the patch", want me to rephrase and resend?

Signature · 5 lines
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/
#3 lore raw
Quoted 5 lines · On Fri, 10 Dec 2010 03:02:00 +0100 Diego Elio Pettenò <[email protected]>…

Il giorno gio, 09/12/2010 alle 17.56 -0800, Stephen Hemminger ha scritto:

Quoted 2 lines

Please be more clear in your subject, yes I can tell this is for iproute utilities but others may not.

Quoted 9 lines

Sorry, I should have used --subject-prefix, will make sure to set it into the configuration file for the future.

Quoted 2 lines

When refering to "previous code" either reply to the original message thread or provide a link to the changes.

Uhm, the "previous code" in here is "the Makefile as it was before the patch", want me to rephrase and resend?

No. just wanted to make sure. I take any fix as long as it is clear what it is doing.