Skip to contentSkip to conversation

segfault in imsm create with wrong arguments

PATCH In review Luca Berra 2 participants 2 messages Dec 12, 2010 – Dec 13, 2010 MD RAID

lore
Share & tools
lore

Luca Berra

author
#0 lore raw

PATCH 1/1 segfault in imsm create with wrong arguments

When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting

Signature · 1 line
Luca Berra -- [email protected]

When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting

super-intel.c renamed from super-intel.c.bluca +1 -1
diff -p -up mdadm-3.1.4/super-intel.c.bluca mdadm-3.1.4/super-intel.c
@@ -4119,7 +4119,7 @@ static int default_chunk_imsm(struct sup
 {
 	struct intel_super *super = st->sb;
 
-	if (!super->orom)
+	if (!super || !super->orom)
 		return 0;
 
 	return imsm_orom_default_chunk(super->orom);
#1 lore raw
Quoted 4 lines · On Sun, 12 Dec 2010 12:33:55 +0100 Luca Berra <[email protected]> wrote:

When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting

Thanks. Applied.

NeilBrown