Skip to contentSkip to conversation

fsnotify & sysfs

PATCH Rodolfo Giometti 2 participants 2 messages Dec 12, 2010 Driver core

lore
Share & tools
lore
#0 lore raw

Hello,

I know that a sysfs file may be pollable but I'm asking to myself how it could be difficult adding notifying support also.

Maybe adding a call to the fsnotify subsystem within the sysfs_notify() function as follow can do the trick?

fs/sysfs/file.c +0 -0
index da3fefe..afee69f 100644
@@ -484,8 +486,10 @@ void sysfs_notify(struct kobject *k, const char

*dir, const

                sd = sysfs_find_dirent(sd, NULL, dir);
        if (sd && attr)
                sd = sysfs_find_dirent(sd, NULL, attr);
-       if (sd)
+       if (sd) {
                sysfs_notify_dirent(sd);

+ fsnotify_change(dentry, ATTR_SIZE);
+ }

        mutex_unlock(&sysfs_mutex);

}

However my problem is how to get the struct dentry pointer needed by fsnotify_change() related to the struct sysfs_dirent pointer passed to sysfs_notify(). :(

Can you please give me any advice about to solve it?

Another question: in file linux/fs/sysfs/file.c I see:

   #include <linux/fsnotify.h>

but none of its functions are called into file.c... maybe it's a mistake?

Thanks in advance,

Rodolfo

Signature · 5 lines
GNU/Linux Solutions                  e-mail: [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
#1 lore raw
Quoted 7 lines · Rodolfo Giometti

Hello,

I know that a sysfs file may be pollable but I'm asking to myself how it could be difficult adding notifying support also.

Maybe adding a call to the fsnotify subsystem within the sysfs_notify() function as follow can do the trick?

Perhaps, does that work?

Quoted 3 lines

However my problem is how to get the struct dentry pointer needed by fsnotify_change() related to the struct sysfs_dirent pointer passed to sysfs_notify(). :(

Yup, that's a problem :(

Quoted 8 lines

Can you please give me any advice about to solve it?

Another question: in file linux/fs/sysfs/file.c I see:

   #include <linux/fsnotify.h>

but none of its functions are called into file.c... maybe it's a mistake?

Possibly, but look at the patch that added that line, perhaps it was put there for a reason.

thanks,

greg k-h