tcp: clean up twisted goto in tcp_rcv_synsent_state_process()
Subsystems (3)
PATCH 1/1 tcp: clean up twisted goto in tcp_rcv_synsent_state_process()
Signed-off-by Yoichi Yuasa <[email protected]>
--- net/ipv4/tcp_input.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
net/ipv4/tcp_input.c +4 -4
@@ -5623,9 +5623,7 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb,inet_csk_reset_xmit_timer (sk,ICSK_TIME_DACK ,TCP_DELACK_MAX ,TCP_RTO_MAX ); -discard: -__kfree_skb (skb); -return 0 ; + goto discard; }else {tcp_send_ack (sk); }
@@ -5704,7 +5702,9 @@ discard: discard_and_undo:tcp_clear_options (&tp->rx_opt); tp->rx_opt.mss_clamp = saved_clamp; - goto discard; +discard: +__kfree_skb (skb); +return 0 ; reset_and_undo:tcp_clear_options (&tp->rx_opt);
Signature · 1 line
1.7.3.3
David Miller
maintainerFrom: Yoichi Yuasa <[email protected]>
Date: Mon, 13 Dec 2010 17:11:49 +0900
Quoted 1 line
Signed-off-by Yoichi Yuasa <[email protected]>
I've been reading this stretch of code for 5+ years and it's perfectly readable to me and your version is not any more readable than what's there now.
I'm not applying this, sorry.