Fix NETIF_F_HW_CSUM implementations [v2]
Subsystems (9)
cover Fix NETIF_F_HW_CSUM implementations [v2]
This is a split version of a patch fixing NETIF_F_HW_CSUM implementations in network drivers. For easier review, this is split into three patches:
1. introduce skb_checksum_start_offset() helper
2. convert correct implementations to use the helper from #1
3. fix bad uses of skb_transport_offset() using helper from #1
Patches are against net-next, commit 0dbaee3b37e118a96bb7b8eb0d9bbaeeb46264be
net: Abstract default ADVMSS behind an accessor.
Best Regards,
Michał Mirosław
---
Michał Mirosław (3):
net: Introduce skb_checksum_start_offset()
net: Use skb_checksum_start_offset()
net: Fix drivers advertising HW_CSUM feature to use csum_start
drivers/net/atl1c/atl1c_main.c | 2 +- drivers/net/atl1e/atl1e_main.c | 2 +- drivers/net/atlx/atl1.c | 2 +- drivers/net/cassini.c | 2 +- drivers/net/e1000/e1000_main.c | 2 +- drivers/net/e1000e/netdev.c | 2 +- drivers/net/enic/enic_main.c | 2 +- drivers/net/ixgb/ixgb_main.c | 2 +- drivers/net/ll_temac_main.c | 2 +- drivers/net/macvtap.c | 3 +-- drivers/net/myri10ge/myri10ge.c | 2 +- drivers/net/niu.c | 2 +- drivers/net/skge.c | 2 +- drivers/net/sungem.c | 2 +- drivers/net/sunhme.c | 2 +- drivers/net/tun.c | 2 +- drivers/net/usb/smsc95xx.c | 7 +++---- drivers/net/virtio_net.c | 2 +- drivers/net/vmxnet3/vmxnet3_drv.c | 4 ++-- include/linux/skbuff.h | 5 +++++ net/core/dev.c | 6 +++--- net/core/skbuff.c | 2 +- net/ipv4/udp.c | 2 +- net/packet/af_packet.c | 3 +-- 24 files changed, 33 insertions(+), 31 deletions(-)
Signature · 1 line
1.7.2.3
PATCH 1/3 net: Introduce skb_checksum_start_offset()
Introduce skb_checksum_start_offset() to replace repetitive calculation.
--- include/linux/skbuff.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
include/linux/skbuff.h +5 -0
@@ -1355,6 +1355,11 @@ static inline void skb_set_mac_header(struct sk_buff *skb, const int offset) }#endif /* NET_SKBUFF_DATA_USES_OFFSET */ +static inline int skb_checksum_start_offset (const struct sk_buff *skb) +{ +return skb->csum_start -skb_headroom (skb); +} +static inline int skb_transport_offset (const struct sk_buff *skb) {return skb_transport_header (skb) - skb->data;
Signature · 1 line
1.7.2.3
PATCH 2/3 net: Use skb_checksum_start_offset()
In reply to Michał MirosławReplace skb->csum_start - skb_headroom(skb) with skb_checksum_start_offset().
Note for usb/smsc95xx: skb->data - skb->head == skb_headroom(skb).
--- drivers/net/atlx/atl1.c | 2 +- drivers/net/macvtap.c | 3 +-- drivers/net/tun.c | 2 +- drivers/net/usb/smsc95xx.c | 7 +++---- drivers/net/virtio_net.c | 2 +- net/core/dev.c | 6 +++--- net/core/skbuff.c | 2 +- net/ipv4/udp.c | 2 +- net/packet/af_packet.c | 3 +-- 9 files changed, 13 insertions(+), 16 deletions(-)
drivers/net/atlx/atl1.c +1 -1
@@ -2174,7 +2174,7 @@ static int atl1_tx_csum(struct atl1_adapter *adapter, struct sk_buff *skb,u8 css, cso;if (likely (skb->ip_summed ==CHECKSUM_PARTIAL )) { - css = (u8) (skb->csum_start -skb_headroom (skb)); + css =skb_checksum_start_offset (skb); cso = css + (u8 ) skb->csum_offset;if (unlikely (css &0x1 )) {/* L1 hardware requires an even number here */
drivers/net/macvtap.c +1 -2
@@ -504,8 +504,7 @@ static int macvtap_skb_to_vnet_hdr(const struct sk_buff *skb,if (skb->ip_summed ==CHECKSUM_PARTIAL ) { vnet_hdr->flags =VIRTIO_NET_HDR_F_NEEDS_CSUM ; - vnet_hdr->csum_start = skb->csum_start - -skb_headroom (skb); + vnet_hdr->csum_start =skb_checksum_start_offset (skb); vnet_hdr->csum_offset = skb->csum_offset; }/* else everything is zero */
drivers/net/tun.c +1 -1
@@ -757,7 +757,7 @@ static __inline__ ssize_t tun_put_user(struct tun_struct *tun,if (skb->ip_summed ==CHECKSUM_PARTIAL ) { gso.flags =VIRTIO_NET_HDR_F_NEEDS_CSUM ; - gso.csum_start = skb->csum_start -skb_headroom (skb); + gso.csum_start =skb_checksum_start_offset (skb); gso.csum_offset = skb->csum_offset; }/* else everything is zero */
drivers/net/usb/smsc95xx.c +3 -4
@@ -1163,9 +1163,8 @@ static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb)static u32 smsc95xx_calc_csum_preamble (struct sk_buff *skb) { -int len = skb->data - skb->head; -u16 high_16 = (u16)(skb->csum_offset + skb->csum_start - len); -u16 low_16 = (u16)(skb->csum_start - len); +u16 low_16 = (u16 )skb_checksum_start_offset (skb); +u16 high_16 = low_16 + skb->csum_offset;return (high_16 <<16 ) | low_16; }
@@ -1193,7 +1192,7 @@ static struct sk_buff *smsc95xx_tx_fixup(struct usbnet *dev,if (skb->len <=45 ) {/* workaround - hardware tx checksum does not work * properly with extremely small packets */ -long csstart = skb->csum_start -skb_headroom (skb); +long csstart =skb_checksum_start_offset (skb);__wsum calc =csum_partial (skb->data + csstart, skb->len - csstart,0 ); *((__sum16 *)(skb->data + csstart
drivers/net/virtio_net.c +1 -1
@@ -519,7 +519,7 @@ static int xmit_skb(struct virtnet_info *vi, struct sk_buff *skb)if (skb->ip_summed ==CHECKSUM_PARTIAL ) { hdr->hdr.flags =VIRTIO_NET_HDR_F_NEEDS_CSUM ; - hdr->hdr.csum_start = skb->csum_start -skb_headroom (skb); + hdr->hdr.csum_start =skb_checksum_start_offset (skb); hdr->hdr.csum_offset = skb->csum_offset; }else { hdr->hdr.flags =0 ;
net/core/dev.c +3 -3
@@ -1761,7 +1761,7 @@ int skb_checksum_help(struct sk_buff *skb) goto out_set_summed; } - offset = skb->csum_start -skb_headroom (skb); + offset =skb_checksum_start_offset (skb);BUG_ON (offset >=skb_headlen (skb)); csum =skb_checksum (skb, offset, skb->len - offset,0 );
@@ -2058,8 +2058,8 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,* checksumming here. */ if (skb->ip_summed ==CHECKSUM_PARTIAL ) { -skb_set_transport_header (skb, skb->csum_start - -skb_headroom (skb)); +skb_set_transport_header (skb, +skb_checksum_start_offset (skb));if (!dev_can_checksum (dev, skb) &&skb_checksum_help (skb)) goto out_kfree_skb;
net/core/skbuff.c +1 -1
@@ -1824,7 +1824,7 @@ void skb_copy_and_csum_dev(const struct sk_buff *skb, u8 *to)long csstart;if (skb->ip_summed ==CHECKSUM_PARTIAL ) - csstart = skb->csum_start -skb_headroom (skb); + csstart =skb_checksum_start_offset (skb);else csstart =skb_headlen (skb);
net/ipv4/udp.c +1 -1
@@ -2226,7 +2226,7 @@ struct sk_buff *udp4_ufo_fragment(struct sk_buff *skb, int features)/* Do software UFO. Complete and fill in the UDP checksum as HW cannot * do checksum of UDP packets sent as multiple IP fragments. */ - offset = skb->csum_start -skb_headroom (skb); + offset =skb_checksum_start_offset (skb); csum =skb_checksum (skb, offset, skb->len - offset,0 ); offset += skb->csum_offset; *(__sum16 *)(skb->data + offset) =csum_fold (csum);
net/packet/af_packet.c +1 -2
@@ -1650,8 +1650,7 @@ static int packet_recvmsg(struct kiocb *iocb, struct socket *sock,if (skb->ip_summed ==CHECKSUM_PARTIAL ) { vnet_hdr.flags =VIRTIO_NET_HDR_F_NEEDS_CSUM ; - vnet_hdr.csum_start = skb->csum_start - -skb_headroom (skb); + vnet_hdr.csum_start =skb_checksum_start_offset (skb); vnet_hdr.csum_offset = skb->csum_offset; }/* else everything is zero */
Signature · 1 line
1.7.2.3
PATCH 3/3 net: Fix drivers advertising HW_CSUM feature to use csum_start
In reply to Michał MirosławSome drivers are using skb_transport_offset(skb) instead of skb->csum_start for NETIF_F_HW_CSUM offload. This does not matter now, but if someone implements checksumming of encapsulated packets then this will break silently.
TSO output paths are left as they are, since they are for IP+TCP only (might be worth converting though).
--- drivers/net/atl1c/atl1c_main.c | 2 +- drivers/net/atl1e/atl1e_main.c | 2 +- drivers/net/cassini.c | 2 +- drivers/net/e1000/e1000_main.c | 2 +- drivers/net/e1000e/netdev.c | 2 +- drivers/net/enic/enic_main.c | 2 +- drivers/net/ixgb/ixgb_main.c | 2 +- drivers/net/ll_temac_main.c | 2 +- drivers/net/myri10ge/myri10ge.c | 2 +- drivers/net/niu.c | 2 +- drivers/net/skge.c | 2 +- drivers/net/sungem.c | 2 +- drivers/net/sunhme.c | 2 +- drivers/net/vmxnet3/vmxnet3_drv.c | 4 ++-- 14 files changed, 15 insertions(+), 15 deletions(-)
drivers/net/atl1c/atl1c_main.c +1 -1
@@ -2078,7 +2078,7 @@ static int atl1c_tso_csum(struct atl1c_adapter *adapter, check_sum:if (likely (skb->ip_summed ==CHECKSUM_PARTIAL )) {u8 css, cso; - cso =skb_transport_offset (skb); + cso =skb_checksum_start_offset (skb);if (unlikely (cso &0x1 )) {if (netif_msg_tx_err (adapter))
drivers/net/atl1e/atl1e_main.c +1 -1
@@ -1649,7 +1649,7 @@ check_sum:if (likely (skb->ip_summed ==CHECKSUM_PARTIAL )) {u8 css, cso; - cso =skb_transport_offset (skb); + cso =skb_checksum_start_offset (skb);if (unlikely (cso &0x1 )) {netdev_err (adapter->netdev,"payload offset should not ant event number\n" );
drivers/net/cassini.c +1 -1
@@ -2788,7 +2788,7 @@ static inline int cas_xmit_tx_ringN(struct cas *cp, int ring, ctrl =0 ;if (skb->ip_summed ==CHECKSUM_PARTIAL ) { -const u64 csum_start_off =skb_transport_offset (skb); +const u64 csum_start_off =skb_checksum_start_offset (skb);const u64 csum_stuff_off = csum_start_off + skb->csum_offset; ctrl = TX_DESC_CSUM_EN |
drivers/net/e1000/e1000_main.c +1 -1
@@ -2726,7 +2726,7 @@ static bool e1000_tx_csum(struct e1000_adapter *adapter,break ; } - css =skb_transport_offset (skb); + css =skb_checksum_start_offset (skb); i = tx_ring->next_to_use; buffer_info = &tx_ring->buffer_info[i];
drivers/net/e1000e/netdev.c +1 -1
@@ -4473,7 +4473,7 @@ static bool e1000_tx_csum(struct e1000_adapter *adapter, struct sk_buff *skb)break ; } - css =skb_transport_offset (skb); + css =skb_checksum_start_offset (skb); i = tx_ring->next_to_use; buffer_info = &tx_ring->buffer_info[i];
drivers/net/enic/enic_main.c +1 -1
@@ -702,7 +702,7 @@ static inline void enic_queue_wq_skb_csum_l4(struct enic *enic, {unsigned int head_len =skb_headlen (skb);unsigned int len_left = skb->len - head_len; -unsigned int hdr_len =skb_transport_offset (skb); +unsigned int hdr_len =skb_checksum_start_offset (skb);unsigned int csum_offset = hdr_len + skb->csum_offset;int eop = (len_left ==0 );
drivers/net/ixgb/ixgb_main.c +1 -1
@@ -1262,7 +1262,7 @@ ixgb_tx_csum(struct ixgb_adapter *adapter, struct sk_buff *skb)if (likely (skb->ip_summed ==CHECKSUM_PARTIAL )) {struct ixgb_buffer *buffer_info; - css =skb_transport_offset (skb); + css =skb_checksum_start_offset (skb); cso = css + skb->csum_offset; i = adapter->tx_ring.next_to_use;
drivers/net/ll_temac_main.c +1 -1
@@ -692,7 +692,7 @@ static int temac_start_xmit(struct sk_buff *skb, struct net_device *ndev) cur_p->app0 =0 ;if (skb->ip_summed ==CHECKSUM_PARTIAL ) { -unsigned int csum_start_off =skb_transport_offset (skb); +unsigned int csum_start_off =skb_checksum_start_offset (skb);unsigned int csum_index_off = csum_start_off + skb->csum_offset; cur_p->app0 |=1 ;/* TX Checksum Enabled */
drivers/net/myri10ge/myri10ge.c +1 -1
@@ -2736,7 +2736,7 @@ again: odd_flag =0 ; flags = (MXGEFW_FLAGS_NO_TSO |MXGEFW_FLAGS_FIRST );if (likely (skb->ip_summed ==CHECKSUM_PARTIAL )) { - cksum_offset =skb_transport_offset (skb); + cksum_offset =skb_checksum_start_offset (skb); pseudo_hdr_offset = cksum_offset + skb->csum_offset;/* If the headers are excessively large, then we must * fall back to a software checksum */
drivers/net/niu.c +1 -1
@@ -6589,7 +6589,7 @@ static u64 niu_compute_tx_flags(struct sk_buff *skb, struct ethhdr *ehdr, (ip_proto ==IPPROTO_UDP ? TXHDR_CSUM_UDP : TXHDR_CSUM_SCTP)); - start =skb_transport_offset (skb) - + start =skb_checksum_start_offset (skb) - (pad_bytes +sizeof (struct tx_pkt_hdr )); stuff = start + skb->csum_offset;
drivers/net/skge.c +1 -1
@@ -2764,7 +2764,7 @@ static netdev_tx_t skge_xmit_frame(struct sk_buff *skb, td->dma_hi = map >>32 ;if (skb->ip_summed ==CHECKSUM_PARTIAL ) { -const int offset =skb_transport_offset (skb); +const int offset =skb_checksum_start_offset (skb);/* This seems backwards, but it is what the sk98lin * does. Looks like hardware is wrong?
drivers/net/sungem.c +1 -1
@@ -1004,7 +1004,7 @@ static netdev_tx_t gem_start_xmit(struct sk_buff *skb, ctrl =0 ;if (skb->ip_summed ==CHECKSUM_PARTIAL ) { -const u64 csum_start_off =skb_transport_offset (skb); +const u64 csum_start_off =skb_checksum_start_offset (skb);const u64 csum_stuff_off = csum_start_off + skb->csum_offset; ctrl = (TXDCTRL_CENAB |
drivers/net/sunhme.c +1 -1
@@ -2266,7 +2266,7 @@ static netdev_tx_t happy_meal_start_xmit(struct sk_buff *skb, tx_flags =TXFLAG_OWN ;if (skb->ip_summed ==CHECKSUM_PARTIAL ) { -const u32 csum_start_off =skb_transport_offset (skb); +const u32 csum_start_off =skb_checksum_start_offset (skb);const u32 csum_stuff_off = csum_start_off + skb->csum_offset; tx_flags = (TXFLAG_OWN | TXFLAG_CSENABLE |
drivers/net/vmxnet3/vmxnet3_drv.c +2 -2
@@ -798,7 +798,7 @@ vmxnet3_parse_and_copy_hdr(struct sk_buff *skb, struct vmxnet3_tx_queue *tq, {struct Vmxnet3_TxDataDesc *tdd; -if (ctx->mss) { +if (ctx->mss) {/* TSO */ ctx->eth_ip_hdr_size =skb_transport_offset (skb); ctx->l4_hdr_size = ((struct tcphdr *)skb_transport_header (skb))->doff *4 ;
@@ -807,7 +807,7 @@ vmxnet3_parse_and_copy_hdr(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,unsigned int pull_size;if (skb->ip_summed ==CHECKSUM_PARTIAL ) { - ctx->eth_ip_hdr_size =skb_transport_offset (skb); + ctx->eth_ip_hdr_size =skb_checksum_start_offset (skb);if (ctx->ipv4) { struct iphdr *iph = (struct iphdr *)
Signature · 14 lines
1.7.2.3 ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Re: [PATCH 3/3] net: Fix drivers advertising HW_CSUM feature to use csum_start
Quoted 8 lines · On Wed, 15 Dec 2010 02:24:08 +0100 (CET) Michał Mirosław…
Some drivers are using
skb_transport_offset(skb)instead ofskb->csum_startforNETIF_F_HW_CSUMoffload. This does not matter now, but if someone implements checksumming of encapsulated packets then this will break silently.TSO output paths are left as they are, since they are for IP+TCP only (might be worth converting though).
Signed-off-by Michał Mirosław <[email protected]>
Which if any of these drivers did you test on real hardware?
Signature · 11 lines
------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Re: [PATCH 3/3] net: Fix drivers advertising HW_CSUM feature to use csum_start
Quoted 11 lines · Stephen Hemminger
Quoted 8 lines · On Wed, 15 Dec 2010 02:24:08 +0100 (CET) Michał Mirosław…
Some drivers are using
skb_transport_offset(skb)instead ofskb->csum_startforNETIF_F_HW_CSUMoffload. This does not matter now, but if someone implements checksumming of encapsulated packets then this will break silently.TSO output paths are left as they are, since they are for IP+TCP only (might be worth converting though).
Signed-off-by Michał Mirosław <[email protected]>Which if any of these drivers did you test on real hardware?
I'm running it on skge, with additional patch that changes it to use NETIF_F_HW_CSUM instead of NETIF_F_IP_CSUM. BTW, why it is not advertising full HW checksum in vanilla kernel? Are there any known hardware bugs in there?
Best Regards,
Michał Mirosław
---
lspci:
02:05.0 Ethernet controller: 3Com Corporation 3c940 10/100/1000Base-T [Marvell] (rev 12)
Subsystem: ASUSTeK Computer Inc. A7V600/P4P800/K8V motherboard
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 64 (5750ns min, 7750ns max), Cache Line Size: 16 bytes
Interrupt: pin A routed to IRQ 22
Region 0: Memory at feafc000 (32-bit, non-prefetchable) [size=16K]
Region 1: I/O ports at d800 [size=256]
Capabilities: <access denied>
Kernel driver in use: skge
Kernel modules: skge
ethtool -k:
Offload parameters for eth3:
rx-checksumming: on
tx-checksumming: on
scatter-gather: on
tcp segmentation offload: off
udp fragmentation offload: off
generic segmentation offload: on
large receive offload: off
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Re: [PATCH 3/3] net: Fix drivers advertising HW_CSUM feature to use csum_start
Quoted 11 lines · On Wed, 15 Dec 2010 19:16:55 +0100 Michał Mirosław <[email protected]>…
Quoted 10 lines · Stephen Hemminger
Quoted 8 lines · On Wed, 15 Dec 2010 02:24:08 +0100 (CET) Michał Mirosław…
Some drivers are using
skb_transport_offset(skb)instead ofskb->csum_startforNETIF_F_HW_CSUMoffload. This does not matter now, but if someone implements checksumming of encapsulated packets then this will break silently.TSO output paths are left as they are, since they are for IP+TCP only (might be worth converting though).
Signed-off-by Michał Mirosław <[email protected]>
Quoted 8 lines
Quoted 1 line
Which if any of these drivers did you test on real hardware?
I'm running it on skge, with additional patch that changes it to use
NETIF_F_HW_CSUMinstead ofNETIF_F_IP_CSUM. BTW, why it is not advertising full HW checksum in vanilla kernel? Are there any known hardware bugs in there?Best Regards,
Michał Mirosław
The driver was written from vendor sk98lin driver and that driver only did IP checksum, therefore I did not trust the hardware. The chipset is old, and not used in new designs, no documentation is up to date (and I didn't have any).
Please don't enable non-IPv4 checksum offload on this hardware, there is too big a risk of it not working on all hardware.
Signature · 11 lines
------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Re: [PATCH 3/3] net: Fix drivers advertising HW_CSUM feature to use csum_start
Quoted 8 lines · Stephen Hemminger
Quoted 6 lines · On Wed, 15 Dec 2010 19:16:55 +0100 Michał Mirosław <[email protected]>…
Quoted 5 lines · Stephen Hemminger
Quoted 3 lines · On Wed, 15 Dec 2010 02:24:08 +0100 (CET) Michał Mirosław…
Some drivers are using
skb_transport_offset(skb)instead ofskb->csum_startforNETIF_F_HW_CSUMoffload. This does not matter now, but if someone implements checksumming of encapsulated packets then this will break silently.
[...]
Quoted 11 lines
Quoted 4 lines
Quoted 1 line
Which if any of these drivers did you test on real hardware?
I'm running it on skge, with additional patch that changes it to use
NETIF_F_HW_CSUMinstead ofNETIF_F_IP_CSUM. BTW, why it is not advertising full HW checksum in vanilla kernel? Are there any known hardware bugs in there?The driver was written from vendor sk98lin driver and that driver only did IP checksum, therefore I did not trust the hardware. The chipset is old, and not used in new designs, no documentation is up to date (and I didn't have any).
Please don't enable non-IPv4 checksum offload on this hardware, there is too big a risk of it not working on all hardware.
Sure, this can stay in my private patchlist. I can also add a module option (disabled by default) for the brave ones if you'd accept that.
Best Regards,
Michał Mirosław
David Miller
maintainerFrom: Michał Mirosław <[email protected]>
Date: Wed, 15 Dec 2010 02:24:08 +0100 (CET)
Quoted 6 lines
This is a split version of a patch fixing
NETIF_F_HW_CSUMimplementations in network drivers. For easier review, this is split into three patches:1. introduce
skb_checksum_start_offset()helper
2. convert correct implementations to use the helper from #1
3. fix bad uses ofskb_transport_offset()using helper from #1
I don't have any idea why you'd CC: as the networking maintainer only on some of these patches.
That doesn't make any sense at all.
Either CC: me on all of them, or none. Don't partially CC: as that makes it painful for me to manage my inbox.
Thank you.
David Miller
maintainerFrom: Michał Mirosław <[email protected]>
Date: Wed, 15 Dec 2010 02:24:08 +0100 (CET)
Quoted 6 lines
This is a split version of a patch fixing
NETIF_F_HW_CSUMimplementations in network drivers. For easier review, this is split into three patches:1. introduce
skb_checksum_start_offset()helper
2. convert correct implementations to use the helper from #1
3. fix bad uses ofskb_transport_offset()using helper from #1
Looks good, all applied, thanks!