Skip to contentSkip to conversation

coretemp: fix junction temperature for Intel CE4100

PATCH In review Florian Fainelli 3 participants 4 messages Dec 14, 2010 – Dec 27, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 coretemp: fix junction temperature for Intel CE4100

From: Florian Fainelli <[email protected]>

The Intel CE4100 System-on-a-Chip has a slightly higher junction temperature (110 degrees Celsius) than other Atom-based hardware.

---

drivers/hwmon/coretemp.c +17 -6
index 42de98d..e47b405 100644
@@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *
 
 		host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
 
-		if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL
-		    && (host_bridge->device == 0xa000	/* NM10 based nettop */
-		    || host_bridge->device == 0xa010))	/* NM10 based netbook */
-			tjmax = 100000;
-		else
-			tjmax = 90000;
+		if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL) {
+			switch (host_bridge->device) {
+			/* NM10 based nettop */
+			case 0xa000:
+			/* NM10 based netbook */
+			case 0xa010:
+				tjmax = 100000;
+				break;
+			/* IntelCE Sodaville (CE4100) */
+			case 0x0708:
+				tjmax = 110000;
+				break;
+			default:
+				tjmax = 90000;
+				break;
+			}
+		}
 
 		pci_dev_put(host_bridge);
 	}
Signature · 1 line
1.7.1
#1 lore raw
Quoted 9 lines · On Tuesday 14 December 2010 22:17:07 Florian Fainelli wrote:

From: Florian Fainelli <[email protected]>

The Intel CE4100 System-on-a-Chip has a slightly higher junction temperature (110 degrees Celsius) than other Atom-based hardware.

Fenghua, is there anything wrong with that patch? Thank you.

Quoted 36 lines

---

drivers/hwmon/coretemp.c +17 -6
index 42de98d..e47b405 100644
@@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86
 *c, u32 id, struct device *
 
 		host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
 
-		if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL
-		    && (host_bridge->device == 0xa000	/* NM10 based nettop */
-		    || host_bridge->device == 0xa010))	/* NM10 based netbook */
-			tjmax = 100000;
-		else
-			tjmax = 90000;
+		if (host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL) {
+			switch (host_bridge->device) {
+			/* NM10 based nettop */
+			case 0xa000:
+			/* NM10 based netbook */
+			case 0xa010:
+				tjmax = 100000;
+				break;
+			/* IntelCE Sodaville (CE4100) */
+			case 0x0708:
+				tjmax = 110000;
+				break;
+			default:
+				tjmax = 90000;
+				break;
+			}
+		}
 
 		pci_dev_put(host_bridge);

}

#2 lore raw
In reply to Florian Fainelli
Quoted 48 lines

-----Original Message-----
From: Florian Fainelli [mailto:[email protected]] On Behalf Of Florian Fainelli
Sent: Tuesday, December 14, 2010 1:17 PM
To: [email protected]; Dirk Brandewie; [email protected]; Yu, Fenghua
Subject: [PATCH] coretemp: fix junction temperature for Intel CE4100

From: Florian Fainelli <[email protected]>

The Intel CE4100 System-on-a-Chip has a slightly higher junction temperature
(110 degrees Celsius) than other Atom-based hardware.

---

drivers/hwmon/coretemp.c +0 -0
index 42de98d..e47b405 100644
@@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct

cpuinfo_x86 *c, u32 id, struct device *

drivers/hwmon/coretemp.c +0 -1
 		host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
 
-		if (host_bridge && host_bridge->vendor ==

PCI_VENDOR_ID_INTEL

drivers/hwmon/coretemp.c +0 -1
-		    && (host_bridge->device == 0xa000	/* NM10 based

nettop */

drivers/hwmon/coretemp.c +0 -1
-		    || host_bridge->device == 0xa010))	/* NM10 based

netbook */

drivers/hwmon/coretemp.c +1 -3
-			tjmax = 100000;
-		else
-			tjmax = 90000;
+		if (host_bridge && host_bridge->vendor ==

PCI_VENDOR_ID_INTEL) {

drivers/hwmon/coretemp.c +9 -0
+			switch (host_bridge->device) {
+			/* NM10 based nettop */
+			case 0xa000:
+			/* NM10 based netbook */
+			case 0xa010:
+				tjmax = 100000;
+				break;
+			/* IntelCE Sodaville (CE4100) */
+			case 0x0708:

drivers/hwmon/coretemp.c static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device * · line 200

Quoted 10 lines
drivers/hwmon/coretemp.c +7 -0
+				tjmax = 110000;
+				break;
+			default:
+				tjmax = 90000;
+				break;
+			}
+		}
 
 		pci_dev_put(host_bridge);
 	}

When host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL is not true, tjmax is not assigned to 90000. This is different from original code.

Could you add public spec URL or public spec name for 110 degrees C in your comments? People may get lost to find this info.

Thanks.

-Fenghua

#3 lore raw

Hello,

Quoted 56 lines · Fenghua
Quoted 56 lines

-----Original Message-----
From: Florian Fainelli [mailto:[email protected]] On Behalf Of Florian Fainelli
Sent: Tuesday, December 14, 2010 1:17 PM
To: [email protected]; Dirk Brandewie; [email protected]; Yu, Fenghua
Subject: [PATCH] coretemp: fix junction temperature for Intel CE4100

From: Florian Fainelli <[email protected]>

The Intel CE4100 System-on-a-Chip has a slightly higher junction temperature
(110 degrees Celsius) than other Atom-based hardware.

---

drivers/hwmon/coretemp.c +0 -0
index 42de98d..e47b405 100644
@@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct

cpuinfo_x86 *c, u32 id, struct device *

drivers/hwmon/coretemp.c +0 -1
 		host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
 
-		if (host_bridge && host_bridge->vendor ==

PCI_VENDOR_ID_INTEL

drivers/hwmon/coretemp.c +0 -1
-		    && (host_bridge->device == 0xa000	/* NM10 based

nettop */

drivers/hwmon/coretemp.c +0 -1
-		    || host_bridge->device == 0xa010))	/* NM10 based

netbook */

drivers/hwmon/coretemp.c +1 -3
-			tjmax = 100000;
-		else
-			tjmax = 90000;
+		if (host_bridge && host_bridge->vendor ==

PCI_VENDOR_ID_INTEL) {

drivers/hwmon/coretemp.c +16 -0
+			switch (host_bridge->device) {
+			/* NM10 based nettop */
+			case 0xa000:
+			/* NM10 based netbook */
+			case 0xa010:
+				tjmax = 100000;
+				break;
+			/* IntelCE Sodaville (CE4100) */
+			case 0x0708:
+				tjmax = 110000;
+				break;
+			default:
+				tjmax = 90000;
+				break;
+			}
+		}
Quoted 6 lines

drivers/hwmon/coretemp.c static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device * · line 200

Quoted 3 lines
drivers/hwmon/coretemp.c +0 -0
 		pci_dev_put(host_bridge);
 
 	}

When host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL is not true, tjmax is not assigned to 90000. This is different from original code.

Whoops, I will post a second version of that patch.

Quoted 3 lines

Could you add public spec URL or public spec name for 110 degrees C in your comments? People may get lost to find this info.

I will try to find a public documentation stating that, but that was in the SDK we received and I could not find any public information about this yet. --
Florian